Re: [PATCH net-next 13/13] net: renesas: rswitch: add vlan aware switching

Re: [PATCH net-next 13/13] net: renesas: rswitch: add vlan aware switching

[kernel test robot]

Hi Michael,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 1f318b96cc84d7c2ab792fcc0bfd42a7ca890681]

url:    https://github.com/intel-lab-lkp/linux/commits/Michael-Dege/net-renesas-rswitch-improve-port-change-mode-functions/20260318-221709
base:   1f318b96cc84d7c2ab792fcc0bfd42a7ca890681
patch link:    https://lore.kernel.org/r/20260317-rswitch_add_vlans-v1-13-3a57bfa0f2d1%40renesas.com
patch subject: [PATCH net-next 13/13] net: renesas: rswitch: add vlan aware switching
config: sparc64-allmodconfig (https://download.01.org/0day-ci/archive/20260319/202603190927.5oLw58VC-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 4abb927bacf37f18f6359a41639a6d1b3bffffb5)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260319/202603190927.5oLw58VC-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603190927.5oLw58VC-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/renesas/rswitch_l2.c:268:7: warning: variable 'err' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized]
     268 |         case SWITCHDEV_ATTR_ID_BRIDGE_MC_DISABLED:
         |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/renesas/rswitch_l2.c:275:6: note: uninitialized use occurs here
     275 |         if (err < 0)
         |             ^~~
   drivers/net/ethernet/renesas/rswitch_l2.c:264:7: warning: variable 'err' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized]
     264 |         case SWITCHDEV_ATTR_ID_BRIDGE_VLAN_FILTERING:
         |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/renesas/rswitch_l2.c:275:6: note: uninitialized use occurs here
     275 |         if (err < 0)
         |             ^~~
   drivers/net/ethernet/renesas/rswitch_l2.c:251:9: note: initialize the variable 'err' to silence this warning
     251 |         int err;
         |                ^
         |                 = 0
   2 warnings generated.


vim +/err +268 drivers/net/ethernet/renesas/rswitch_l2.c

   244	
   245	static int rswitch_handle_port_attr_set(struct net_device *ndev,
   246						struct notifier_block *nb,
   247						struct switchdev_notifier_port_attr_info *info)
   248	{
   249		const struct switchdev_attr *attr = info->attr;
   250		struct rswitch_private *priv;
   251		int err;
   252	
   253		priv = container_of(nb, struct rswitch_private, rswitch_switchdev_blocking_nb);
   254	
   255		switch (attr->id) {
   256		case SWITCHDEV_ATTR_ID_PORT_STP_STATE:
   257			err = rswitch_port_update_stp_state(ndev, attr->u.stp_state);
   258	
   259			break;
   260		case SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME:
   261			err = rswitch_update_ageing_time(priv, attr->u.ageing_time);
   262	
   263			break;
   264		case SWITCHDEV_ATTR_ID_BRIDGE_VLAN_FILTERING:
   265			rswitch_update_vlan_filtering(priv, attr->u.vlan_filtering);
   266	
   267			break;
 > 268		case SWITCHDEV_ATTR_ID_BRIDGE_MC_DISABLED:
   269	
   270			break;
   271		default:
   272			return -EOPNOTSUPP;
   273		}
   274	
   275		if (err < 0)
   276			return err;
   277	
   278		info->handled = true;
   279	
   280		return NOTIFY_DONE;
   281	}
   282	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki