From: kernel test robot <lkp@intel.com>
To: songxiebing <songxiebing@kylinos.cn>, tiwai@suse.com
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
songxiebing@kylinos.cn, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] ALSA: core/seq: Optimize the return logic in cc_ev_to_ump_midi2
Date: Tue, 24 Mar 2026 12:20:34 +0800 [thread overview]
Message-ID: <202603241242.5Kms3LqO-lkp@intel.com> (raw)
In-Reply-To: <20260323024742.220707-1-songxiebing@kylinos.cn>
Hi songxiebing,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tiwai-sound/for-next]
[also build test WARNING on tiwai-sound/for-linus linus/master v7.0-rc5 next-20260323]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/songxiebing/ALSA-core-seq-Optimize-the-return-logic-in-cc_ev_to_ump_midi2/20260324-013342
base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
patch link: https://lore.kernel.org/r/20260323024742.220707-1-songxiebing%40kylinos.cn
patch subject: [PATCH] ALSA: core/seq: Optimize the return logic in cc_ev_to_ump_midi2
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20260324/202603241242.5Kms3LqO-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260324/202603241242.5Kms3LqO-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603241242.5Kms3LqO-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> sound/core/seq/seq_ump_convert.c:881:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
881 | case UMP_CC_BANK_SELECT_LSB:
| ^
sound/core/seq/seq_ump_convert.c:881:2: note: insert '__attribute__((fallthrough));' to silence this warning
881 | case UMP_CC_BANK_SELECT_LSB:
| ^
| __attribute__((fallthrough));
sound/core/seq/seq_ump_convert.c:881:2: note: insert 'break;' to avoid fall-through
881 | case UMP_CC_BANK_SELECT_LSB:
| ^
| break;
sound/core/seq/seq_ump_convert.c:885:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
885 | case UMP_CC_DATA_LSB:
| ^
sound/core/seq/seq_ump_convert.c:885:2: note: insert '__attribute__((fallthrough));' to silence this warning
885 | case UMP_CC_DATA_LSB:
| ^
| __attribute__((fallthrough));
sound/core/seq/seq_ump_convert.c:885:2: note: insert 'break;' to avoid fall-through
885 | case UMP_CC_DATA_LSB:
| ^
| break;
2 warnings generated.
vim +881 sound/core/seq/seq_ump_convert.c
e9e02819a98a50 Takashi Iwai 2023-05-23 833
e9e02819a98a50 Takashi Iwai 2023-05-23 834 /* convert CC event to MIDI 2.0 UMP */
e9e02819a98a50 Takashi Iwai 2023-05-23 835 static int cc_ev_to_ump_midi2(const struct snd_seq_event *event,
e9e02819a98a50 Takashi Iwai 2023-05-23 836 struct snd_seq_client_port *dest_port,
e9e02819a98a50 Takashi Iwai 2023-05-23 837 union snd_ump_midi2_msg *data,
e9e02819a98a50 Takashi Iwai 2023-05-23 838 unsigned char status)
e9e02819a98a50 Takashi Iwai 2023-05-23 839 {
e9e02819a98a50 Takashi Iwai 2023-05-23 840 unsigned char channel = event->data.control.channel & 0x0f;
e9e02819a98a50 Takashi Iwai 2023-05-23 841 unsigned char index = event->data.control.param & 0x7f;
e9e02819a98a50 Takashi Iwai 2023-05-23 842 unsigned char val = event->data.control.value & 0x7f;
a683030606fa5f Takashi Iwai 2024-07-31 843 struct ump_cvt_to_ump_bank *cc = &dest_port->midi2_bank[channel];
521be8ec43cb74 songxiebing 2026-03-23 844 int ret = 0;
e9e02819a98a50 Takashi Iwai 2023-05-23 845
e9e02819a98a50 Takashi Iwai 2023-05-23 846 /* process special CC's (bank/rpn/nrpn) */
e9e02819a98a50 Takashi Iwai 2023-05-23 847 switch (index) {
e9e02819a98a50 Takashi Iwai 2023-05-23 848 case UMP_CC_RPN_MSB:
a4ff92ff0bdd73 Takashi Iwai 2024-07-31 849 ret = fill_rpn(cc, data, channel, true);
e9e02819a98a50 Takashi Iwai 2023-05-23 850 cc->rpn_set = 1;
e9e02819a98a50 Takashi Iwai 2023-05-23 851 cc->cc_rpn_msb = val;
98ea612dd1150a Takashi Iwai 2024-07-31 852 if (cc->cc_rpn_msb == 0x7f && cc->cc_rpn_lsb == 0x7f)
98ea612dd1150a Takashi Iwai 2024-07-31 853 reset_rpn(cc);
521be8ec43cb74 songxiebing 2026-03-23 854 break;
e9e02819a98a50 Takashi Iwai 2023-05-23 855 case UMP_CC_RPN_LSB:
a4ff92ff0bdd73 Takashi Iwai 2024-07-31 856 ret = fill_rpn(cc, data, channel, true);
e9e02819a98a50 Takashi Iwai 2023-05-23 857 cc->rpn_set = 1;
e9e02819a98a50 Takashi Iwai 2023-05-23 858 cc->cc_rpn_lsb = val;
98ea612dd1150a Takashi Iwai 2024-07-31 859 if (cc->cc_rpn_msb == 0x7f && cc->cc_rpn_lsb == 0x7f)
98ea612dd1150a Takashi Iwai 2024-07-31 860 reset_rpn(cc);
521be8ec43cb74 songxiebing 2026-03-23 861 break;
e9e02819a98a50 Takashi Iwai 2023-05-23 862 case UMP_CC_NRPN_MSB:
a4ff92ff0bdd73 Takashi Iwai 2024-07-31 863 ret = fill_rpn(cc, data, channel, true);
e9e02819a98a50 Takashi Iwai 2023-05-23 864 cc->nrpn_set = 1;
e9e02819a98a50 Takashi Iwai 2023-05-23 865 cc->cc_nrpn_msb = val;
521be8ec43cb74 songxiebing 2026-03-23 866 break;
e9e02819a98a50 Takashi Iwai 2023-05-23 867 case UMP_CC_NRPN_LSB:
a4ff92ff0bdd73 Takashi Iwai 2024-07-31 868 ret = fill_rpn(cc, data, channel, true);
e9e02819a98a50 Takashi Iwai 2023-05-23 869 cc->nrpn_set = 1;
e9e02819a98a50 Takashi Iwai 2023-05-23 870 cc->cc_nrpn_lsb = val;
521be8ec43cb74 songxiebing 2026-03-23 871 break;
e9e02819a98a50 Takashi Iwai 2023-05-23 872 case UMP_CC_DATA:
a4ff92ff0bdd73 Takashi Iwai 2024-07-31 873 cc->cc_data_msb_set = 1;
e9e02819a98a50 Takashi Iwai 2023-05-23 874 cc->cc_data_msb = val;
521be8ec43cb74 songxiebing 2026-03-23 875 ret = fill_rpn(cc, data, channel, false);
521be8ec43cb74 songxiebing 2026-03-23 876 break;
e9e02819a98a50 Takashi Iwai 2023-05-23 877 case UMP_CC_BANK_SELECT:
e9e02819a98a50 Takashi Iwai 2023-05-23 878 cc->bank_set = 1;
e9e02819a98a50 Takashi Iwai 2023-05-23 879 cc->cc_bank_msb = val;
521be8ec43cb74 songxiebing 2026-03-23 880 ret = 0; // skip
e9e02819a98a50 Takashi Iwai 2023-05-23 @881 case UMP_CC_BANK_SELECT_LSB:
e9e02819a98a50 Takashi Iwai 2023-05-23 882 cc->bank_set = 1;
e9e02819a98a50 Takashi Iwai 2023-05-23 883 cc->cc_bank_lsb = val;
521be8ec43cb74 songxiebing 2026-03-23 884 ret = 0; // skip
e9e02819a98a50 Takashi Iwai 2023-05-23 885 case UMP_CC_DATA_LSB:
a4ff92ff0bdd73 Takashi Iwai 2024-07-31 886 cc->cc_data_lsb_set = 1;
e9e02819a98a50 Takashi Iwai 2023-05-23 887 cc->cc_data_lsb = val;
521be8ec43cb74 songxiebing 2026-03-23 888 ret = fill_rpn(cc, data, channel, false);
521be8ec43cb74 songxiebing 2026-03-23 889 break;
521be8ec43cb74 songxiebing 2026-03-23 890 default:
e9e02819a98a50 Takashi Iwai 2023-05-23 891 data->cc.status = status;
e9e02819a98a50 Takashi Iwai 2023-05-23 892 data->cc.channel = channel;
e9e02819a98a50 Takashi Iwai 2023-05-23 893 data->cc.index = index;
e9e02819a98a50 Takashi Iwai 2023-05-23 894 data->cc.data = upscale_7_to_32bit(event->data.control.value & 0x7f);
521be8ec43cb74 songxiebing 2026-03-23 895 ret = 1;
521be8ec43cb74 songxiebing 2026-03-23 896 break;
521be8ec43cb74 songxiebing 2026-03-23 897 }
521be8ec43cb74 songxiebing 2026-03-23 898
521be8ec43cb74 songxiebing 2026-03-23 899 return ret;
e9e02819a98a50 Takashi Iwai 2023-05-23 900 }
e9e02819a98a50 Takashi Iwai 2023-05-23 901
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
parent reply other threads:[~2026-03-24 4:20 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20260323024742.220707-1-songxiebing@kylinos.cn>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202603241242.5Kms3LqO-lkp@intel.com \
--to=lkp@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=songxiebing@kylinos.cn \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox