* Re: [PATCH v5 1/7] NFSD: Extract revoke_one_stid() utility function
[not found] <20260326-umount-kills-nfsv4-state-v5-1-d2ce071b3570@oracle.com>
@ 2026-03-27 5:56 ` kernel test robot
2026-03-27 10:08 ` kernel test robot
2026-03-27 11:13 ` kernel test robot
2 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2026-03-27 5:56 UTC (permalink / raw)
To: Chuck Lever, NeilBrown, Jeff Layton, Olga Kornievskaia, Dai Ngo,
Tom Talpey
Cc: llvm, oe-kbuild-all, linux-nfs, linux-fsdevel, Chuck Lever
Hi Chuck,
kernel test robot noticed the following build errors:
[auto build test ERROR on 65058e9e9b20619f920397f529072e853dd43811]
url: https://github.com/intel-lab-lkp/linux/commits/Chuck-Lever/NFSD-Extract-revoke_one_stid-utility-function/20260327-081757
base: 65058e9e9b20619f920397f529072e853dd43811
patch link: https://lore.kernel.org/r/20260326-umount-kills-nfsv4-state-v5-1-d2ce071b3570%40oracle.com
patch subject: [PATCH v5 1/7] NFSD: Extract revoke_one_stid() utility function
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20260327/202603270629.lOb5BcMW-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260327/202603270629.lOb5BcMW-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603270629.lOb5BcMW-lkp@intel.com/
All errors (new ones prefixed by >>):
>> fs/nfsd/nfs4state.c:1830:14: error: use of undeclared identifier 'state_lock'; did you mean 'task_lock'?
1830 | spin_lock(&state_lock);
| ^~~~~~~~~~
| task_lock
include/linux/sched/task.h:216:20: note: 'task_lock' declared here
216 | static inline void task_lock(struct task_struct *p)
| ^
fs/nfsd/nfs4state.c:1833:16: error: use of undeclared identifier 'state_lock'; did you mean 'task_lock'?
1833 | spin_unlock(&state_lock);
| ^~~~~~~~~~
| task_lock
include/linux/sched/task.h:216:20: note: 'task_lock' declared here
216 | static inline void task_lock(struct task_struct *p)
| ^
2 errors generated.
vim +1830 fs/nfsd/nfs4state.c
1805
1806 static void revoke_one_stid(struct nfs4_client *clp, struct nfs4_stid *stid)
1807 {
1808 struct nfs4_ol_stateid *stp;
1809 struct nfs4_delegation *dp;
1810
1811 switch (stid->sc_type) {
1812 case SC_TYPE_OPEN:
1813 stp = openlockstateid(stid);
1814 mutex_lock_nested(&stp->st_mutex, OPEN_STATEID_MUTEX);
1815 revoke_ol_stid(clp, stp);
1816 mutex_unlock(&stp->st_mutex);
1817 break;
1818 case SC_TYPE_LOCK:
1819 stp = openlockstateid(stid);
1820 mutex_lock_nested(&stp->st_mutex, LOCK_STATEID_MUTEX);
1821 revoke_ol_stid(clp, stp);
1822 mutex_unlock(&stp->st_mutex);
1823 break;
1824 case SC_TYPE_DELEG:
1825 /*
1826 * Extra reference guards against concurrent FREE_STATEID.
1827 */
1828 refcount_inc(&stid->sc_count);
1829 dp = delegstateid(stid);
> 1830 spin_lock(&state_lock);
1831 if (!unhash_delegation_locked(dp, SC_STATUS_ADMIN_REVOKED))
1832 dp = NULL;
1833 spin_unlock(&state_lock);
1834 if (dp)
1835 revoke_delegation(dp);
1836 else
1837 nfs4_put_stid(stid);
1838 break;
1839 case SC_TYPE_LAYOUT:
1840 nfsd4_close_layout(layoutstateid(stid));
1841 break;
1842 }
1843 }
1844
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v5 1/7] NFSD: Extract revoke_one_stid() utility function
[not found] <20260326-umount-kills-nfsv4-state-v5-1-d2ce071b3570@oracle.com>
2026-03-27 5:56 ` [PATCH v5 1/7] NFSD: Extract revoke_one_stid() utility function kernel test robot
@ 2026-03-27 10:08 ` kernel test robot
2026-03-27 11:13 ` kernel test robot
2 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2026-03-27 10:08 UTC (permalink / raw)
To: Chuck Lever, NeilBrown, Jeff Layton, Olga Kornievskaia, Dai Ngo,
Tom Talpey
Cc: llvm, oe-kbuild-all, linux-nfs, linux-fsdevel, Chuck Lever
Hi Chuck,
kernel test robot noticed the following build errors:
[auto build test ERROR on 65058e9e9b20619f920397f529072e853dd43811]
url: https://github.com/intel-lab-lkp/linux/commits/Chuck-Lever/NFSD-Extract-revoke_one_stid-utility-function/20260327-081757
base: 65058e9e9b20619f920397f529072e853dd43811
patch link: https://lore.kernel.org/r/20260326-umount-kills-nfsv4-state-v5-1-d2ce071b3570%40oracle.com
patch subject: [PATCH v5 1/7] NFSD: Extract revoke_one_stid() utility function
config: s390-defconfig (https://download.01.org/0day-ci/archive/20260327/202603271711.Pbg3v6zE-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 054e11d1a17e5ba88bb1a8ef32fad3346e80b186)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260327/202603271711.Pbg3v6zE-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603271711.Pbg3v6zE-lkp@intel.com/
All errors (new ones prefixed by >>):
fs/nfsd/nfs4state.c:1830:14: error: use of undeclared identifier 'state_lock'; did you mean 'task_lock'?
1830 | spin_lock(&state_lock);
| ^~~~~~~~~~
| task_lock
include/linux/sched/task.h:216:20: note: 'task_lock' declared here
216 | static inline void task_lock(struct task_struct *p)
| ^
>> fs/nfsd/nfs4state.c:1830:13: error: incompatible pointer types passing 'void (*)(struct task_struct *)' to parameter of type 'spinlock_t *' (aka 'struct spinlock *') [-Wincompatible-pointer-types]
1830 | spin_lock(&state_lock);
| ^~~~~~~~~~~
include/linux/spinlock.h:338:51: note: passing argument to parameter 'lock' here
338 | static __always_inline void spin_lock(spinlock_t *lock)
| ^
fs/nfsd/nfs4state.c:1833:16: error: use of undeclared identifier 'state_lock'; did you mean 'task_lock'?
1833 | spin_unlock(&state_lock);
| ^~~~~~~~~~
| task_lock
include/linux/sched/task.h:216:20: note: 'task_lock' declared here
216 | static inline void task_lock(struct task_struct *p)
| ^
fs/nfsd/nfs4state.c:1833:15: error: incompatible pointer types passing 'void (*)(struct task_struct *)' to parameter of type 'spinlock_t *' (aka 'struct spinlock *') [-Wincompatible-pointer-types]
1833 | spin_unlock(&state_lock);
| ^~~~~~~~~~~
include/linux/spinlock.h:386:53: note: passing argument to parameter 'lock' here
386 | static __always_inline void spin_unlock(spinlock_t *lock)
| ^
4 errors generated.
vim +1830 fs/nfsd/nfs4state.c
1805
1806 static void revoke_one_stid(struct nfs4_client *clp, struct nfs4_stid *stid)
1807 {
1808 struct nfs4_ol_stateid *stp;
1809 struct nfs4_delegation *dp;
1810
1811 switch (stid->sc_type) {
1812 case SC_TYPE_OPEN:
1813 stp = openlockstateid(stid);
1814 mutex_lock_nested(&stp->st_mutex, OPEN_STATEID_MUTEX);
1815 revoke_ol_stid(clp, stp);
1816 mutex_unlock(&stp->st_mutex);
1817 break;
1818 case SC_TYPE_LOCK:
1819 stp = openlockstateid(stid);
1820 mutex_lock_nested(&stp->st_mutex, LOCK_STATEID_MUTEX);
1821 revoke_ol_stid(clp, stp);
1822 mutex_unlock(&stp->st_mutex);
1823 break;
1824 case SC_TYPE_DELEG:
1825 /*
1826 * Extra reference guards against concurrent FREE_STATEID.
1827 */
1828 refcount_inc(&stid->sc_count);
1829 dp = delegstateid(stid);
> 1830 spin_lock(&state_lock);
1831 if (!unhash_delegation_locked(dp, SC_STATUS_ADMIN_REVOKED))
1832 dp = NULL;
1833 spin_unlock(&state_lock);
1834 if (dp)
1835 revoke_delegation(dp);
1836 else
1837 nfs4_put_stid(stid);
1838 break;
1839 case SC_TYPE_LAYOUT:
1840 nfsd4_close_layout(layoutstateid(stid));
1841 break;
1842 }
1843 }
1844
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v5 1/7] NFSD: Extract revoke_one_stid() utility function
[not found] <20260326-umount-kills-nfsv4-state-v5-1-d2ce071b3570@oracle.com>
2026-03-27 5:56 ` [PATCH v5 1/7] NFSD: Extract revoke_one_stid() utility function kernel test robot
2026-03-27 10:08 ` kernel test robot
@ 2026-03-27 11:13 ` kernel test robot
2 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2026-03-27 11:13 UTC (permalink / raw)
To: Chuck Lever, NeilBrown, Jeff Layton, Olga Kornievskaia, Dai Ngo,
Tom Talpey
Cc: llvm, oe-kbuild-all, linux-nfs, linux-fsdevel, Chuck Lever
Hi Chuck,
kernel test robot noticed the following build errors:
[auto build test ERROR on 65058e9e9b20619f920397f529072e853dd43811]
url: https://github.com/intel-lab-lkp/linux/commits/Chuck-Lever/NFSD-Extract-revoke_one_stid-utility-function/20260327-081757
base: 65058e9e9b20619f920397f529072e853dd43811
patch link: https://lore.kernel.org/r/20260326-umount-kills-nfsv4-state-v5-1-d2ce071b3570%40oracle.com
patch subject: [PATCH v5 1/7] NFSD: Extract revoke_one_stid() utility function
config: loongarch-defconfig (https://download.01.org/0day-ci/archive/20260327/202603271905.vZdE0ulk-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260327/202603271905.vZdE0ulk-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603271905.vZdE0ulk-lkp@intel.com/
All errors (new ones prefixed by >>):
>> fs/nfsd/nfs4state.c:1830:14: error: use of undeclared identifier 'state_lock'; did you mean 'task_lock'?
1830 | spin_lock(&state_lock);
| ^~~~~~~~~~
| task_lock
include/linux/sched/task.h:216:20: note: 'task_lock' declared here
216 | static inline void task_lock(struct task_struct *p)
| ^
fs/nfsd/nfs4state.c:1833:16: error: use of undeclared identifier 'state_lock'; did you mean 'task_lock'?
1833 | spin_unlock(&state_lock);
| ^~~~~~~~~~
| task_lock
include/linux/sched/task.h:216:20: note: 'task_lock' declared here
216 | static inline void task_lock(struct task_struct *p)
| ^
2 errors generated.
vim +1830 fs/nfsd/nfs4state.c
1805
1806 static void revoke_one_stid(struct nfs4_client *clp, struct nfs4_stid *stid)
1807 {
1808 struct nfs4_ol_stateid *stp;
1809 struct nfs4_delegation *dp;
1810
1811 switch (stid->sc_type) {
1812 case SC_TYPE_OPEN:
1813 stp = openlockstateid(stid);
1814 mutex_lock_nested(&stp->st_mutex, OPEN_STATEID_MUTEX);
1815 revoke_ol_stid(clp, stp);
1816 mutex_unlock(&stp->st_mutex);
1817 break;
1818 case SC_TYPE_LOCK:
1819 stp = openlockstateid(stid);
1820 mutex_lock_nested(&stp->st_mutex, LOCK_STATEID_MUTEX);
1821 revoke_ol_stid(clp, stp);
1822 mutex_unlock(&stp->st_mutex);
1823 break;
1824 case SC_TYPE_DELEG:
1825 /*
1826 * Extra reference guards against concurrent FREE_STATEID.
1827 */
1828 refcount_inc(&stid->sc_count);
1829 dp = delegstateid(stid);
> 1830 spin_lock(&state_lock);
1831 if (!unhash_delegation_locked(dp, SC_STATUS_ADMIN_REVOKED))
1832 dp = NULL;
1833 spin_unlock(&state_lock);
1834 if (dp)
1835 revoke_delegation(dp);
1836 else
1837 nfs4_put_stid(stid);
1838 break;
1839 case SC_TYPE_LAYOUT:
1840 nfsd4_close_layout(layoutstateid(stid));
1841 break;
1842 }
1843 }
1844
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-27 11:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260326-umount-kills-nfsv4-state-v5-1-d2ce071b3570@oracle.com>
2026-03-27 5:56 ` [PATCH v5 1/7] NFSD: Extract revoke_one_stid() utility function kernel test robot
2026-03-27 10:08 ` kernel test robot
2026-03-27 11:13 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox