Re: [PATCH] mm/damon: introduce DAMON-based NUMA memory tiering module

Re: [PATCH] mm/damon: introduce DAMON-based NUMA memory tiering module

[kernel test robot]

Hi Josh,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Josh-Law/mm-damon-introduce-DAMON-based-NUMA-memory-tiering-module/20260327-033827
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20260326072737.341964-1-objecting%40objecting.org
patch subject: [PATCH] mm/damon: introduce DAMON-based NUMA memory tiering module
config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20260327/202603272022.tcaGCvSO-lkp@intel.com/config)
compiler: clang version 16.0.6 (https://github.com/llvm/llvm-project 7cbf1a2591520c2491aa35339f227775f4d3adf6)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260327/202603272022.tcaGCvSO-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603272022.tcaGCvSO-lkp@intel.com/

All errors (new ones prefixed by >>):

>> mm/damon/tier.c:283:30: error: too few arguments to function call, expected 5, have 4
                                           param_ctx->min_region_sz);
                                                                   ^
   include/linux/damon.h:995:5: note: 'damon_set_region_biggest_system_ram_default' declared here
   int damon_set_region_biggest_system_ram_default(struct damon_target *t,
       ^
   1 error generated.


vim +283 mm/damon/tier.c

   243	
   244	static int damon_tier_apply_parameters(void)
   245	{
   246		struct damon_ctx *param_ctx;
   247		struct damon_target *param_target;
   248		struct damos *promote_scheme, *demote_scheme;
   249		int err;
   250	
   251		err = damon_modules_new_paddr_ctx_target(&param_ctx, &param_target);
   252		if (err)
   253			return err;
   254	
   255		err = damon_set_attrs(param_ctx, &damon_tier_mon_attrs);
   256		if (err)
   257			goto out;
   258	
   259		err = -ENOMEM;
   260		promote_scheme = damon_tier_new_promote_scheme();
   261		if (!promote_scheme)
   262			goto out;
   263	
   264		demote_scheme = damon_tier_new_demote_scheme();
   265		if (!demote_scheme) {
   266			damon_destroy_scheme(promote_scheme);
   267			goto out;
   268		}
   269	
   270		damon_set_schemes(param_ctx, &promote_scheme, 1);
   271		damon_add_scheme(param_ctx, demote_scheme);
   272	
   273		err = damon_tier_add_quota_goals(promote_scheme, demote_scheme);
   274		if (err)
   275			goto out;
   276		err = damon_tier_add_filters(promote_scheme, demote_scheme);
   277		if (err)
   278			goto out;
   279	
   280		err = damon_set_region_biggest_system_ram_default(param_target,
   281						&monitor_region_start,
   282						&monitor_region_end,
 > 283						param_ctx->min_region_sz);
   284		if (err)
   285			goto out;
   286		err = damon_commit_ctx(ctx, param_ctx);
   287	out:
   288		damon_destroy_ctx(param_ctx);
   289		return err;
   290	}
   291	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki