From: kernel test robot <lkp@intel.com>
To: Zhiping Zhang <zhipingz@meta.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC v2 2/2] RDMA/mlx5: get tph for p2p access when registering dmabuf mr
Date: Mon, 30 Mar 2026 00:41:02 +0800 [thread overview]
Message-ID: <202603300035.HzHCCSdR-lkp@intel.com> (raw)
In-Reply-To: <20260324234615.3731237-3-zhipingz@meta.com>
Hi Zhiping,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:
[auto build test WARNING on awilliam-vfio/next]
[also build test WARNING on awilliam-vfio/for-linus linus/master v7.0-rc5]
[cannot apply to rdma/for-next drm-misc/drm-misc-next next-20260327]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Zhiping-Zhang/vfio-add-callback-to-get-tph-info-for-dmabuf/20260327-214419
base: https://github.com/awilliam/linux-vfio.git next
patch link: https://lore.kernel.org/r/20260324234615.3731237-3-zhipingz%40meta.com
patch subject: [RFC v2 2/2] RDMA/mlx5: get tph for p2p access when registering dmabuf mr
config: sparc64-allmodconfig (https://download.01.org/0day-ci/archive/20260330/202603300035.HzHCCSdR-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 054e11d1a17e5ba88bb1a8ef32fad3346e80b186)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260330/202603300035.HzHCCSdR-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603300035.HzHCCSdR-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/mellanox/mlx5/core/lib/st.c:115:7: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
115 | if (tag == idx_data->tag) {
| ^~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/lib/st.c:148:9: note: uninitialized use occurs here
148 | return ret;
| ^~~
drivers/net/ethernet/mellanox/mlx5/core/lib/st.c:115:3: note: remove the 'if' if its condition is always false
115 | if (tag == idx_data->tag) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
116 | refcount_inc(&idx_data->usecount);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
117 | *st_index = index;
| ~~~~~~~~~~~~~~~~~~
118 | goto end;
| ~~~~~~~~~
119 | }
| ~
drivers/net/ethernet/mellanox/mlx5/core/lib/st.c:102:9: note: initialize the variable 'ret' to silence this warning
102 | int ret;
| ^
| = 0
1 warning generated.
vim +115 drivers/net/ethernet/mellanox/mlx5/core/lib/st.c
888a7776f4fb04 Yishai Hadas 2025-07-17 94
0af7a73615dcee Zhiping Zhang 2026-03-24 95 int mlx5_st_alloc_index_by_tag(struct mlx5_core_dev *dev, u16 tag,
0af7a73615dcee Zhiping Zhang 2026-03-24 96 u16 *st_index)
888a7776f4fb04 Yishai Hadas 2025-07-17 97 {
888a7776f4fb04 Yishai Hadas 2025-07-17 98 struct mlx5_st_idx_data *idx_data;
888a7776f4fb04 Yishai Hadas 2025-07-17 99 struct mlx5_st *st = dev->st;
888a7776f4fb04 Yishai Hadas 2025-07-17 100 unsigned long index;
888a7776f4fb04 Yishai Hadas 2025-07-17 101 u32 xa_id;
888a7776f4fb04 Yishai Hadas 2025-07-17 102 int ret;
888a7776f4fb04 Yishai Hadas 2025-07-17 103
888a7776f4fb04 Yishai Hadas 2025-07-17 104 if (!st)
888a7776f4fb04 Yishai Hadas 2025-07-17 105 return -EOPNOTSUPP;
888a7776f4fb04 Yishai Hadas 2025-07-17 106
2d838c11e10e91 Yishai Hadas 2025-10-27 107 if (st->direct_mode) {
2d838c11e10e91 Yishai Hadas 2025-10-27 108 *st_index = tag;
2d838c11e10e91 Yishai Hadas 2025-10-27 109 return 0;
2d838c11e10e91 Yishai Hadas 2025-10-27 110 }
2d838c11e10e91 Yishai Hadas 2025-10-27 111
888a7776f4fb04 Yishai Hadas 2025-07-17 112 mutex_lock(&st->lock);
888a7776f4fb04 Yishai Hadas 2025-07-17 113
888a7776f4fb04 Yishai Hadas 2025-07-17 114 xa_for_each(&st->idx_xa, index, idx_data) {
888a7776f4fb04 Yishai Hadas 2025-07-17 @115 if (tag == idx_data->tag) {
888a7776f4fb04 Yishai Hadas 2025-07-17 116 refcount_inc(&idx_data->usecount);
888a7776f4fb04 Yishai Hadas 2025-07-17 117 *st_index = index;
888a7776f4fb04 Yishai Hadas 2025-07-17 118 goto end;
888a7776f4fb04 Yishai Hadas 2025-07-17 119 }
888a7776f4fb04 Yishai Hadas 2025-07-17 120 }
888a7776f4fb04 Yishai Hadas 2025-07-17 121
bf4afc53b77aea Linus Torvalds 2026-02-21 122 idx_data = kzalloc_obj(*idx_data);
888a7776f4fb04 Yishai Hadas 2025-07-17 123 if (!idx_data) {
888a7776f4fb04 Yishai Hadas 2025-07-17 124 ret = -ENOMEM;
888a7776f4fb04 Yishai Hadas 2025-07-17 125 goto end;
888a7776f4fb04 Yishai Hadas 2025-07-17 126 }
888a7776f4fb04 Yishai Hadas 2025-07-17 127
888a7776f4fb04 Yishai Hadas 2025-07-17 128 refcount_set(&idx_data->usecount, 1);
888a7776f4fb04 Yishai Hadas 2025-07-17 129 idx_data->tag = tag;
888a7776f4fb04 Yishai Hadas 2025-07-17 130
888a7776f4fb04 Yishai Hadas 2025-07-17 131 ret = xa_alloc(&st->idx_xa, &xa_id, idx_data, st->index_limit, GFP_KERNEL);
888a7776f4fb04 Yishai Hadas 2025-07-17 132 if (ret)
888a7776f4fb04 Yishai Hadas 2025-07-17 133 goto clean_idx_data;
888a7776f4fb04 Yishai Hadas 2025-07-17 134
888a7776f4fb04 Yishai Hadas 2025-07-17 135 ret = pcie_tph_set_st_entry(dev->pdev, xa_id, tag);
888a7776f4fb04 Yishai Hadas 2025-07-17 136 if (ret)
888a7776f4fb04 Yishai Hadas 2025-07-17 137 goto clean_idx_xa;
888a7776f4fb04 Yishai Hadas 2025-07-17 138
888a7776f4fb04 Yishai Hadas 2025-07-17 139 *st_index = xa_id;
888a7776f4fb04 Yishai Hadas 2025-07-17 140 goto end;
888a7776f4fb04 Yishai Hadas 2025-07-17 141
888a7776f4fb04 Yishai Hadas 2025-07-17 142 clean_idx_xa:
888a7776f4fb04 Yishai Hadas 2025-07-17 143 xa_erase(&st->idx_xa, xa_id);
888a7776f4fb04 Yishai Hadas 2025-07-17 144 clean_idx_data:
888a7776f4fb04 Yishai Hadas 2025-07-17 145 kfree(idx_data);
888a7776f4fb04 Yishai Hadas 2025-07-17 146 end:
888a7776f4fb04 Yishai Hadas 2025-07-17 147 mutex_unlock(&st->lock);
888a7776f4fb04 Yishai Hadas 2025-07-17 148 return ret;
888a7776f4fb04 Yishai Hadas 2025-07-17 149 }
0af7a73615dcee Zhiping Zhang 2026-03-24 150 EXPORT_SYMBOL_GPL(mlx5_st_alloc_index_by_tag);
0af7a73615dcee Zhiping Zhang 2026-03-24 151
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
parent reply other threads:[~2026-03-29 16:41 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20260324234615.3731237-3-zhipingz@meta.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202603300035.HzHCCSdR-lkp@intel.com \
--to=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=zhipingz@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox