public inbox for llvm@lists.linux.dev
 help / color / mirror / Atom feed
* [pdx86-platform-drivers-x86:review-ilpo-next 91/98] drivers/platform/x86/intel/int3472/led.c:20:38: error: no member named 'led' in 'struct int3472_discrete_device'; did you mean 'leds'?
@ 2026-04-11  1:27 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-04-11  1:27 UTC (permalink / raw)
  To: Marco Nenciarini
  Cc: llvm, oe-kbuild-all, Andy Shevchenko, Hans de Goede,
	Ilpo Järvinen , Hans de Goede

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-ilpo-next
head:   d0e6904dc063c19e470bb505eb010eb9f1b1148a
commit: bbd917d96aa152a5c4701964db5b28db666f7491 [91/98] platform/x86: int3472: Add support for GPIO type 0x02 (IR flood LED)
config: i386-buildonly-randconfig-001-20260411 (https://download.01.org/0day-ci/archive/20260411/202604110929.MbHQ51V1-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260411/202604110929.MbHQ51V1-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604110929.MbHQ51V1-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/platform/x86/intel/int3472/led.c:20:38: error: no member named 'led' in 'struct int3472_discrete_device'; did you mean 'leds'?
      20 |         struct int3472_led *led = &int3472->led;
         |                                             ^~~
         |                                             leds
   include/linux/platform_data/x86/int3472.h:132:4: note: 'leds' declared here
     132 |         } leds[INT3472_MAX_LEDS];
         |           ^
>> drivers/platform/x86/intel/int3472/led.c:20:22: error: incompatible pointer types initializing 'struct int3472_led *' with an expression of type 'struct int3472_led (*)[2]' [-Werror,-Wincompatible-pointer-types]
      20 |         struct int3472_led *led = &int3472->led;
         |                             ^     ~~~~~~~~~~~~~
   drivers/platform/x86/intel/int3472/led.c:54:38: error: no member named 'led' in 'struct int3472_discrete_device'; did you mean 'leds'?
      54 |         struct int3472_led *led = &int3472->led;
         |                                             ^~~
         |                                             leds
   include/linux/platform_data/x86/int3472.h:132:4: note: 'leds' declared here
     132 |         } leds[INT3472_MAX_LEDS];
         |           ^
   drivers/platform/x86/intel/int3472/led.c:54:22: error: incompatible pointer types initializing 'struct int3472_led *' with an expression of type 'struct int3472_led (*)[2]' [-Werror,-Wincompatible-pointer-types]
      54 |         struct int3472_led *led = &int3472->led;
         |                             ^     ~~~~~~~~~~~~~
   drivers/platform/x86/intel/int3472/led.c:52:6: warning: no previous prototype for function 'skl_int3472_unregister_led' [-Wmissing-prototypes]
      52 | void skl_int3472_unregister_led(struct int3472_discrete_device *int3472)
         |      ^
   drivers/platform/x86/intel/int3472/led.c:52:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
      52 | void skl_int3472_unregister_led(struct int3472_discrete_device *int3472)
         | ^
         | static 
   1 warning and 4 errors generated.


vim +20 drivers/platform/x86/intel/int3472/led.c

5ae20a8050d08a Hans de Goede    2023-01-27  16  
218d3c44f5f0a3 Marco Nenciarini 2026-04-01  17  int skl_int3472_register_led(struct int3472_discrete_device *int3472, struct gpio_desc *gpio,
218d3c44f5f0a3 Marco Nenciarini 2026-04-01  18  			     const char *con_id)
5ae20a8050d08a Hans de Goede    2023-01-27  19  {
39237e3208209d Marco Nenciarini 2026-04-01 @20  	struct int3472_led *led = &int3472->led;
53c5f7f6e7930f Hans de Goede    2023-10-04  21  	char *p;
5ae20a8050d08a Hans de Goede    2023-01-27  22  	int ret;
5ae20a8050d08a Hans de Goede    2023-01-27  23  
d6116d86e58a04 Marco Nenciarini 2026-04-01  24  	if (led->classdev.dev)
5ae20a8050d08a Hans de Goede    2023-01-27  25  		return -EBUSY;
5ae20a8050d08a Hans de Goede    2023-01-27  26  
d6116d86e58a04 Marco Nenciarini 2026-04-01  27  	led->gpio = gpio;
5ae20a8050d08a Hans de Goede    2023-01-27  28  
5ae20a8050d08a Hans de Goede    2023-01-27  29  	/* Generate the name, replacing the ':' in the ACPI devname with '_' */
d6116d86e58a04 Marco Nenciarini 2026-04-01  30  	snprintf(led->name, sizeof(led->name),
218d3c44f5f0a3 Marco Nenciarini 2026-04-01  31  		 "%s::%s_led", acpi_dev_name(int3472->sensor), con_id);
d6116d86e58a04 Marco Nenciarini 2026-04-01  32  	p = strchr(led->name, ':');
5ae20a8050d08a Hans de Goede    2023-01-27  33  	if (p)
5ae20a8050d08a Hans de Goede    2023-01-27  34  		*p = '_';
5ae20a8050d08a Hans de Goede    2023-01-27  35  
d6116d86e58a04 Marco Nenciarini 2026-04-01  36  	led->classdev.name = led->name;
d6116d86e58a04 Marco Nenciarini 2026-04-01  37  	led->classdev.max_brightness = 1;
39237e3208209d Marco Nenciarini 2026-04-01  38  	led->classdev.brightness_set_blocking = int3472_led_set;
5ae20a8050d08a Hans de Goede    2023-01-27  39  
d6116d86e58a04 Marco Nenciarini 2026-04-01  40  	ret = led_classdev_register(int3472->dev, &led->classdev);
5ae20a8050d08a Hans de Goede    2023-01-27  41  	if (ret)
5ccf9873ab2bcb Hans de Goede    2023-10-04  42  		return ret;
5ae20a8050d08a Hans de Goede    2023-01-27  43  
d6116d86e58a04 Marco Nenciarini 2026-04-01  44  	led->lookup.provider = led->name;
d6116d86e58a04 Marco Nenciarini 2026-04-01  45  	led->lookup.dev_id = int3472->sensor_name;
218d3c44f5f0a3 Marco Nenciarini 2026-04-01  46  	led->lookup.con_id = con_id;
d6116d86e58a04 Marco Nenciarini 2026-04-01  47  	led_add_lookup(&led->lookup);
5ae20a8050d08a Hans de Goede    2023-01-27  48  
5ae20a8050d08a Hans de Goede    2023-01-27  49  	return 0;
5ae20a8050d08a Hans de Goede    2023-01-27  50  }
5ae20a8050d08a Hans de Goede    2023-01-27  51  

:::::: The code at line 20 was first introduced by commit
:::::: 39237e3208209d1bb35d939d6fee1f36b642f562 platform/x86: int3472: Rename pled to led in LED registration code

:::::: TO: Marco Nenciarini <mnencia@kcore.it>
:::::: CC: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-04-11  1:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-11  1:27 [pdx86-platform-drivers-x86:review-ilpo-next 91/98] drivers/platform/x86/intel/int3472/led.c:20:38: error: no member named 'led' in 'struct int3472_discrete_device'; did you mean 'leds'? kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox