From: kernel test robot <lkp@intel.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: [bvanassche:scsi-thread-safety 64/68] drivers/scsi/sg.c:842:2: warning: releasing rwlock 'sfp->rq_list_lock' using shared access, expected exclusive access
Date: Thu, 16 Apr 2026 11:57:17 +0800 [thread overview]
Message-ID: <202604161153.TgAss4GY-lkp@intel.com> (raw)
tree: https://github.com/bvanassche/linux scsi-thread-safety
head: 00e2d287e2a16a8d2598582f28442e7ae0aa818a
commit: 1b597fe87b0d136a287571ddce0931edd6488622 [64/68] scsi: core: Enable lock context analysis
config: s390-defconfig (https://download.01.org/0day-ci/archive/20260416/202604161153.TgAss4GY-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 5bac06718f502014fade905512f1d26d578a18f3)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260416/202604161153.TgAss4GY-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604161153.TgAss4GY-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/scsi/sg.c:842:2: warning: releasing rwlock 'sfp->rq_list_lock' using shared access, expected exclusive access [-Wthread-safety-analysis]
842 | read_unlock_irqrestore(&sfp->rq_list_lock, flags);
| ^
include/linux/rwlock.h:104:3: note: expanded from macro 'read_unlock_irqrestore'
104 | _raw_read_unlock_irqrestore(lock, flags); \
| ^
include/linux/rwlock_api_smp.h:110:2: note: expanded from macro '_raw_read_unlock_irqrestore'
110 | __raw_read_unlock_irqrestore(lock, flags)
| ^
drivers/scsi/sg.c:840:2: note: rwlock acquired here
840 | read_lock_irqsave(&sfp->rq_list_lock, flags);
| ^
include/linux/rwlock.h:69:11: note: expanded from macro 'read_lock_irqsave'
69 | flags = _raw_read_lock_irqsave(lock); \
| ^
drivers/scsi/sg.c:1003:5: warning: releasing rwlock 'sfp->rq_list_lock' using shared access, expected exclusive access [-Wthread-safety-analysis]
1003 | read_unlock_irqrestore(&sfp->rq_list_lock,
| ^
include/linux/rwlock.h:104:3: note: expanded from macro 'read_unlock_irqrestore'
104 | _raw_read_unlock_irqrestore(lock, flags); \
| ^
include/linux/rwlock_api_smp.h:110:2: note: expanded from macro '_raw_read_unlock_irqrestore'
110 | __raw_read_unlock_irqrestore(lock, flags)
| ^
drivers/scsi/sg.c:1000:3: note: rwlock acquired here
1000 | read_lock_irqsave(&sfp->rq_list_lock, iflags);
| ^
include/linux/rwlock.h:69:11: note: expanded from macro 'read_lock_irqsave'
69 | flags = _raw_read_lock_irqsave(lock); \
| ^
drivers/scsi/sg.c:1008:3: warning: releasing rwlock 'sfp->rq_list_lock' using shared access, expected exclusive access [-Wthread-safety-analysis]
1008 | read_unlock_irqrestore(&sfp->rq_list_lock, iflags);
| ^
include/linux/rwlock.h:104:3: note: expanded from macro 'read_unlock_irqrestore'
104 | _raw_read_unlock_irqrestore(lock, flags); \
| ^
include/linux/rwlock_api_smp.h:110:2: note: expanded from macro '_raw_read_unlock_irqrestore'
110 | __raw_read_unlock_irqrestore(lock, flags)
| ^
drivers/scsi/sg.c:1000:3: note: rwlock acquired here
1000 | read_lock_irqsave(&sfp->rq_list_lock, iflags);
| ^
include/linux/rwlock.h:69:11: note: expanded from macro 'read_lock_irqsave'
69 | flags = _raw_read_lock_irqsave(lock); \
| ^
drivers/scsi/sg.c:1017:3: warning: releasing rwlock 'sfp->rq_list_lock' using shared access, expected exclusive access [-Wthread-safety-analysis]
1017 | read_unlock_irqrestore(&sfp->rq_list_lock, iflags);
| ^
include/linux/rwlock.h:104:3: note: expanded from macro 'read_unlock_irqrestore'
104 | _raw_read_unlock_irqrestore(lock, flags); \
| ^
include/linux/rwlock_api_smp.h:110:2: note: expanded from macro '_raw_read_unlock_irqrestore'
110 | __raw_read_unlock_irqrestore(lock, flags)
| ^
drivers/scsi/sg.c:1011:3: note: rwlock acquired here
1011 | read_lock_irqsave(&sfp->rq_list_lock, iflags);
| ^
include/linux/rwlock.h:69:11: note: expanded from macro 'read_lock_irqsave'
69 | flags = _raw_read_lock_irqsave(lock); \
| ^
drivers/scsi/sg.c:1086:4: warning: releasing rwlock 'sfp->rq_list_lock' using shared access, expected exclusive access [-Wthread-safety-analysis]
1086 | read_unlock_irqrestore(&sfp->rq_list_lock, iflags);
| ^
include/linux/rwlock.h:104:3: note: expanded from macro 'read_unlock_irqrestore'
104 | _raw_read_unlock_irqrestore(lock, flags); \
| ^
include/linux/rwlock_api_smp.h:110:2: note: expanded from macro '_raw_read_unlock_irqrestore'
110 | __raw_read_unlock_irqrestore(lock, flags)
| ^
drivers/scsi/sg.c:1084:4: note: rwlock acquired here
1084 | read_lock_irqsave(&sfp->rq_list_lock, iflags);
| ^
include/linux/rwlock.h:69:11: note: expanded from macro 'read_lock_irqsave'
69 | flags = _raw_read_lock_irqsave(lock); \
| ^
>> drivers/scsi/sg.c:1189:2: warning: releasing rwlock 'filp->private_data->rq_list_lock' using shared access, expected exclusive access [-Wthread-safety-analysis]
1189 | read_unlock_irqrestore(&sfp->rq_list_lock, iflags);
| ^
include/linux/rwlock.h:104:3: note: expanded from macro 'read_unlock_irqrestore'
104 | _raw_read_unlock_irqrestore(lock, flags); \
| ^
include/linux/rwlock_api_smp.h:110:2: note: expanded from macro '_raw_read_unlock_irqrestore'
110 | __raw_read_unlock_irqrestore(lock, flags)
| ^
drivers/scsi/sg.c:1182:2: note: rwlock acquired here
1182 | read_lock_irqsave(&sfp->rq_list_lock, iflags);
| ^
include/linux/rwlock.h:69:11: note: expanded from macro 'read_lock_irqsave'
69 | flags = _raw_read_lock_irqsave(lock); \
| ^
>> drivers/scsi/sg.c:1616:2: warning: releasing rwlock 'dev_get_drvdata().sfd_lock' using shared access, expected exclusive access [-Wthread-safety-analysis]
1616 | read_unlock_irqrestore(&sdp->sfd_lock, iflags);
| ^
include/linux/rwlock.h:104:3: note: expanded from macro 'read_unlock_irqrestore'
104 | _raw_read_unlock_irqrestore(lock, flags); \
| ^
include/linux/rwlock_api_smp.h:110:2: note: expanded from macro '_raw_read_unlock_irqrestore'
110 | __raw_read_unlock_irqrestore(lock, flags)
| ^
drivers/scsi/sg.c:1610:2: note: rwlock acquired here
1610 | read_lock_irqsave(&sdp->sfd_lock, iflags);
| ^
include/linux/rwlock.h:69:11: note: expanded from macro 'read_lock_irqsave'
69 | flags = _raw_read_lock_irqsave(lock); \
| ^
>> drivers/scsi/sg.c:2269:2: warning: releasing rwlock 'sg_index_lock' using shared access, expected exclusive access [-Wthread-safety-analysis]
2269 | read_unlock_irqrestore(&sg_index_lock, iflags);
| ^
include/linux/rwlock.h:104:3: note: expanded from macro 'read_unlock_irqrestore'
104 | _raw_read_unlock_irqrestore(lock, flags); \
| ^
include/linux/rwlock_api_smp.h:110:2: note: expanded from macro '_raw_read_unlock_irqrestore'
110 | __raw_read_unlock_irqrestore(lock, flags)
| ^
drivers/scsi/sg.c:2267:2: note: rwlock acquired here
2267 | read_lock_irqsave(&sg_index_lock, iflags);
| ^
include/linux/rwlock.h:69:11: note: expanded from macro 'read_lock_irqsave'
69 | flags = _raw_read_lock_irqsave(lock); \
| ^
drivers/scsi/sg.c:2297:2: warning: releasing rwlock 'sg_index_lock' using shared access, expected exclusive access [-Wthread-safety-analysis]
2297 | read_unlock_irqrestore(&sg_index_lock, flags);
| ^
include/linux/rwlock.h:104:3: note: expanded from macro 'read_unlock_irqrestore'
104 | _raw_read_unlock_irqrestore(lock, flags); \
| ^
include/linux/rwlock_api_smp.h:110:2: note: expanded from macro '_raw_read_unlock_irqrestore'
110 | __raw_read_unlock_irqrestore(lock, flags)
| ^
drivers/scsi/sg.c:2286:2: note: rwlock acquired here
2286 | read_lock_irqsave(&sg_index_lock, flags);
| ^
include/linux/rwlock.h:69:11: note: expanded from macro 'read_lock_irqsave'
69 | flags = _raw_read_lock_irqsave(lock); \
| ^
drivers/scsi/sg.c:2496:2: warning: releasing rwlock 'sg_index_lock' using shared access, expected exclusive access [-Wthread-safety-analysis]
2496 | read_unlock_irqrestore(&sg_index_lock, iflags);
| ^
include/linux/rwlock.h:104:3: note: expanded from macro 'read_unlock_irqrestore'
104 | _raw_read_unlock_irqrestore(lock, flags); \
| ^
include/linux/rwlock_api_smp.h:110:2: note: expanded from macro '_raw_read_unlock_irqrestore'
110 | __raw_read_unlock_irqrestore(lock, flags)
| ^
drivers/scsi/sg.c:2481:2: note: rwlock acquired here
2481 | read_lock_irqsave(&sg_index_lock, iflags);
| ^
include/linux/rwlock.h:69:11: note: expanded from macro 'read_lock_irqsave'
69 | flags = _raw_read_lock_irqsave(lock); \
| ^
drivers/scsi/sg.c:2515:2: warning: releasing rwlock 'sg_index_lock' using shared access, expected exclusive access [-Wthread-safety-analysis]
2515 | read_unlock_irqrestore(&sg_index_lock, iflags);
| ^
include/linux/rwlock.h:104:3: note: expanded from macro 'read_unlock_irqrestore'
104 | _raw_read_unlock_irqrestore(lock, flags); \
| ^
include/linux/rwlock_api_smp.h:110:2: note: expanded from macro '_raw_read_unlock_irqrestore'
110 | __raw_read_unlock_irqrestore(lock, flags)
| ^
drivers/scsi/sg.c:2507:2: note: rwlock acquired here
2507 | read_lock_irqsave(&sg_index_lock, iflags);
| ^
include/linux/rwlock.h:69:11: note: expanded from macro 'read_lock_irqsave'
69 | flags = _raw_read_lock_irqsave(lock); \
| ^
drivers/scsi/sg.c:2621:2: warning: releasing rwlock 'sg_index_lock' using shared access, expected exclusive access [-Wthread-safety-analysis]
2621 | read_unlock_irqrestore(&sg_index_lock, iflags);
| ^
include/linux/rwlock.h:104:3: note: expanded from macro 'read_unlock_irqrestore'
104 | _raw_read_unlock_irqrestore(lock, flags); \
| ^
include/linux/rwlock_api_smp.h:110:2: note: expanded from macro '_raw_read_unlock_irqrestore'
110 | __raw_read_unlock_irqrestore(lock, flags)
| ^
drivers/scsi/sg.c:2597:2: note: rwlock acquired here
2597 | read_lock_irqsave(&sg_index_lock, iflags);
| ^
include/linux/rwlock.h:69:11: note: expanded from macro 'read_lock_irqsave'
69 | flags = _raw_read_lock_irqsave(lock); \
| ^
12 warnings generated.
vim +842 drivers/scsi/sg.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 834
6acddc5e911bb3 Jörn Engel 2012-04-12 835 static int srp_done(Sg_fd *sfp, Sg_request *srp)
6acddc5e911bb3 Jörn Engel 2012-04-12 836 {
6acddc5e911bb3 Jörn Engel 2012-04-12 837 unsigned long flags;
6acddc5e911bb3 Jörn Engel 2012-04-12 838 int ret;
6acddc5e911bb3 Jörn Engel 2012-04-12 839
6acddc5e911bb3 Jörn Engel 2012-04-12 840 read_lock_irqsave(&sfp->rq_list_lock, flags);
6acddc5e911bb3 Jörn Engel 2012-04-12 841 ret = srp->done;
6acddc5e911bb3 Jörn Engel 2012-04-12 @842 read_unlock_irqrestore(&sfp->rq_list_lock, flags);
6acddc5e911bb3 Jörn Engel 2012-04-12 843 return ret;
6acddc5e911bb3 Jörn Engel 2012-04-12 844 }
6acddc5e911bb3 Jörn Engel 2012-04-12 845
:::::: The code at line 842 was first introduced by commit
:::::: 6acddc5e911bb3a4a007448371ed7317c85669da [SCSI] sg: prevent unwoken sleep
:::::: TO: Jörn Engel <joern@logfs.org>
:::::: CC: James Bottomley <JBottomley@Parallels.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-04-16 3:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202604161153.TgAss4GY-lkp@intel.com \
--to=lkp@intel.com \
--cc=bvanassche@acm.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox