public inbox for llvm@lists.linux.dev
 help / color / mirror / Atom feed
From: David Laight <david.laight.linux@gmail.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Marco Elver <elver@google.com>,
	kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
	Miguel Ojeda <ojeda@kernel.org>,
	Dmitry Vyukov <dvyukov@google.com>,
	Nathan Chancellor <nathan@kernel.org>,
	llvm@lists.linux.dev
Subject: Re: [PATCH 1/2] Compiler Attributes: Add __access macro
Date: Wed, 22 Apr 2026 14:22:52 +0100	[thread overview]
Message-ID: <20260422142252.2e2c927c@pumpkin> (raw)
In-Reply-To: <CANiq72mzmrfa8-7G92xOdg2sqUgLMdzY_P8THUUYXcSmFCZ6dQ@mail.gmail.com>

On Wed, 22 Apr 2026 12:25:26 +0200
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:

> On Tue, Apr 21, 2026 at 9:30 PM Arnd Bergmann <arnd@arndb.de> wrote:
> >
> > gcc-10 knows the 'access' attribute, but not the 'none' variant:
> >
> > echo 'int f(void *p) __attribute__((access(none, 1)));' | /home/arnd/cross/arm64/gcc-10.5.0-nolibc/aarch64-linux/bin/aarch64-linux-gcc  -xc - -o /dev/null  -c
> > <stdin>:1:1: error: attribute 'access' invalid mode 'none'; expected one of 'read_only', 'read_write', or 'write_only'  
> 
> Which is exactly the one we use in #2, indeed.
> 
> That makes sense, thanks!
> 
> We should still change the number here, because `__has_attribute` will
> pass even with GCC 10, i.e. since someone using `none` without a gate
> in Kconfig or elsewhere may not realize the mistake.
> 
> So we should probably add a comment that the access mode `none` is
> only available in GCC 11 -- especially so if we add the docs David
> suggests, because otherwise it seems like it is supported.

Especially since the gcc docs make it pretty impossible to find out when
anything was added. Trial and error on godbolt shouldn't really be needed.

(and I missed that the size/count is the argument number as well).

	David

> 
> Cheers,
> Miguel
> 


  parent reply	other threads:[~2026-04-22 13:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-21 19:03 [PATCH 1/2] Compiler Attributes: Add __access macro Marco Elver
2026-04-21 19:03 ` [PATCH 2/2] kcsan: Silence -Wmaybe-uninitialized when calling __kcsan_check_access() Marco Elver
2026-04-21 19:15 ` [PATCH 1/2] Compiler Attributes: Add __access macro Miguel Ojeda
2026-04-21 19:20   ` Marco Elver
2026-04-21 19:30     ` Arnd Bergmann
2026-04-21 19:35       ` Marco Elver
2026-04-22 10:25       ` Miguel Ojeda
2026-04-22 10:30         ` Miguel Ojeda
2026-04-22 13:22         ` David Laight [this message]
2026-04-22  5:50 ` Nathan Chancellor
2026-04-22 10:01 ` David Laight
2026-04-22 10:20   ` Marco Elver
2026-04-22 13:06     ` Marco Elver
2026-04-22 10:25   ` Miguel Ojeda
2026-04-22 13:02     ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260422142252.2e2c927c@pumpkin \
    --to=david.laight.linux@gmail.com \
    --cc=arnd@arndb.de \
    --cc=dvyukov@google.com \
    --cc=elver@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=nathan@kernel.org \
    --cc=ojeda@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox