[GIT PULL] Clang build fix for 7.1

[GIT PULL] Clang build fix for 7.1

[Nathan Chancellor]

Hi Linus,

Please pull this single build fix for an instance of a new clang
subwarning under -Wunused-but-set-variable, -Wunused-but-set-global,
that appears in certs/extract-cert.c. If there are any issues, please
let me know.

Cheers,
Nathan

The following changes since commit 028ef9c96e96197026887c0f092424679298aae8:

  Linux 7.0 (2026-04-12 13:48:06 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/nathan/linux.git tags/clang-fixes-7.1-1

for you to fetch changes up to 4f96b7c68a9904e01049ef610d701b382dca9574:

  extract-cert: Wrap key_pass with '#ifdef USE_PKCS11_ENGINE' (2026-04-16 14:21:10 -0700)

----------------------------------------------------------------
Clang build fixes for 7.1

- Wrap declaration and assignment of key_pass in certs/extract-cert.c
  with '#ifdef' that matches its only usage to clear up an instance of a
  new clang subwarning, -Wunused-but-set-global.

Signed-off-by: Nathan Chancellor <nathan@kernel.org>

----------------------------------------------------------------
Nathan Chancellor (1):
      extract-cert: Wrap key_pass with '#ifdef USE_PKCS11_ENGINE'

 certs/extract-cert.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Re: [GIT PULL] Clang build fix for 7.1

[Linus Torvalds]

On Thu, 23 Apr 2026 at 17:04, Nathan Chancellor <nathan@kernel.org> wrote:
>
> Please pull this single build fix for an instance of a new clang
> subwarning under -Wunused-but-set-variable, -Wunused-but-set-global,
> that appears in certs/extract-cert.c. If there are any issues, please
> let me know.

Ugh. I've pulled this, but this is very ugly and does not make the
source code better.

So if these patterns keep happening, I think the whole warning should
just be removed.

                 Linus

Re: [GIT PULL] Clang build fix for 7.1

[Nathan Chancellor]

On Fri, Apr 24, 2026 at 09:33:19AM -0700, Linus Torvalds wrote:
> On Thu, 23 Apr 2026 at 17:04, Nathan Chancellor <nathan@kernel.org> wrote:
> >
> > Please pull this single build fix for an instance of a new clang
> > subwarning under -Wunused-but-set-variable, -Wunused-but-set-global,
> > that appears in certs/extract-cert.c. If there are any issues, please
> > let me know.
> 
> Ugh. I've pulled this, but this is very ugly and does not make the
> source code better.
> 
> So if these patterns keep happening, I think the whole warning should
> just be removed.

Ack. For the record, there were only three instances of this warning in
the host tools (-Wunused-but-set-variable is currently enabled at W=1
for the rest of the kernel so I have not audited those patterns) and of
those, this is the only one where I took the '#ifdef' approach. So I
don't expect this to keep happening but if it does, we can certainly
evaluate turning it off (although I expect new code will just avoid this
warning through the various build reports and such that happen during
development).

Thank you for pulling it despite the ugliness.

Cheers,
Nathan

Re: [GIT PULL] Clang build fix for 7.1

[pr-tracker-bot]

The pull request you sent on Thu, 23 Apr 2026 17:04:13 -0700:

> git://git.kernel.org/pub/scm/linux/kernel/git/nathan/linux.git tags/clang-fixes-7.1-1

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/bbc4af7ad94c452c00e64fc400fc1317351969b4

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html