public inbox for llvm@lists.linux.dev
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [GIT PULL] Clang build fix for 7.1
Date: Fri, 24 Apr 2026 10:13:33 -0700	[thread overview]
Message-ID: <20260424171333.GA3872959@ax162> (raw)
In-Reply-To: <CAHk-=wh9eUk9+BOGwP7ni4OZPZSCfgZQ43n53XWuh3rHhMxwfA@mail.gmail.com>

On Fri, Apr 24, 2026 at 09:33:19AM -0700, Linus Torvalds wrote:
> On Thu, 23 Apr 2026 at 17:04, Nathan Chancellor <nathan@kernel.org> wrote:
> >
> > Please pull this single build fix for an instance of a new clang
> > subwarning under -Wunused-but-set-variable, -Wunused-but-set-global,
> > that appears in certs/extract-cert.c. If there are any issues, please
> > let me know.
> 
> Ugh. I've pulled this, but this is very ugly and does not make the
> source code better.
> 
> So if these patterns keep happening, I think the whole warning should
> just be removed.

Ack. For the record, there were only three instances of this warning in
the host tools (-Wunused-but-set-variable is currently enabled at W=1
for the rest of the kernel so I have not audited those patterns) and of
those, this is the only one where I took the '#ifdef' approach. So I
don't expect this to keep happening but if it does, we can certainly
evaluate turning it off (although I expect new code will just avoid this
warning through the various build reports and such that happen during
development).

Thank you for pulling it despite the ugliness.

Cheers,
Nathan

  reply	other threads:[~2026-04-24 17:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-24  0:04 [GIT PULL] Clang build fix for 7.1 Nathan Chancellor
2026-04-24 16:33 ` Linus Torvalds
2026-04-24 17:13   ` Nathan Chancellor [this message]
2026-04-24 18:32 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260424171333.GA3872959@ax162 \
    --to=nathan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox