From: kernel test robot <lkp@intel.com>
To: Niklas Cassel <cassel@kernel.org>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
0day robot <lkp@intel.com>
Subject: drivers/ata/libata-pmp.c:595:3: error: invalid argument type 'struct work_struct' to unary expression
Date: Sun, 10 May 2026 08:35:42 +0200 [thread overview]
Message-ID: <202605100824.ICLrBkCZ-lkp@intel.com> (raw)
tree: https://github.com/intel-lab-lkp/linux/commits/Niklas-Cassel/ata-libata-scsi-do-not-use-the-deferred-QC-feature-on-PMPs-with-CBS/20260510-083938
head: f7b32ede283da1d05e06942112793f0b352b16b3
commit: f7b32ede283da1d05e06942112793f0b352b16b3 ata: libata-scsi: do not needlessly defer commands when using PMP with FBS
date: 5 hours ago
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20260510/202605100824.ICLrBkCZ-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260510/202605100824.ICLrBkCZ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605100824.ICLrBkCZ-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/ata/libata-pmp.c:595:3: error: invalid argument type 'struct work_struct' to unary expression
595 | WARN_ON(tlink->deferred_qc_work);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/asm-generic/bug.h:110:23: note: expanded from macro 'WARN_ON'
110 | int __ret_warn_on = !!(condition); \
| ^~~~~~~~~~~~
1 error generated.
vim +595 drivers/ata/libata-pmp.c
568
569 /**
570 * sata_pmp_detach - detach a SATA PMP device
571 * @dev: SATA PMP device to detach
572 *
573 * Detach SATA PMP device @dev. This function is also
574 * responsible for deconfiguring PMP links.
575 *
576 * LOCKING:
577 * Kernel thread context (may sleep).
578 */
579 static void sata_pmp_detach(struct ata_device *dev)
580 {
581 struct ata_link *link = dev->link;
582 struct ata_port *ap = link->ap;
583 struct ata_link *tlink;
584 unsigned long flags;
585
586 ata_dev_info(dev, "Port Multiplier detaching\n");
587
588 WARN_ON(!ata_is_host_link(link) || dev->devno ||
589 link->pmp != SATA_PMP_CTRL_PORT);
590
591 if (ap->ops->pmp_detach)
592 ap->ops->pmp_detach(ap);
593
594 ata_for_each_link(tlink, ap, EDGE) {
> 595 WARN_ON(tlink->deferred_qc_work);
596 cancel_work_sync(&tlink->deferred_qc_work);
597 ata_eh_detach_dev(tlink->device);
598 }
599
600 spin_lock_irqsave(ap->lock, flags);
601 ap->nr_pmp_links = 0;
602 link->pmp = 0;
603 spin_unlock_irqrestore(ap->lock, flags);
604 }
605
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-05-10 6:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202605100824.ICLrBkCZ-lkp@intel.com \
--to=lkp@intel.com \
--cc=cassel@kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox