From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB0492E7377 for ; Thu, 28 May 2026 20:22:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779999730; cv=none; b=izsdC1OHBqLTkXLJXb+3rGLZBXyauk7qlPpbqvSPf9Rb7Uf7S9FA6E/p+K7/R5EGzi8f+F/P1WkBOacqYngok7hgV6tPikjP8aAbuqP/xz6xMjDrQ8NpsN6rNi9dgfBScIftA3QXyYoz4Apoj25IiydzkDpLuKzkj7mwAymdMFk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779999730; c=relaxed/simple; bh=8r3Njt8panVzaDyqKXn/pvgpQoA+kH4AbvtZB3YhhYU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SQqZEPuGodHeq8POdsCAq+eEFqk+YCwHFnl35gGJ5VN4gRho7ONqmuU4yh/1xY2T1iLWki/GUMTuIUty9QC2wlfKaijsRcJPs2tOEU30oMO1aL4XRnpSFj0GM9mFhhLr6b9IABjHafXWTAXQhCC11ei9KcEId+Q2zdFEoilWYfM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FibbRqCE; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FibbRqCE" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-36bba9a1089so67174a91.3 for ; Thu, 28 May 2026 13:22:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779999729; x=1780604529; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BvVT0II3dEilSbYrBZE5Ytb4041NB7ZsFn14SAB4u14=; b=FibbRqCExntnWTqwuOAUyv2Mt20zYSo1IkPpGX9bH6XlhFBZ/5IDkFwljM4LrQqPRF EBBrtcTyB5QM5uXrUY7RwK7qlkS/Dzwv4WC4d2DVU9/IJOXogLx9X5INp4TtgFgI1xcD 5quAAr0vI89IdgQSkiOWqkGtn84s/G8Iu2lGXY0rpUzqxUbHqZO0V+tc7BQQT7AY9eBz pTMkPP4a2SR9Hx3hzO80LDzP1/FB76F6k4LHSmI3HNNn5ajD5AqoMI7dbmISzv5lO2gQ H4Wofz3d7BvQ0WUgmHm2IlMoh2gmZ2Zy+BukWfTTiA9GIVjzXFHSMXxzgZiSVGrub66S K60A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779999729; x=1780604529; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BvVT0II3dEilSbYrBZE5Ytb4041NB7ZsFn14SAB4u14=; b=IK71q7M6wQ8KBLbd2x5kB1HHhxRpQ7zavKH9GXLPWM7OhvYGCbMcyVH6bMORTM2iFW 43+HqiddAQBJbJ2WyjVkq7a1ogChTLCdn1i/GIcfuvaDmKa6x695SSyY1YtLHRN0krg2 JVUFXs7EWlxd1fGTweD4VIaifDrs/n8BjabI1Hwr/9cMxJRqikUuxDZBRqpga7EbeQkV AFRbZtHiNJaE+bMhX9aI+R5rIjiYTkt6Kbtwn44f+eyMa8NvWgdPuc93GG8LvDSnvu3j hKBNkh2UvZnY7NXP+ob0SupntYJxxMV1KjNan1js8URkW3077TVnQkGMRR6rq2hKexxT 6QrQ== X-Forwarded-Encrypted: i=1; AFNElJ8MIe+D9q9Nx7pCzbn3XZeTJP0OM2zPwg8tWCyi4WNbah3Z2uXWGVEb1dGo4c71kqbNa9ta@lists.linux.dev X-Gm-Message-State: AOJu0Yxki7R5eH8q3UXsBNL8s2ngHp8zmobXnazRRBqv9A5g2iMrh/9A CMORsMaCfyS4W3jPWzTUW1U8Ipqq7LivzKY6zT5O/gC3XcO2i6TLKcrs X-Gm-Gg: Acq92OGfuCteRmwPZL83RK5Ot8vJm5TB5CoOI2iwu+RYhJCooW3vo1/Z3B1sKRkNxw5 vme6unnqD0uhu5GVMEK9r6R6WvQvtvsq2lxc1fVbDfajhOZFh6GC1XkA/jLYsyOKpxANLRSTDWn eo1DiR+NS9ux6mVKTij2WoEKo2yKcx5RzzZJXBA6cSpq7Sv4JjUFZiMVGJ8qHGiMVSqHtL6ivf6 IwMPG1s3V2lfeTRbGS+VUTLlmqshElw0AGxPpoMysOfjErAtKZZeI1lIBbdb8Z1XAmCeN5OLcgY 5QxHKzkaeHr1H7O4Xps2c0nmdDdWXoore53XxIYK7SpoPOfx7qP13wJ0C17mST1CpFfirIIn5TQ f5njOtIAvI6H4y0/TCJVHeh8xVVi7jPaELjGcjM3iNkfs+B+WSFn6Yjjwi+Mz1x40ZrpuJm/8xV 6DSnXSBBQ9sS3lDIVYWG03tcmMrIhsIqw9NnJASJDl5Gz3PCmfJOANzfg7CBOXB5heOfh5j8MgQ hEciJQMjNCVa8OQlYZuZ6ohQqyituU30+trqwuWUN22/Q== X-Received: by 2002:a17:90a:dfcf:b0:35d:a3b4:2f0d with SMTP id 98e67ed59e1d1-36bbcc146f3mr122373a91.6.1779999729076; Thu, 28 May 2026 13:22:09 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36b908da770sm2334406a91.2.2026.05.28.13.22.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 13:22:08 -0700 (PDT) From: Rosen Penev To: linux-block@vger.kernel.org Cc: Ilya Dryomov , Dongsheng Yang , Jens Axboe , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , ceph-devel@vger.kernel.org (open list:RADOS BLOCK DEVICE (RBD)), linux-kernel@vger.kernel.org (open list), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCH] rbd: cast snap_count to size_t to avoid tautological comparison warning Date: Thu, 28 May 2026 13:21:51 -0700 Message-ID: <20260528202151.136274-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit snap_count is u32 but the comparison is against a SIZE_MAX-derived value (~2^61 on 64-bit), which clang flags as always false with -Wtautological-constant-out-of-range-compare. Cast to size_t so the comparison is done in the correct width. Assisted-by: Opencode:Big-pickle Signed-off-by: Rosen Penev --- drivers/block/rbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index 94709466ad19..b4ba51db9a28 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -6079,7 +6079,7 @@ static int rbd_dev_v2_snap_context(struct rbd_device *rbd_dev, * make sure the computed size of the snapshot context we * allocate is representable in a size_t. */ - if (snap_count > (SIZE_MAX - sizeof (struct ceph_snap_context)) + if ((size_t)snap_count > (SIZE_MAX - sizeof (struct ceph_snap_context)) / sizeof (u64)) { ret = -EINVAL; goto out; -- 2.54.0