Re: [brauner-github:vfs-7.2.misc 28/28] fs/smb/client/file.c:3237:23: warning: converting the result of '<<' to a boolean always evaluates to true

[Nathan Chancellor <nathan@kernel.org>]

On Mon, Jun 08, 2026 at 08:49:58AM +0800, kernel test robot wrote:
> Hi Jori,
> 
> FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
> 
> tree:   https://github.com/brauner/linux.git vfs-7.2.misc
> head:   0da79c259ad0554b36761a7135d4f92eb7c46263
> commit: 0da79c259ad0554b36761a7135d4f92eb7c46263 [28/28] vfs: uapi: retire octal and hex numbers in favor of (1 << n) for O_ flags
> config: s390-randconfig-002 (https://download.01.org/0day-ci/archive/20260608/202606080831.mf22xxxh-lkp@intel.com/config)
> compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260608/202606080831.mf22xxxh-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202606080831.mf22xxxh-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
> >> fs/smb/client/file.c:3237:23: warning: converting the result of '<<' to a boolean always evaluates to true [-Wtautological-constant-compare]
>     3237 |                         break_lease(inode, O_WRONLY);
>          |                                            ^
>    include/uapi/asm-generic/fcntl.h:20:21: note: expanded from macro 'O_WRONLY'
>       20 | #define O_WRONLY        (1 << 0)
>          |                            ^
>    1 warning generated.

This should be resolved when

  https://lore.kernel.org/20260607-breakleasefix-v1-1-658dce536d15@kernel.org/

is applied.

-- 
Cheers,
Nathan