From: kernel test robot <lkp@intel.com>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>,
Michael Hennerich <michael.hennerich@analog.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
pengpeng@iscas.ac.cn
Subject: Re: [PATCH] misc: ad525x_dpot: fix sysfs cleanup paths
Date: Mon, 15 Jun 2026 23:37:09 +0800 [thread overview]
Message-ID: <202606152348.ZvNcZYgS-lkp@intel.com> (raw)
In-Reply-To: <20260615065140.77960-1-pengpeng@iscas.ac.cn>
Hi Pengpeng,
kernel test robot noticed the following build warnings:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on char-misc/char-misc-next char-misc/char-misc-linus soc/for-next linus/master v7.1 next-20260612]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Pengpeng-Hou/misc-ad525x_dpot-fix-sysfs-cleanup-paths/20260615-153833
base: char-misc/char-misc-testing
patch link: https://lore.kernel.org/r/20260615065140.77960-1-pengpeng%40iscas.ac.cn
patch subject: [PATCH] misc: ad525x_dpot: fix sysfs cleanup paths
config: s390-randconfig-002-20260615 (https://download.01.org/0day-ci/archive/20260615/202606152348.ZvNcZYgS-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project e19d1f51a2c80b63cd8ca95bcc757b7077112808)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260615/202606152348.ZvNcZYgS-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202606152348.ZvNcZYgS-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/misc/ad525x_dpot.c:735:1: warning: unused label 'exit_free' [-Wunused-label]
735 | exit_free:
| ^~~~~~~~~~
1 warning generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for MFD_STMFX
Depends on [n]: HAS_IOMEM [=y] && I2C [=m] && OF [=n]
Selected by [m]:
- PINCTRL_STMFX [=m] && PINCTRL [=y] && I2C [=m] && HAS_IOMEM [=y]
vim +/exit_free +735 drivers/misc/ad525x_dpot.c
4eb174bee6f862 Michael Hennerich 2009-12-14 685
6c536e4ce8edd6 Michael Hennerich 2010-05-24 686 struct dpot_data *data;
6c536e4ce8edd6 Michael Hennerich 2010-05-24 687 int i, err = 0;
4eb174bee6f862 Michael Hennerich 2009-12-14 688
bf4afc53b77aea Linus Torvalds 2026-02-21 689 data = kzalloc_obj(struct dpot_data);
4eb174bee6f862 Michael Hennerich 2009-12-14 690 if (!data) {
4eb174bee6f862 Michael Hennerich 2009-12-14 691 err = -ENOMEM;
4eb174bee6f862 Michael Hennerich 2009-12-14 692 goto exit;
4eb174bee6f862 Michael Hennerich 2009-12-14 693 }
4eb174bee6f862 Michael Hennerich 2009-12-14 694
6c536e4ce8edd6 Michael Hennerich 2010-05-24 695 dev_set_drvdata(dev, data);
4eb174bee6f862 Michael Hennerich 2009-12-14 696 mutex_init(&data->update_lock);
4eb174bee6f862 Michael Hennerich 2009-12-14 697
6c536e4ce8edd6 Michael Hennerich 2010-05-24 698 data->bdata = *bdata;
7f3379de9cd91e Michael Hennerich 2011-11-18 699 data->devid = devid;
6c536e4ce8edd6 Michael Hennerich 2010-05-24 700
7f3379de9cd91e Michael Hennerich 2011-11-18 701 data->max_pos = 1 << DPOT_MAX_POS(devid);
6c536e4ce8edd6 Michael Hennerich 2010-05-24 702 data->rdac_mask = data->max_pos - 1;
7f3379de9cd91e Michael Hennerich 2011-11-18 703 data->feat = DPOT_FEAT(devid);
7f3379de9cd91e Michael Hennerich 2011-11-18 704 data->uid = DPOT_UID(devid);
7f3379de9cd91e Michael Hennerich 2011-11-18 705 data->wipers = DPOT_WIPERS(devid);
6c536e4ce8edd6 Michael Hennerich 2010-05-24 706
59592d0ccc0000 Michael Hennerich 2010-05-24 707 for (i = DPOT_RDAC0; i < MAX_RDACS; i++)
6c536e4ce8edd6 Michael Hennerich 2010-05-24 708 if (data->wipers & (1 << i)) {
6c536e4ce8edd6 Michael Hennerich 2010-05-24 709 err = ad_dpot_add_files(dev, data->feat, i);
6c536e4ce8edd6 Michael Hennerich 2010-05-24 710 if (err)
6c536e4ce8edd6 Michael Hennerich 2010-05-24 711 goto exit_remove_files;
6c536e4ce8edd6 Michael Hennerich 2010-05-24 712 /* power-up midscale */
6c536e4ce8edd6 Michael Hennerich 2010-05-24 713 if (data->feat & F_RDACS_WONLY)
6c536e4ce8edd6 Michael Hennerich 2010-05-24 714 data->rdac_cache[i] = data->max_pos / 2;
4eb174bee6f862 Michael Hennerich 2009-12-14 715 }
4eb174bee6f862 Michael Hennerich 2009-12-14 716
6c536e4ce8edd6 Michael Hennerich 2010-05-24 717 if (data->feat & F_CMD_INC)
6c536e4ce8edd6 Michael Hennerich 2010-05-24 718 err = sysfs_create_group(&dev->kobj, &ad525x_group_commands);
6c536e4ce8edd6 Michael Hennerich 2010-05-24 719
4eb174bee6f862 Michael Hennerich 2009-12-14 720 if (err) {
4eb174bee6f862 Michael Hennerich 2009-12-14 721 dev_err(dev, "failed to register sysfs hooks\n");
45f33069c7f509 Pengpeng Hou 2026-06-15 722 goto exit_remove_files;
4eb174bee6f862 Michael Hennerich 2009-12-14 723 }
4eb174bee6f862 Michael Hennerich 2009-12-14 724
4eb174bee6f862 Michael Hennerich 2009-12-14 725 dev_info(dev, "%s %d-Position Digital Potentiometer registered\n",
7f3379de9cd91e Michael Hennerich 2011-11-18 726 name, data->max_pos);
4eb174bee6f862 Michael Hennerich 2009-12-14 727
4eb174bee6f862 Michael Hennerich 2009-12-14 728 return 0;
4eb174bee6f862 Michael Hennerich 2009-12-14 729
6c536e4ce8edd6 Michael Hennerich 2010-05-24 730 exit_remove_files:
59592d0ccc0000 Michael Hennerich 2010-05-24 731 for (i = DPOT_RDAC0; i < MAX_RDACS; i++)
6c536e4ce8edd6 Michael Hennerich 2010-05-24 732 if (data->wipers & (1 << i))
6c536e4ce8edd6 Michael Hennerich 2010-05-24 733 ad_dpot_remove_files(dev, data->feat, i);
6c536e4ce8edd6 Michael Hennerich 2010-05-24 734
4eb174bee6f862 Michael Hennerich 2009-12-14 @735 exit_free:
4eb174bee6f862 Michael Hennerich 2009-12-14 736 kfree(data);
6c536e4ce8edd6 Michael Hennerich 2010-05-24 737 dev_set_drvdata(dev, NULL);
4eb174bee6f862 Michael Hennerich 2009-12-14 738 exit:
6c536e4ce8edd6 Michael Hennerich 2010-05-24 739 dev_err(dev, "failed to create client for %s ID 0x%lX\n",
7f3379de9cd91e Michael Hennerich 2011-11-18 740 name, devid);
4eb174bee6f862 Michael Hennerich 2009-12-14 741 return err;
4eb174bee6f862 Michael Hennerich 2009-12-14 742 }
6c536e4ce8edd6 Michael Hennerich 2010-05-24 743 EXPORT_SYMBOL(ad_dpot_probe);
4eb174bee6f862 Michael Hennerich 2009-12-14 744
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
parent reply other threads:[~2026-06-15 15:37 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20260615065140.77960-1-pengpeng@iscas.ac.cn>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202606152348.ZvNcZYgS-lkp@intel.com \
--to=lkp@intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=michael.hennerich@analog.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pengpeng@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox