From: kernel test robot <lkp@intel.com>
To: Farhan Ali <alifm@linux.ibm.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC PATCH v1] PCI: Remove pcie_flr() and convert all callers to use pcie_reset_flr()
Date: Tue, 16 Jun 2026 19:21:10 +0800 [thread overview]
Message-ID: <202606161907.f6NOdUr4-lkp@intel.com> (raw)
In-Reply-To: <20260615192200.3489-1-alifm@linux.ibm.com>
Hi Farhan,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:
[auto build test ERROR on tnguy-next-queue/dev-queue]
[also build test ERROR on tnguy-net-queue/dev-queue linus/master v7.1 next-20260615]
[cannot apply to pci/next pci/for-linus]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Farhan-Ali/PCI-Remove-pcie_flr-and-convert-all-callers-to-use-pcie_reset_flr/20260616-034658
base: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue
patch link: https://lore.kernel.org/r/20260615192200.3489-1-alifm%40linux.ibm.com
patch subject: [RFC PATCH v1] PCI: Remove pcie_flr() and convert all callers to use pcie_reset_flr()
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20260616/202606161907.f6NOdUr4-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project e19d1f51a2c80b63cd8ca95bcc757b7077112808)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260616/202606161907.f6NOdUr4-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202606161907.f6NOdUr4-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/net/dsa/netc/netc_main.c:890:2: error: call to undeclared function 'pcie_flr'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
890 | pcie_flr(pdev);
| ^
1 error generated.
--
>> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:12281:4: error: call to undeclared function 'pcie_flr'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
12281 | pcie_flr(vfdev);
| ^
1 error generated.
vim +/pcie_flr +890 drivers/net/dsa/netc/netc_main.c
187fbae024c843 Wei Fang 2026-05-18 881
187fbae024c843 Wei Fang 2026-05-18 882 static int netc_switch_pci_init(struct pci_dev *pdev)
187fbae024c843 Wei Fang 2026-05-18 883 {
187fbae024c843 Wei Fang 2026-05-18 884 struct device *dev = &pdev->dev;
187fbae024c843 Wei Fang 2026-05-18 885 struct netc_switch_regs *regs;
187fbae024c843 Wei Fang 2026-05-18 886 struct netc_switch *priv;
187fbae024c843 Wei Fang 2026-05-18 887 void __iomem *base;
187fbae024c843 Wei Fang 2026-05-18 888 int err;
187fbae024c843 Wei Fang 2026-05-18 889
187fbae024c843 Wei Fang 2026-05-18 @890 pcie_flr(pdev);
187fbae024c843 Wei Fang 2026-05-18 891 err = pcim_enable_device(pdev);
187fbae024c843 Wei Fang 2026-05-18 892 if (err)
187fbae024c843 Wei Fang 2026-05-18 893 return dev_err_probe(dev, err, "Failed to enable device\n");
187fbae024c843 Wei Fang 2026-05-18 894
187fbae024c843 Wei Fang 2026-05-18 895 err = pcim_request_all_regions(pdev, KBUILD_MODNAME);
187fbae024c843 Wei Fang 2026-05-18 896 if (err)
187fbae024c843 Wei Fang 2026-05-18 897 return dev_err_probe(dev, err, "Failed to request regions\n");
187fbae024c843 Wei Fang 2026-05-18 898
187fbae024c843 Wei Fang 2026-05-18 899 /* The command BD rings and NTMP tables need DMA. No need to check
187fbae024c843 Wei Fang 2026-05-18 900 * the return value, because it never returns fail when the mask is
187fbae024c843 Wei Fang 2026-05-18 901 * DMA_BIT_MASK(64), see dma-api-howto.rst.
187fbae024c843 Wei Fang 2026-05-18 902 */
187fbae024c843 Wei Fang 2026-05-18 903 dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
187fbae024c843 Wei Fang 2026-05-18 904
187fbae024c843 Wei Fang 2026-05-18 905 if (pci_resource_len(pdev, NETC_REGS_BAR) < NETC_REGS_SIZE) {
187fbae024c843 Wei Fang 2026-05-18 906 return dev_err_probe(dev, -EINVAL,
187fbae024c843 Wei Fang 2026-05-18 907 "Invalid register space size\n");
187fbae024c843 Wei Fang 2026-05-18 908 }
187fbae024c843 Wei Fang 2026-05-18 909
187fbae024c843 Wei Fang 2026-05-18 910 base = pcim_iomap(pdev, NETC_REGS_BAR, 0);
187fbae024c843 Wei Fang 2026-05-18 911 if (!base)
187fbae024c843 Wei Fang 2026-05-18 912 return dev_err_probe(dev, -ENXIO, "pcim_iomap() failed\n");
187fbae024c843 Wei Fang 2026-05-18 913
187fbae024c843 Wei Fang 2026-05-18 914 pci_set_master(pdev);
187fbae024c843 Wei Fang 2026-05-18 915
187fbae024c843 Wei Fang 2026-05-18 916 priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
187fbae024c843 Wei Fang 2026-05-18 917 if (!priv)
187fbae024c843 Wei Fang 2026-05-18 918 return -ENOMEM;
187fbae024c843 Wei Fang 2026-05-18 919
187fbae024c843 Wei Fang 2026-05-18 920 priv->pdev = pdev;
187fbae024c843 Wei Fang 2026-05-18 921 priv->dev = dev;
187fbae024c843 Wei Fang 2026-05-18 922
187fbae024c843 Wei Fang 2026-05-18 923 regs = &priv->regs;
187fbae024c843 Wei Fang 2026-05-18 924 regs->base = base;
187fbae024c843 Wei Fang 2026-05-18 925 regs->port = regs->base + NETC_REGS_PORT_BASE;
187fbae024c843 Wei Fang 2026-05-18 926 regs->global = regs->base + NETC_REGS_GLOBAL_BASE;
187fbae024c843 Wei Fang 2026-05-18 927 pci_set_drvdata(pdev, priv);
187fbae024c843 Wei Fang 2026-05-18 928
187fbae024c843 Wei Fang 2026-05-18 929 return 0;
187fbae024c843 Wei Fang 2026-05-18 930 }
187fbae024c843 Wei Fang 2026-05-18 931
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
parent reply other threads:[~2026-06-16 11:21 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20260615192200.3489-1-alifm@linux.ibm.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202606161907.f6NOdUr4-lkp@intel.com \
--to=lkp@intel.com \
--cc=alifm@linux.ibm.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox