From: Kees Cook <kees@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Sami Tolvanen <samitolvanen@google.com>,
Nathan Chancellor <nathan@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <david@davidgow.net>, Rae Moar <raemoar63@gmail.com>,
llvm@lists.linux.dev, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] kunit: cfi: Add test for kCFI indirect-call type checks
Date: Fri, 19 Jun 2026 13:44:43 -0700 [thread overview]
Message-ID: <202606191342.E2B47A5@keescook> (raw)
In-Reply-To: <20260619095129.GE49529@noisy.programming.kicks-ass.net>
On Fri, Jun 19, 2026 at 11:51:29AM +0200, Peter Zijlstra wrote:
> > This is really rather horrible. Also, now all an attacker needs to do is
> > ensure cfi_kunit_handled() unconditionally returns true. IOW, no distro
> > must ever have this KUNIT crap enabled.
>
> Also, if this lives, the check should at least trip the cfi_warn path,
> being completely silent is terrible.
If anyone actually ships kunit in production, then no, I will NAK my own
patch. ;) In that case I will go back to a version I never sent, which
uses Kunit's try/catch Oops checker (which doesn't work on riscv). I
only did it this way (similar to the fortify kunit testing) so I could
get riscv coverage.
--
Kees Cook
next prev parent reply other threads:[~2026-06-19 20:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 21:09 [PATCH v2] kunit: cfi: Add test for kCFI indirect-call type checks Kees Cook
2026-06-19 9:37 ` Peter Zijlstra
2026-06-19 9:51 ` Peter Zijlstra
2026-06-19 20:44 ` Kees Cook [this message]
2026-06-19 20:54 ` Kees Cook
2026-06-19 20:42 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202606191342.E2B47A5@keescook \
--to=kees@kernel.org \
--cc=arnd@arndb.de \
--cc=brendan.higgins@linux.dev \
--cc=david@davidgow.net \
--cc=kunit-dev@googlegroups.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=peterz@infradead.org \
--cc=raemoar63@gmail.com \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox