Building the Linux kernel with Clang and LLVM
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Sudeep Holla <sudeep.holla@kernel.org>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: [sudeep-holla:b4/acpi_scmi_pcc 9/23] drivers/firmware/arm_scmi/transports/mailbox.c:252:1: warning: unused label 'err_free_chan_receiver'
Date: Thu, 02 Jul 2026 06:56:08 +0800	[thread overview]
Message-ID: <202607020643.aeL4FIjK-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git b4/acpi_scmi_pcc
head:   bdcaa5728f17002c1091efd93dd082c9c23ddd39
commit: 1bfaf4c65e542a88331bfd51d59d27b827a2282d [9/23] firmware: arm_scmi: Unwind P2A receiver mailbox setup failure
config: i386-buildonly-randconfig-005-20260702 (https://download.01.org/0day-ci/archive/20260702/202607020643.aeL4FIjK-lkp@intel.com/config)
compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260702/202607020643.aeL4FIjK-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202607020643.aeL4FIjK-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/firmware/arm_scmi/transports/mailbox.c:252:1: warning: unused label 'err_free_chan_receiver' [-Wunused-label]
     252 | err_free_chan_receiver:
         | ^~~~~~~~~~~~~~~~~~~~~~~
   1 warning generated.


vim +/err_free_chan_receiver +252 drivers/firmware/arm_scmi/transports/mailbox.c

   181	
   182	static int mailbox_chan_setup(struct scmi_chan_info *cinfo, struct device *dev,
   183				      bool tx)
   184	{
   185		const char *desc = tx ? "Tx" : "Rx";
   186		struct device *cdev = cinfo->dev;
   187		struct scmi_mailbox *smbox;
   188		int ret, a2p_rx_chan, p2a_chan, p2a_rx_chan;
   189		struct mbox_client *cl;
   190	
   191		ret = mailbox_chan_validate(cdev, &a2p_rx_chan, &p2a_chan, &p2a_rx_chan);
   192		if (ret)
   193			return ret;
   194	
   195		if (!tx && !p2a_chan)
   196			return -ENODEV;
   197	
   198		smbox = devm_kzalloc(dev, sizeof(*smbox), GFP_KERNEL);
   199		if (!smbox)
   200			return -ENOMEM;
   201	
   202		smbox->shmem = core->shmem->setup_iomap(cinfo, dev, tx, NULL,
   203							&smbox->io_ops);
   204		if (IS_ERR(smbox->shmem))
   205			return PTR_ERR(smbox->shmem);
   206	
   207		cl = &smbox->cl;
   208		cl->dev = cdev;
   209		cl->tx_prepare = tx ? tx_prepare : NULL;
   210		cl->rx_callback = rx_callback;
   211		cl->tx_block = false;
   212		cl->knows_txdone = tx;
   213	
   214		smbox->chan = mbox_request_channel(cl, tx ? 0 : p2a_chan);
   215		if (IS_ERR(smbox->chan)) {
   216			ret = PTR_ERR(smbox->chan);
   217			if (ret != -EPROBE_DEFER)
   218				dev_err(cdev,
   219					"failed to request SCMI %s mailbox\n", desc);
   220			return ret;
   221		}
   222	
   223		/* Additional unidirectional channel for TX if needed */
   224		if (tx && a2p_rx_chan) {
   225			smbox->chan_receiver = mbox_request_channel(cl, a2p_rx_chan);
   226			if (IS_ERR(smbox->chan_receiver)) {
   227				ret = PTR_ERR(smbox->chan_receiver);
   228				smbox->chan_receiver = NULL;
   229				if (ret != -EPROBE_DEFER)
   230					dev_err(cdev, "failed to request SCMI Tx Receiver mailbox\n");
   231				goto err_free_chan;
   232			}
   233		}
   234	
   235		if (!tx && p2a_rx_chan) {
   236			smbox->chan_platform_receiver = mbox_request_channel(cl, p2a_rx_chan);
   237			if (IS_ERR(smbox->chan_platform_receiver)) {
   238				ret = PTR_ERR(smbox->chan_platform_receiver);
   239				smbox->chan_platform_receiver = NULL;
   240				if (ret != -EPROBE_DEFER)
   241					dev_err(cdev, "failed to request SCMI P2A Receiver mailbox\n");
   242				goto err_free_chan;
   243			}
   244		}
   245	
   246		cinfo->transport_info = smbox;
   247		smbox->cinfo = cinfo;
   248		mutex_init(&smbox->chan_lock);
   249	
   250		return 0;
   251	
 > 252	err_free_chan_receiver:
   253		mbox_free_channel(smbox->chan_receiver);
   254	err_free_chan:
   255		mbox_free_channel(smbox->chan);
   256		return ret;
   257	}
   258	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-07-01 22:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202607020643.aeL4FIjK-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=sudeep.holla@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox