Building the Linux kernel with Clang and LLVM
 help / color / mirror / Atom feed
From: George Guo <dongtai.guo@linux.dev>
To: chenhuacai@kernel.org
Cc: jpoimboe@kernel.org, joe.lawrence@redhat.com, wangyuli@aosc.io,
	peterz@infradead.org, jikos@kernel.org, mbenes@suse.cz,
	pmladek@suse.com, kernel@xen0n.name, rostedt@goodmis.org,
	ardb@kernel.org, nathan@kernel.org,
	nick.desaulniers+lkml@gmail.com, yangtiezhu@loongson.cn,
	jiaxun.yang@flygoat.com, liukexin@kylinos.cn,
	guodongtai@kylinos.cn, xry111@xry111.site,
	linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
	llvm@lists.linux.dev, loongarch@lists.linux.dev
Subject: Re: [PATCH v3 00/12] LoongArch: Add livepatch build (KLP) support
Date: Thu,  9 Jul 2026 21:21:03 +0800	[thread overview]
Message-ID: <20260709132103.16433-1-dongtai.guo@linux.dev> (raw)
In-Reply-To: <CAAhV-H4cr9xBkM-SEUHXm9t0yQ=r3B9pkNdmUDftP00hvVsZrQ@mail.gmail.com>

Hi Huacai,

Thank you for raising this -- I take the concern seriously, and I'd like
to lay out the full history so everyone is working from the same facts.

> 2. ... Wang Yuli had already alerted you in your v1. At that point, you
> had two options: a) abandon your own patches ... or b) thank Wang Yuli
> for the reminder and assistance, then seek to collaborate on
> development. However, you did neither

I did take option (b). Wang Yuli's v1 messages were code review, and I
thanked him on-list and folded every point into v2:

  https://lore.kernel.org/all/20260608103302.340456-1-dongtai.guo@linux.dev/

  "Thanks for the review -- all three points are addressed in v2. ...
   You were right that this had not been properly exercised before ..."

His "awM is dangerous, see how x86 did" comment in particular led
directly to the ANNOTATE_DATA_SPECIAL rework that is in the series now.
The review made these patches better and I'm grateful for it.

> 1. Wang Yuli released his version first; re-releasing it without any
> prior communication is simply rude.

On priority: this series is not a fork of Wang Yuli's. I have been
carrying LoongArch livepatch tooling since kpatch, which is klp-build's
predecessor (same maintainer, later folded into the kernel). My kpatch
LoongArch support was posted on 2024-12-05 and merged 2026-01-12:

  https://github.com/dynup/kpatch/pull/1427

developed over several review rounds with Joe Lawrence. When Josh
announced the kpatch -> klp-build transition, he listed the LoongArch
port as coming from me:

  https://github.com/dynup/kpatch/issues/1498
  ("loongarch ... shared by @georgejguo below, coming soon")

So this klp-build series is the continuation of my own earlier work,
not a takeover of someone else's.

On scope: Wang Yuli's own suggestion in v1 was to use his patch to
replace "these two patches" -- i.e. the basic arch-enablement piece.
This series is the objtool/klp-diff and build-tooling integration
(12 patches), including four fixes Joe found by running the full
klp-build flow end to end. The overlap is just the arch-enablement part.

> does that mean Wang Yuli can now throw yours in the trash when he
> releases his v2?

I don't see this as anyone's to throw away -- it's shared work toward
the same goal, and I'd much rather converge than duplicate. Concretely:
I'm happy to fold the overlapping arch-enablement patch in with Wang
Yuli as author (or Co-developed-by), and to work with him on the rest.

Wang Yuli, if you're up for it, let's coordinate -- I can take the
objtool/klp-diff pieces and we land one clean series together.

Thanks,
George

  parent reply	other threads:[~2026-07-09 13:21 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-07  7:20 [PATCH v3 00/12] LoongArch: Add livepatch build (KLP) support George Guo
2026-07-07  7:20 ` [PATCH v3 01/12] objtool/LoongArch: Add arch_adjusted_addend() for KLP support George Guo
2026-07-07  7:20 ` [PATCH v3 02/12] LoongArch: Mark special sections " George Guo
2026-07-08 22:32   ` Joe Lawrence
2026-07-07  7:20 ` [PATCH v3 03/12] livepatch/klp-build: disable direct-extern-access for LoongArch to fix kernel panic George Guo
2026-07-07  7:20 ` [PATCH v3 04/12] livepatch/klp-build: build LoongArch with -fPIC to keep GOT-indirect symbol references George Guo
2026-07-08 15:05   ` Joe Lawrence
2026-07-10  7:38     ` George Guo
2026-07-07  7:20 ` [PATCH v3 05/12] LoongArch: Fix EFI linking with -fdata-sections George Guo
2026-07-08 13:54   ` Joe Lawrence
2026-07-08 16:07     ` Joe Lawrence
2026-07-10  7:46       ` George Guo
2026-07-07  7:20 ` [PATCH v3 06/12] objtool/klp: Add LoongArch jump opcode bytes support George Guo
2026-07-07  7:20 ` [PATCH v3 07/12] klp-build: Add LoongArch syscall patching macro George Guo
2026-07-08 19:18   ` Joe Lawrence
2026-07-10  7:49     ` George Guo
2026-07-07  7:20 ` [PATCH v3 08/12] LoongArch: Add livepatch build (KLP) support George Guo
2026-07-07  7:20 ` [PATCH v3 09/12] LoongArch: Select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY George Guo
2026-07-07  7:20 ` [PATCH v3 10/12] objtool/klp: Convert local label references in special sections George Guo
2026-07-07  7:20 ` [PATCH v3 11/12] objtool/klp: Fix ANNOTATE_DATA_SPECIAL parsing for local label references George Guo
2026-07-07  7:20 ` [PATCH v3 12/12] objtool/klp: Fold LoongArch paired ADD/SUB relocations into PCREL George Guo
2026-07-08 13:29   ` Xi Ruoyao
2026-07-09  9:43 ` [PATCH v3 00/12] LoongArch: Add livepatch build (KLP) support Huacai Chen
2026-07-09 10:35   ` WangYuli
2026-07-09 13:21   ` George Guo [this message]
2026-07-10 14:34     ` Huacai Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260709132103.16433-1-dongtai.guo@linux.dev \
    --to=dongtai.guo@linux.dev \
    --cc=ardb@kernel.org \
    --cc=chenhuacai@kernel.org \
    --cc=guodongtai@kylinos.cn \
    --cc=jiaxun.yang@flygoat.com \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jpoimboe@kernel.org \
    --cc=kernel@xen0n.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liukexin@kylinos.cn \
    --cc=live-patching@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=loongarch@lists.linux.dev \
    --cc=mbenes@suse.cz \
    --cc=nathan@kernel.org \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=wangyuli@aosc.io \
    --cc=xry111@xry111.site \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox