From: kernel test robot <lkp@intel.com>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>, Elad Nachman <enachman@marvell.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Pengpeng Hou <pengpeng@iscas.ac.cn>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: prestera: avoid overreading a short firmware tail
Date: Wed, 2 Sep 2026 21:06:09 +0800 [thread overview]
Message-ID: <202609022030.0pnwZKgS-lkp@intel.com> (raw)
In-Reply-To: <20260830142404.37663-1-pengpeng@iscas.ac.cn>
Hi Pengpeng,
kernel test robot noticed the following build errors:
[auto build test ERROR on 08dbfad3f5040f5bdb6c529da20d6d4e81fefd72]
url: https://github.com/intel-lab-lkp/linux/commits/Pengpeng-Hou/net-prestera-avoid-overreading-a-short-firmware-tail/20260830-222403
base: 08dbfad3f5040f5bdb6c529da20d6d4e81fefd72
patch link: https://lore.kernel.org/r/20260830142404.37663-1-pengpeng%40iscas.ac.cn
patch subject: [PATCH] net: prestera: avoid overreading a short firmware tail
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20260902/202609022030.0pnwZKgS-lkp@intel.com/config)
compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260902/202609022030.0pnwZKgS-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202609022030.0pnwZKgS-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/net/ethernet/marvell/prestera/prestera_pci.c:603:18: error: call to undeclared function 'get_unaligned'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
603 | writel_relaxed(get_unaligned((u32 *)(buf + i)),
| ^
1 error generated.
vim +/get_unaligned +603 drivers/net/ethernet/marvell/prestera/prestera_pci.c
589
590 static int prestera_ldr_send(struct prestera_fw *fw, const u8 *buf, size_t len)
591 {
592 size_t write_len = ALIGN(len, sizeof(u32));
593 size_t i;
594 int err;
595
596 err = prestera_ldr_wait_buf(fw, write_len);
597 if (err) {
598 dev_err(fw->dev.dev, "failed wait for sending firmware\n");
599 return err;
600 }
601
602 for (i = 0; i + sizeof(u32) <= len; i += sizeof(u32)) {
> 603 writel_relaxed(get_unaligned((u32 *)(buf + i)),
604 prestera_ldr_wr_ptr(fw));
605 prestera_ldr_wr_idx_move(fw, 4);
606 }
607 if (i < len) {
608 u32 last = 0;
609
610 memcpy(&last, buf + i, len - i);
611 writel_relaxed(last, prestera_ldr_wr_ptr(fw));
612 prestera_ldr_wr_idx_move(fw, 4);
613 }
614
615 prestera_ldr_wr_idx_commit(fw);
616 return 0;
617 }
618
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
parent reply other threads:[~2026-09-02 13:06 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20260830142404.37663-1-pengpeng@iscas.ac.cn>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202609022030.0pnwZKgS-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enachman@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=pengpeng@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox