From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4D4C49A3B0 for ; Wed, 16 Sep 2026 23:52:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789602753; cv=none; b=YJQDzeJCAwCn1lIHLN5VD/HgewZk3mWsru/B/S9b+AFtFS0H056ODoegX6zGZag8MYhlqaY23Tqx2KNy2/kbwvD/vt9P49vh7ozxB08a82pkbsQDvS3zcST3+GNyJxKsTkQfqnYiu9x44eIhMTxYF2gEI9YrNXkkzUVPpmRMAm0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789602753; c=relaxed/simple; bh=Eld+48KwBOqxZdKsMqjpsyjgMj7h7+b8QQ73uLHVD44=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IP2YFZNXdL2UY6tmsfyAjkKOi/lOINn8aKlOe9itMCtwTjw8QwdxNYQuOvepVpD691YjPWAU0cS2Dhn4V9qUdQmynJHX8xxvxGpvt2bp1qskSwfD3ifd47cTuIiu9IQ1OfRDiHmzpyK8GKEFrmMsz1CTfzVKgwiXTyoF/cOYmNY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m+cJ8xTt; arc=none smtp.client-ip=74.125.225.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m+cJ8xTt" Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-482f6350f88so165948f8f.2 for ; Wed, 16 Sep 2026 16:52:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789602746; x=1790207546; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=80NdB9WJ/pxAS1T/4nTuPkYDib5izDAGWGqnSmJExY0=; b=m+cJ8xTtB0R0TfpZKwbRc8Ms2JzJgdMjkedFYMEklytse32+qDhOAQPrF9SMoLSABa 76HDyF/TiEhXslPofxAwRTqbaKVTqlefeEPASQMrKCP56s9DLByV81vWs4M+KPGqsbpk tFaY9MrneQObSXyt9jB4gZu5xwXq/w5h5/pYtVROeioo4v4VlCpPPuxZB2/B7DC6qh+B 7IBuwkayQWH3g5SA1csA2lgqV7limcyJ6FfrzTrej0c8juJA2dwIAfQK/PkqDlvyqYKt mL5lk5fhG53JdkTIQemfuMRr8veeY05a+QsRfVZE3ZtfDbTg4O76VEFCeRbEUltnWR1x yKKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789602746; x=1790207546; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=80NdB9WJ/pxAS1T/4nTuPkYDib5izDAGWGqnSmJExY0=; b=zCQ+7MvVugwvgKRmnSQHTc7ZZtajQQs8/A2mqqAyT6O1q1cYWr01wqY7hQa8vzUbxz nWde3ufMHZ3tNYgE7SDA/tBQ74tJvbSeGLrGh2iY9u6J1TXbeKZ70+l7FkmPBG+u3z1N pJK78YFYYLqhL2rwYhecySAHx3LBA75CI5cSvsgbffN5m8iWU5+QQLY2HbYb5ITdL3oB JGvIkI5qLaqA1A5Uo8B7ywbDlfRWFmvSy1DWoBQ6b2/fmecnO9sXE9Z1AXdxUY+EAoHs leP+uol09Q6oIJ7svjc5TK/QBbqQSWBP/t2OAhnNkKFqieZyVZm9+15ntc7mFg9b7FBq Ipwg== X-Forwarded-Encrypted: i=1; AKwUvBxsGoXQ0kJFZq+Ujb1rQ6ds/Lj5FmRsxo5sW/5kqr9d8Hhmkyg0rpyUf2f5Sb22eJXADgdW@lists.linux.dev X-Gm-Message-State: AFuF++kOHc8cqANB1a/+Qk4oyN82zPwTNqAolJ6ioSEWG/l1ERONUq6A wXTqJuphbSrIsyYgyv859ehBKKxt6vO8h2kJpMGsuzsNmAAl/AEWZ+gc X-Gm-Gg: AYBFou1JP26Opd7BKICrjpBypfox8tfR9OIhpHKezVbyUMvSbCDMCsGfCtO48wq/kbg xlMKS4EP/xVQ3QmomWaxnoLxdnZwxDQ6lngpNqxA5R4nJmMEj8Uounh0+9pEUkiUQDGu9crmM9m kfLNPEVZaX0947azNKqz189hSJ2olS2rQhEVMAI+PvtA+L4jY6yO6o1FQZ9di0Bla7p9/3oKB4L 6wWI5rBTjFjKOw+V7uyAwLF4lrrSubsmcpzNdl0gGYEbu8wteOMmmSxqhamP/a1Wyflh5rwR5hJ deAhjfEsjF4g1DV3OwB4CFHagj6abLMBXDRpnebEBOwA8PBUEEyz2EKheVjBDaOdQySqQD84LmN jEs6IZ75sgDTCfM0nCU6G4J5dDbbBhx/HcOn7/E7eSytmAmGdUUvMUkaqeXMSzlDAEgVMDSm15T hQ52mvfi+2qo2CrCsd3FHGf0Z6c9vYaVL1619MxkwXLHSP4sVYZ5zOMlKQCXauBhjZ1WixVqMR1 EPAke8qKuP8fJiWm5z9SaHDAchLU1UA4gPO1OeHe91te5cBAEgD4VnNA6XLLjoL X-Received: by 2002:a05:6000:4711:b0:487:fb0:9ff with SMTP id ffacd0b85a97d-4870fb00af5mr4386063f8f.22.1789602745854; Wed, 16 Sep 2026 16:52:25 -0700 (PDT) Received: from Ansuel-XPS24.localdomain (host-79-26-252-140.retail.telecomitalia.it. [79.26.252.140]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-4870bef7687sm11861104f8f.1.2026.09.16.16.52.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 16:52:25 -0700 (PDT) From: Christian Marangi To: Maxime Chevallier , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Jonathan Corbet , Shuah Khan , Randy Dunlap , Christian Marangi , Lorenzo Bianconi , Heiner Kallweit , Russell King , Philipp Zabel , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, llvm@lists.linux.dev Subject: [PATCH net-next v16 05/12] net: phylink: support PCS provider release Date: Thu, 17 Sep 2026 01:51:31 +0200 Message-ID: <20260916235200.20712-6-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260916235200.20712-1-ansuelsmth@gmail.com> References: <20260916235200.20712-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support for release of fwnode PCS from a PCS provider. This works by creating a global notifier for the PCS provider and making each phylink instance that makes use of fwnode subscribe to this notifier. The PCS notifier will emit the event FWNODE_PCS_PROVIDER_DEL every time a new PCS provider is released. phylink will then react to this event and will call the new function fwnode_pcs_matches_provider() on each PCS of the phylink instance and will check if the PCS is provided by the PCS provider that is getting released. If a related PCS is found, then such PCS is removed from the phylink instance PCS list and the supported_interfaces value is updated. The flag force_major_config is set to make phylink resolve reconfigure the interface (even if it didn't change). This is needed to handle the special case when the current PCS used by phylink is removed and a major_config is needed to propagae the configuration change. With this option enabled we also force mac_config even if the PHY link is not up for the in-band case. Finally a phylink resolve is triggered to handle the PCS removal. Protect every access of phylink pcs_list with state_mutex to handle async PCS provider release. Signed-off-by: Christian Marangi --- drivers/net/pcs/pcs.c | 47 +++++++++++++ drivers/net/phy/phylink.c | 141 ++++++++++++++++++++++++++++++++++++-- include/linux/pcs/pcs.h | 69 +++++++++++++++++++ 3 files changed, 250 insertions(+), 7 deletions(-) diff --git a/drivers/net/pcs/pcs.c b/drivers/net/pcs/pcs.c index 39550d9a12a2..25b3248e8b93 100644 --- a/drivers/net/pcs/pcs.c +++ b/drivers/net/pcs/pcs.c @@ -22,6 +22,19 @@ struct fwnode_pcs_provider { static LIST_HEAD(fwnode_pcs_providers); static DEFINE_MUTEX(fwnode_pcs_mutex); +static BLOCKING_NOTIFIER_HEAD(fwnode_pcs_notify_list); + +int register_fwnode_pcs_notifier(struct notifier_block *nb) +{ + return blocking_notifier_chain_register(&fwnode_pcs_notify_list, nb); +} +EXPORT_SYMBOL_GPL(register_fwnode_pcs_notifier); + +int unregister_fwnode_pcs_notifier(struct notifier_block *nb) +{ + return blocking_notifier_chain_unregister(&fwnode_pcs_notify_list, nb); +} +EXPORT_SYMBOL_GPL(unregister_fwnode_pcs_notifier); struct phylink_pcs *fwnode_pcs_simple_xlate(struct fwnode_reference_args *pcsspec, void *data) @@ -74,6 +87,11 @@ void fwnode_pcs_del_provider(struct fwnode_pcs_provider *pp) mutex_unlock(&fwnode_pcs_mutex); + /* Signal phylink to release any PCS from this provider */ + blocking_notifier_call_chain(&fwnode_pcs_notify_list, + FWNODE_PCS_PROVIDER_DEL, + pp); + fwnode_handle_put(pp->fwnode); kfree(pp); } @@ -183,6 +201,35 @@ struct phylink_pcs *fwnode_pcs_get(const struct fwnode_handle *fwnode, unsigned } EXPORT_SYMBOL_GPL(fwnode_pcs_get); +bool fwnode_pcs_matches_provider(struct fwnode_pcs_provider *provider, + const struct fwnode_handle *fwnode, + struct phylink_pcs *pl_pcs) +{ + struct fwnode_reference_args pcsspec; + int index = 0; + int ret; + + while (true) { + struct phylink_pcs *pcs; + + ret = fwnode_parse_pcsspec(fwnode, index, NULL, &pcsspec); + if (ret) + return false; + + pcs = __fwnode_pcs_get_from_pcsspec_provider(&pcsspec, provider); + if (!IS_ERR(pcs) && pcs == pl_pcs) { + fwnode_handle_put(pcsspec.fwnode); + return true; + } + + fwnode_handle_put(pcsspec.fwnode); + index++; + } + + return false; +} +EXPORT_SYMBOL_GPL(fwnode_pcs_matches_provider); + unsigned int fwnode_phylink_pcs_count(struct fwnode_handle *fwnode) { struct fwnode_reference_args out_args; diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 473d15789128..88570a59ba9e 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -63,6 +64,7 @@ struct phylink { /* List of available PCS */ struct list_head pcs_list; + struct notifier_block fwnode_pcs_nb; /* What interface are supported by the current link. * Can change on removal or addition of new PCS. @@ -545,11 +547,15 @@ static int phylink_validate_mac_and_pcs(struct phylink *pl, unsigned long capabilities; int ret; + mutex_lock(&pl->state_mutex); + /* Get the PCS for this interface mode */ if (pl->mac_ops->mac_select_pcs) { pcs = pl->mac_ops->mac_select_pcs(pl->config, state->interface); - if (IS_ERR(pcs)) + if (IS_ERR(pcs)) { + mutex_unlock(&pl->state_mutex); return PTR_ERR(pcs); + } /* * Find a PCS in available PCS list for the requested interface. * @@ -573,6 +579,7 @@ static int phylink_validate_mac_and_pcs(struct phylink *pl, * error and backtrace rather than oopsing the kernel. */ if (!pcs->ops) { + mutex_unlock(&pl->state_mutex); phylink_err(pl, "interface %s: uninitialised PCS\n", phy_modes(state->interface)); dump_stack(); @@ -582,6 +589,7 @@ static int phylink_validate_mac_and_pcs(struct phylink *pl, /* Recheck PCS to handle legacy way for .mac_select_pcs */ ret = phylink_validate_pcs_interface(pcs, state->interface); if (ret) { + mutex_unlock(&pl->state_mutex); phylink_err(pl, "selected PCS does not support %s\n", phy_modes(state->interface)); return -EINVAL; @@ -590,8 +598,10 @@ static int phylink_validate_mac_and_pcs(struct phylink *pl, /* Validate the link parameters with the PCS */ if (pcs->ops->pcs_validate) { ret = pcs->ops->pcs_validate(pcs, supported, state); - if (ret < 0 || phylink_is_empty_linkmode(supported)) + if (ret < 0 || phylink_is_empty_linkmode(supported)) { + mutex_unlock(&pl->state_mutex); return -EINVAL; + } /* Ensure the advertising mask is a subset of the * supported mask. @@ -601,6 +611,8 @@ static int phylink_validate_mac_and_pcs(struct phylink *pl, } } + mutex_unlock(&pl->state_mutex); + /* Then validate the link parameters with the MAC */ if (pl->mac_ops->mac_get_caps) capabilities = pl->mac_ops->mac_get_caps(pl->config, @@ -996,6 +1008,9 @@ static unsigned int phylink_inband_caps(struct phylink *pl, phy_interface_t interface) { struct phylink_pcs *pcs = NULL; + int ret = 0; + + mutex_lock(&pl->state_mutex); if (pl->mac_ops->mac_select_pcs) { pcs = pl->mac_ops->mac_select_pcs(pl->config, @@ -1012,9 +1027,14 @@ static unsigned int phylink_inband_caps(struct phylink *pl, } if (IS_ERR_OR_NULL(pcs)) - return 0; + goto exit; + + ret = phylink_pcs_inband_caps(pcs, interface); + +exit: + mutex_unlock(&pl->state_mutex); - return phylink_pcs_inband_caps(pcs, interface); + return ret; } static void phylink_pcs_poll_stop(struct phylink *pl) @@ -1555,7 +1575,9 @@ static void phylink_mac_initial_config(struct phylink *pl, bool force_restart) phylink_apply_manual_flow(pl, &link_state); if (phy) mutex_lock(&phy->lock); + mutex_lock(&pl->state_mutex); phylink_major_config(pl, force_restart, &link_state); + mutex_unlock(&pl->state_mutex); if (phy) mutex_unlock(&phy->lock); } @@ -1925,6 +1947,9 @@ static int phylink_fill_available_pcs(struct phylink *pl, if (!pcss) return -ENOMEM; + /* Lock state_mutex while filling to handle PCS notify */ + mutex_lock(&pl->state_mutex); + ret = config->fill_available_pcs(config, pcss, config->num_possible_pcs); if (ret < 0) goto out; @@ -1939,11 +1964,89 @@ static int phylink_fill_available_pcs(struct phylink *pl, } out: + mutex_unlock(&pl->state_mutex); + kfree(pcss); return ret; } +static void phylink_del_pcs(struct phylink *pl, struct phylink_pcs *pcs) +{ + lockdep_assert_held(&pl->state_mutex); + + list_del(&pcs->list); + pcs->phylink = NULL; + + /* + * Check if we are removing the PCS currently + * in use by this phylink instance. If this is the case, + * tear down the link, force phylink resolve to reconfigure the + * interface mode, disable the current PCS and set the + * phylink PCS to NULL. + */ + if (pl->pcs == pcs) { + if (pl->old_link_state) { + phylink_link_down(pl); + pl->old_link_state = false; + } + if (pl->cfg_link_an_mode == MLO_AN_INBAND) + timer_delete_sync(&pl->link_poll); + phylink_pcs_disable(pl->pcs); + + pl->force_major_config = true; + WRITE_ONCE(pl->pcs, NULL); + } +} + +static int pcs_provider_notify(struct notifier_block *self, + unsigned long val, void *data) +{ + struct phylink *pl = container_of(self, struct phylink, fwnode_pcs_nb); + struct fwnode_pcs_provider *pp = data; + struct phylink_pcs *pcs, *tmp; + bool resolve = false; + + rtnl_lock(); + + mutex_lock(&pl->state_mutex); + + /* + * Loop all the PCS for phylink instance and check if + * this notification is relevant for some of them. + */ + list_for_each_entry_safe(pcs, tmp, &pl->pcs_list, list) { + if (!fwnode_pcs_matches_provider(pp, pl->fwnode, pcs)) + continue; + + phylink_del_pcs(pl, pcs); + resolve = true; + } + + /* Exit early if nothing has changed */ + if (!resolve) { + mutex_unlock(&pl->state_mutex); + rtnl_unlock(); + return NOTIFY_DONE; + } + + /* Refresh supported interfaces */ + phy_interface_copy(pl->supported_interfaces, + pl->config->supported_interfaces); + list_for_each_entry(pcs, &pl->pcs_list, list) + phy_interface_or(pl->supported_interfaces, + pl->supported_interfaces, + pcs->supported_interfaces); + + mutex_unlock(&pl->state_mutex); + + rtnl_unlock(); + + phylink_run_resolve(pl); + + return NOTIFY_OK; +} + /** * phylink_update_pause_state() - Update the phylink pause frame configuration * @pl: a pointer to a &struct phylink instance @@ -2152,10 +2255,18 @@ struct phylink *phylink_create(struct phylink_config *config, __set_bit(PHYLINK_DISABLE_STOPPED, &pl->phylink_disable_state); timer_setup(&pl->link_poll, phylink_fixed_poll, 0); + /* First register notifier for hotplug PCS events */ + if (!phy_interface_empty(config->pcs_interfaces)) { + pl->fwnode_pcs_nb.notifier_call = pcs_provider_notify; + register_fwnode_pcs_notifier(&pl->fwnode_pcs_nb); + } + /* Fill the PCS list with available PCS from phylink config */ ret = phylink_fill_available_pcs(pl, config); if (ret < 0) - goto free_pl; + goto unregister_pcs_notify; + + mutex_lock(&pl->state_mutex); /* Link available PCS to phylink */ list_for_each_entry(pcs, &pl->pcs_list, list) @@ -2170,13 +2281,15 @@ struct phylink *phylink_create(struct phylink_config *config, pl->supported_interfaces, pcs->supported_interfaces); + mutex_unlock(&pl->state_mutex); + linkmode_fill(pl->supported); linkmode_copy(pl->link_config.advertising, pl->supported); phylink_validate(pl, pl->supported, &pl->link_config); ret = phylink_parse_mode(pl, fwnode); if (ret < 0) - goto unlink_pcs_list; + goto unregister_pcs_notify; if (pl->cfg_link_an_mode == MLO_AN_FIXED) { ret = phylink_parse_fixedlink(pl, fwnode); @@ -2195,11 +2308,17 @@ struct phylink *phylink_create(struct phylink_config *config, release_link_gpio: if (pl->link_gpio) gpiod_put(pl->link_gpio); -unlink_pcs_list: +unregister_pcs_notify: + if (pl->fwnode_pcs_nb.notifier_call) + unregister_fwnode_pcs_notifier(&pl->fwnode_pcs_nb); + /* PCS notifier might queue a resolve, cancel it */ + cancel_work_sync(&pl->resolve); + mutex_lock(&pl->state_mutex); list_for_each_entry_safe(pcs, tmp, &pl->pcs_list, list) { list_del(&pcs->list); pcs->phylink = NULL; } + mutex_unlock(&pl->state_mutex); free_pl: fwnode_handle_put(pl->fwnode); kfree(pl); @@ -2224,14 +2343,22 @@ void phylink_destroy(struct phylink *pl) if (pl->link_gpio) gpiod_put(pl->link_gpio); + /* Unregister notifier for late PCS attach */ + if (pl->fwnode_pcs_nb.notifier_call) + unregister_fwnode_pcs_notifier(&pl->fwnode_pcs_nb); + cancel_work_sync(&pl->resolve); + mutex_lock(&pl->state_mutex); + /* Remove every PCS from phylink PCS list */ list_for_each_entry_safe(pcs, tmp, &pl->pcs_list, list) { pcs->phylink = NULL; list_del(&pcs->list); } + mutex_unlock(&pl->state_mutex); + fwnode_handle_put(pl->fwnode); kfree(pl); diff --git a/include/linux/pcs/pcs.h b/include/linux/pcs/pcs.h index ef2134c578c7..83e0a2ad4b09 100644 --- a/include/linux/pcs/pcs.h +++ b/include/linux/pcs/pcs.h @@ -4,7 +4,38 @@ #include +enum fwnode_pcs_notify_event { + FWNODE_PCS_PROVIDER_DEL, +}; + +struct fwnode_pcs_provider; + #if IS_ENABLED(CONFIG_FWNODE_PCS) +/** + * register_fwnode_pcs_notifier - Register a notifier block for fwnode + * PCS events + * @nb: pointer to the notifier block + * + * Registers a notifier block to the fwnode_pcs_notify_list blocking + * notifier chain. This allows phylink instance to subscribe for + * PCS provider events. + * + * Returns: 0 or a negative error. + */ +int register_fwnode_pcs_notifier(struct notifier_block *nb); + +/** + * unregister_fwnode_pcs_notifier - Unregister a notifier block for fwnode + * PCS events + * @nb: pointer to the notifier block + * + * Unregisters a notifier block to the fwnode_pcs_notify_list blocking + * notifier chain. + * + * Returns: 0 or a negative error. + */ +int unregister_fwnode_pcs_notifier(struct notifier_block *nb); + /** * fwnode_pcs_get - Retrieves a PCS from a firmware node * @fwnode: firmware node @@ -19,6 +50,27 @@ struct phylink_pcs *fwnode_pcs_get(const struct fwnode_handle *fwnode, unsigned int index); +/** + * fwnode_pcs_matches_provider() - Check whether a PCS belongs to a provider + * @provider: PCS provider to check + * @fwnode: firmware node containing the PCS references + * @pl_pcs: PCS to check + * + * Parse the PCS references from the "pcs-handle" property of a firmware node + * and use provider to determine whether pl_pcs is one of the PCS provided by + * provider. + * + * This function is intended to be used when handling provider removal + * notifications, where the provider is already known and its PCS need to be + * identified among the PCS associated with a phylink instance. + * + * Returns: true if pl_pcs is provided by provider and referenced by fwnode, + * false otherwise. + */ +bool fwnode_pcs_matches_provider(struct fwnode_pcs_provider *provider, + const struct fwnode_handle *fwnode, + struct phylink_pcs *pl_pcs); + /** * fwnode_phylink_pcs_count - Count PCS entries described in firmware node * @fwnode: firmware node @@ -52,12 +104,29 @@ int fwnode_phylink_pcs_parse(struct fwnode_handle *fwnode, struct phylink_pcs **available_pcs, unsigned int num_pcs); #else +static inline int register_fwnode_pcs_notifier(struct notifier_block *nb) +{ + return -EOPNOTSUPP; +} + +static inline int unregister_fwnode_pcs_notifier(struct notifier_block *nb) +{ + return -EOPNOTSUPP; +} + static inline struct phylink_pcs *fwnode_pcs_get(const struct fwnode_handle *fwnode, unsigned int index) { return ERR_PTR(-ENOENT); } +static inline bool fwnode_pcs_matches_provider(struct fwnode_pcs_provider *provider, + const struct fwnode_handle *fwnode, + struct phylink_pcs *pl_pcs) +{ + return false; +} + static inline unsigned int fwnode_phylink_pcs_count(struct fwnode_handle *fwnode) { return 0; -- 2.55.0