From: Jonathan Cameron <jic23@kernel.org>
To: Karl Mehltretter <kmehltretter@gmail.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Davidlohr Bueso <dave@stgolabs.net>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] memregion: fix cache invalidation warning message
Date: Wed, 23 Sep 2026 02:44:37 +0100 [thread overview]
Message-ID: <20260923024437.03f42bbe@jic23-hlaptop> (raw)
In-Reply-To: <aqUY5Zho3sKFP_84@gmail.com>
On Sat, 12 Sep 2026 11:19:57 +0200
Karl Mehltretter <kmehltretter@gmail.com> wrote:
> On Sat, Aug 08, 2026 at 02:19:43PM +0100, Karl Mehltretter wrote:
> > WARN_ON_ONCE() takes a condition, not a message. The string literal is
> > always true, so the warning still triggers but the message is never
> > printed.
> >
> > Use WARN_ONCE(1, ...) instead to print the message and keep the
> > once-only behavior.
> >
> > Found with a Coccinelle script. Clang's -Wstring-conversion also flags
> > such calls but is not enabled in kernel builds.
> >
> > Fixes: 1156b4418db0 ("memregion: Add cpu_cache_invalidate_memregion() interface")
> > Assisted-by: Claude:claude-fable-5 coccinelle
> > Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
>
> Friendly ping on this patch.
>
> Updating Jonathan's Cc address to jic23@kernel.org, as the original
> submission bounced at his old Huawei address.
Acked-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
>
> Thanks,
> Karl
prev parent reply other threads:[~2026-09-23 1:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-08 12:19 [PATCH] memregion: fix cache invalidation warning message Karl Mehltretter
2026-09-12 9:19 ` Karl Mehltretter
2026-09-23 1:44 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923024437.03f42bbe@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=kmehltretter@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox