From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, John Garry <john.g.garry@oracle.com>,
Marco Elver <elver@google.com>,
llvm@lists.linux.dev
Subject: Re: [PATCH v4 7/8] scsi: scsi_debug: Improve lock context annotations
Date: Thu, 8 Oct 2026 09:10:45 +0200 [thread overview]
Message-ID: <20261008071045.GB30898@lst.de> (raw)
In-Reply-To: <cf697d5c-1b5d-4e3a-983b-f710eb41b5b6@acm.org>
On Wed, Oct 07, 2026 at 01:10:27PM -0700, Bart Van Assche wrote:
> Do you like the alternative below better? If so then I will replace
> patch 7/8 with the changes below.
Much better, although I'd drop the pointless inversion of the
condition and keep the flow as in the old version:
static inline void
sdeb_read_lock(rwlock_t *lock)
__acquires_shared(lock)
{
if (sdebug_no_rwlock)
__acquire_shared(lock);
else
read_lock(lock);
}
prev parent reply other threads:[~2026-10-08 7:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1791349129.git.bvanassche@acm.org>
[not found] ` <765bf3683555f3d7fbe8510cde1eb50d5f6d0c6f.1791349129.git.bvanassche@acm.org>
2026-10-07 13:14 ` [PATCH v4 7/8] scsi: scsi_debug: Improve lock context annotations Christoph Hellwig
2026-10-07 14:31 ` Marco Elver
2026-10-07 20:10 ` Bart Van Assche
2026-10-08 7:10 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261008071045.GB30898@lst.de \
--to=hch@lst.de \
--cc=bvanassche@acm.org \
--cc=elver@google.com \
--cc=john.g.garry@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox