From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6243568531 for ; Tue, 13 Oct 2026 22:40:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791931241; cv=none; b=Q4ZEKoFkmcYK6URkmBIzHhpki1gt74HQQH56trifE/k1DgJNqj4/jj2ywDMlfPxY9NsGFNQokFdCMipxwOMJckdhNW/QANQVhn5FzdvHmOfRs8285HIJSxCxXYn62ziXi3vnhJ5/wmFcwq8ir1LumrXYtmSMf/J+8h2ZuRAAVsw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791931241; c=relaxed/simple; bh=yGWlUBd3WHI6EIBVLEUjSDo5J54V9OXwWHfKf5QXzl4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=FHQJ/ZjkBxke8OQkIf5cK6Bmqso5DaBCUhZQQzireA+s4lpAfeYd1Rvo2xd1heTyRXHxUier0EGYCylb8szD/IzOYgxs8H4RzbLBTmwIgqB7mgipNPh4C5U9gCcPEZjX79sxUL3ArbP3grKUGbH2eaH427mkWiUvyrIFBvv2LWI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=VumNPHHi; arc=none smtp.client-ip=74.125.82.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="VumNPHHi" Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-35d4538fd74so1601271eec.1 for ; Tue, 13 Oct 2026 15:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1791931230; x=1792536030; darn=lists.linux.dev; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SzuEQJa4uF6wSn0s7ZpxNvjcEHFt9KB4NkbiARikmlQ=; b=VumNPHHiMV0PQdtYx4nlSku+XBQVR7K/R8wfSFj5TWV6fjtl067QxS+uWsOzJQKbGN KY4lG6dHHNTC2CwlNCGS2bbJttryUM91P1nxldmmX+6nR34hRzLHLaM98eiCRwX2U4j2 tQuGW7/XSlNxhyFKIn98KClwqIRn8M8JYnvEr0u7EAirZYPeG97jSkaXo5zPKFtpWLZg YX3ZecYmdfihjsr0uLdOBwct5Pt/uyUzf+YP5hoZsHuYQitvFZ4Vfnr8AT74CfMyo8/m 4tLqMwmTgPCVTiyAY9/2GR+yWIDmEE6GzlR5q9IA7aB6oxRzf2GxEUPJnEyMki/nkqqI UOUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791931230; x=1792536030; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SzuEQJa4uF6wSn0s7ZpxNvjcEHFt9KB4NkbiARikmlQ=; b=0HloSNkw0tsRsBcdlu0Jy2U67EjMrC7yeWw4/GOdD4wQ2AnduIOKxp2Wt4Y4FANbPI odRPckN5xsfvyPN67nT8e73/u90jSp+nJYhL0tMx6DIaGrc6JpLYqNFwKQlVxo98CULc TFD3Wj7uI/pOtHZFMejGjRaWQVlq6c+hnNEcLCAbOcgVOvUcn+097nLCX1uksPwufnwV vaA23OVvpjbIBKUMr4EgfHNZ/ZObehW0mxLfQvDhCGW8KWySsj3J2i2wmedXpeY2+ekF BVwCyM16snucxwKf/I1bgFhpus2tiWBReuc/5ipy1A7Cf0HaiWrqOQfQs1f+R66dkEqf 4/Zg== X-Forwarded-Encrypted: i=1; AKwUvBzaMOZDjPswZ+ah1Fzt05oZZJeLfBQtSc7NL47N4PQw3wBTHGip65bzYkwRp6689bmYQkdI@lists.linux.dev X-Gm-Message-State: AFq9FYL3tv75aDfcx1/xyrnuLe1sD86yZKrLVFV+ZS7CnS0wmBMz8DoH /f1L8zPU0iUSf2Mvp9qBbOhGz8xq7YWaBol9qk2KuQvwnwdnQsD6Y8K2CphFOTVi/01E2d3+UwC xEGGr1rZT+w== X-Received: from dybmf44.prod.google.com ([2002:a05:7301:92c:b0:358:41fa:f46f]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7300:c8c2:b0:35a:8dad:6724 with SMTP id 5a478bee46e88-35a8dad7ec8mr9213311eec.22.1791931228757; Tue, 13 Oct 2026 15:40:28 -0700 (PDT) Date: Tue, 13 Oct 2026 15:39:42 -0700 In-Reply-To: <20261013223946.1836757-1-irogers@google.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20261013223946.1836757-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.385.gd3acb90ef8-goog Message-ID: <20261013223946.1836757-8-irogers@google.com> Subject: [PATCH 07/11] xen/sys-hypervisor: Add release callback to hyp_sysfs_kobj_type From: Ian Rogers To: Greg Kroah-Hartman , "Rafael J . Wysocki" , Danilo Krummrich , Miguel Ojeda , Kees Cook , Nathan Chancellor Cc: Nick Desaulniers , Bill Wendling , Justin Stitt , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nayna Jain , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Viresh Kumar , David Teigland , Alexander Aring , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Richard Weinberger , Zhihao Cheng , Felix Kuehling , Alex Deucher , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-s390@vger.kernel.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers Content-Type: text/plain; charset="UTF-8" hypervisor_init() in drivers/base/hypervisor.c creates hypervisor_kobj with kobject_create_and_add() (which allocates a dynamic kobject using dynamic_kobj_ktype), and hypervisor_subsys_init() in drivers/xen/sys-hypervisor.c then overwrites hypervisor_kobj->ktype with &hyp_sysfs_kobj_type, which had no .release callback. Add hyp_sysfs_release() calling kfree(kobj) to preserve the dynamic kobject release behavior. Fixes: cff7e81b3dd7 ("xen: add /sys/hypervisor support") Assisted-by: Antigravity:gemini-3.1-pro Signed-off-by: Ian Rogers --- drivers/xen/sys-hypervisor.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c index 91923242a5ae..0e8a2cd69fd6 100644 --- a/drivers/xen/sys-hypervisor.c +++ b/drivers/xen/sys-hypervisor.c @@ -659,7 +659,13 @@ static const struct sysfs_ops hyp_sysfs_ops = { .store = hyp_sysfs_store, }; +static void hyp_sysfs_release(struct kobject *kobj) +{ + kfree(kobj); +} + static const struct kobj_type hyp_sysfs_kobj_type = { + .release = hyp_sysfs_release, .sysfs_ops = &hyp_sysfs_ops, }; -- 2.56.0.385.gd3acb90ef8-goog