Building the Linux kernel with Clang and LLVM
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>
Cc: "Sasha Levin" <sashal@kernel.org>,
	"Darren Hart" <dvhart@infradead.org>,
	"Davidlohr Bueso" <dave@stgolabs.net>,
	"André Almeida" <andrealmeid@igalia.com>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Shuah Khan" <shuah@kernel.org>,
	llvm@lists.linux.dev, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] selftests/futex: load atomic values before harness comparisons
Date: Wed, 14 Oct 2026 16:01:47 -0400	[thread overview]
Message-ID: <20261014200147.1364987-1-sashal@kernel.org> (raw)

Clang 21 rejects the harness comparison because typeof(*futex) preserves
the atomic qualification. Load the value explicitly in the three affected
assertions so the harness compares unsigned integers. Atomic access and
its existing sequentially consistent ordering are preserved.

The baseline produces three invalid-operands errors. The complete futex
suite builds with Clang 21 and GCC 14 after the change.

Fixes: 608323bf7bb8 ("selftests: futex: Add tests for robust release operations")
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 tools/testing/selftests/futex/functional/robust_list.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/futex/functional/robust_list.c b/tools/testing/selftests/futex/functional/robust_list.c
index 87217c5493619..895e6cfe59bcd 100644
--- a/tools/testing/selftests/futex/functional/robust_list.c
+++ b/tools/testing/selftests/futex/functional/robust_list.c
@@ -669,7 +669,7 @@ TEST_F(vdso_unlock, test_robust_try_unlock_uncontended)
 	ret = self->vdso(futex, tid, &head.list_op_pending);
 
 	ASSERT_EQ(ret, tid);
-	ASSERT_EQ(*futex, 0);
+	ASSERT_EQ(atomic_load(futex), 0);
 
 	/* Check only the lower 32 bits for the 32-bit entry point */
 	if (variant->is_32) {
@@ -709,7 +709,7 @@ TEST_F(vdso_unlock, test_robust_try_unlock_contended)
 	ret = self->vdso(futex, tid, &head.list_op_pending);
 
 	ASSERT_EQ(ret, tid | FUTEX_WAITERS);
-	ASSERT_EQ(*futex, tid | FUTEX_WAITERS);
+	ASSERT_EQ(atomic_load(futex), tid | FUTEX_WAITERS);
 	ASSERT_EQ(head.list_op_pending, &lock.list);
 }
 
@@ -793,7 +793,7 @@ TEST_F(futex_op, test_futex_robust_unlock)
 				      &head.list_op_pending, variant->val3);
 
 	ASSERT_EQ(ret, 0);
-	ASSERT_EQ(*futex, 0);
+	ASSERT_EQ(atomic_load(futex), 0);
 
 	if (variant->op & FUTEX_ROBUST_LIST32) {
 		exp = (uint64_t)(unsigned long)&lock.list;

base-commit: 4eb2586bd40db27d77cc5b724ca9386ed0c71d53
-- 
2.53.0


                 reply	other threads:[~2026-10-14 20:01 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261014200147.1364987-1-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=andrealmeid@igalia.com \
    --cc=dave@stgolabs.net \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=mingo@redhat.com \
    --cc=nathan@kernel.org \
    --cc=peterz@infradead.org \
    --cc=shuah@kernel.org \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox