From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.199 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794026482; b=5eRenHiZmJ/VxjfrnZU9jnVJ1cD7OW+kBaWTE4eWb1cIV25UyiKNHS32khzWK+s7UWuX rO/juG5t8SG9GauCyuyjXoaSCbiRR9ehctiNqnQoai2H0XaQqU3m6V6v+do3KF5iIE4+Q VrdTTtnzfM0L6qOkXu3Km24rUUhIs3HTvK7FWVYl60vuRGQUmBeqoMhr7KTVjDXlWAj+L SvffPp+yMtHz+PfEo8RUQUDby5E/1/SbJVA/gudNXse5KmDFJX7HzHfqqngKwPtoiAzwP 1Zvrv0JUMWP52IqQaWI9GcYsnQrGZVTw6Sdy/yjz0Rm4ezDciuncJmG6qou9Q7GVEzA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794026482; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=lOeR8RzemfDpp4D3hAa7zuXnUCxjXzQiGwjs9g5Q/fs=; b=hOHyIdIOMnxGdYwtrDgxpufj8r36qCBX5DfrGOsKqIG80rdrKw8yyJXrF+HlZYCR0l8Z q+zaKiwJVkGQ8mAJDCNTyuvjSVA8uvLjXPCWsEtGr5P2phj90ZlU3gnrUA+rZMbLVk6FS +Er+R5GkMgVQwLoQCId/egiRD3wqt5X9SMsjNUqR14PJ+zJDp6lynmuVbzP4GEkSufw0S I43CuK7C34CK5lHINfSMSJPM+uQvhpac3LF23cG5rEkauFaZiC1S4uHdVToNl0+I1CViP zMT56ogRtkccCjS3AMwPu0WYM25CrDLdHfNikCO0cf30aVv3JMLZi3XVrJFcPvP4dCQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=MOP1VA6K; arc=none smtp.remote-ip=74.125.82.199 Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C71B606A338 for ; Sat, 7 Nov 2026 04:41:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 3C71B606A338 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=MOP1VA6K Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-36f479b9819so2263846eec.1 for ; Fri, 06 Nov 2026 20:41:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1794026481; x=1794631281; darn=lists.linux.dev; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lOeR8RzemfDpp4D3hAa7zuXnUCxjXzQiGwjs9g5Q/fs=; b=MOP1VA6K9FKO7Jdm16BfO1B/RxhPaZtmRL4CsTIwE/obs363mQdk4q5J4uMDtU9yJT QOJ0+9RU6b4fvWHkOZ3DYM8MHNrs11dvf7wTM/kh9ZdKZdI8q9jlYBGaIr9d3ImvVIve vibxTunyrONvI5hSvOSYoWVjZ9jbUeAXeXlbknd6UUAuFfxa8N9EWlhvpCnVa7gCtQ1p afOTNx9I56juQvI3bQyerMxxOEYY0GVlAO/NUQ2E/S4u2QD7l56ZK3XRjvSDgz38paen kqYcGVzw1VdOQwU0vevMNg0dgedIrLIJBCCdvF4ZKxPf8wgpOVidJKH7I0syVZSttNWE /GNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794026481; x=1794631281; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lOeR8RzemfDpp4D3hAa7zuXnUCxjXzQiGwjs9g5Q/fs=; b=a+himL850ddR+G3wnnDTefVxllOWNs9Gj9qGhMbdJNRUpd/Fqzo9h+2BIJKywCFUqi 5ZZMhHtYp6mNSNkpg3eFJff59hnqfldbEDsBWOsPHU3OH31QG/2Vro5X+KCI7Vk9AozU Fps5u89nN8hLxUxhVxu9SEaZ/Y2Mrsbs5adQhAQq7XltxoYzLNtZoD6Sjf+feCqDtINR +95kLcpaELzDDr0iMtgVBdV2tgrg1vEvLpLsM9b9J4CB9aa7VqgXOKMdKCl1dJ4zqxcT 9gXU9dV7+kIUwEoREY2f3b//QfEar/vF2FSPHQl/b8jSgArVTwGL4KA3wY2XjVdWXDha e8Rw== X-Forwarded-Encrypted: i=1; AL+hErHiLpcQMngZ7kBbBJOoKTQH8JNsTuufRLOwKZXxp4mPpuQxD9iUZL/xU1ftYPOHrG1pzeti@lists.linux.dev X-Gm-Message-State: APuU4Z+OXNQE9aE2KUC8ByqE5d5tcgtJSGLlGfmklFhRw3GsTm170nNF 4mv/7x4ijpMaMmzAPDTFg2w5JPgDGz3V5jSfUf8t3iW0USOc8Rh2PU/GoJ+qUsA73Ri06ptob8s 1bq7pdKcDFw== X-Received: from dybmb9.prod.google.com ([2002:a05:7301:1909:b0:36f:7f0f:e2e1]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7301:1525:b0:369:f9c4:1fda with SMTP id 5a478bee46e88-36f7671e12fmr5713721eec.27.1794026480981; Fri, 06 Nov 2026 20:41:20 -0800 (PST) Date: Fri, 6 Nov 2026 20:40:48 -0800 In-Reply-To: <20261107044102.1506626-1-irogers@google.com> X-Mailing-List: llvm@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261107044102.1506626-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.455.g6c5a503b38-goog Message-ID: <20261107044102.1506626-8-irogers@google.com> Subject: [PATCH v11 07/20] perf vdso: Fix unlocked __dsos__add() and race in __machine__addnew_vdso() From: Ian Rogers To: irogers@google.com, acme@kernel.org, namhyung@kernel.org Cc: adrian.hunter@intel.com, bvanassche@acm.org, elver@google.com, james.clark@linaro.org, jolsa@kernel.org, justinstitt@google.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, llvm@lists.linux.dev, mingo@redhat.com, morbo@google.com, nathan@kernel.org, ndesaulniers@google.com, peterz@infradead.org Content-Type: text/plain; charset="UTF-8" __machine__addnew_vdso() called __dsos__add(&machine->dsos, dso) without holding machine->dsos.lock, and machine__findnew_vdso() and __machine__findnew_compat() initialized machine->vdso_info and created temporary VDSO files without synchronization. Acquire machine->dsos.lock in write mode across machine->vdso_info initialization, duplicate checking via __dsos__find(), temporary file creation, dso__set_long_name(), and __dsos__add(). Fixes: f649ed80f3ca ("perf dsos: Tidy reference counting and locking") Signed-off-by: Ian Rogers --- tools/perf/util/dsos.c | 8 ++++++- tools/perf/util/dsos.h | 2 ++ tools/perf/util/vdso.c | 52 +++++++++++++++++++++++++++--------------- 3 files changed, 42 insertions(+), 20 deletions(-) diff --git a/tools/perf/util/dsos.c b/tools/perf/util/dsos.c index a2cd37bd1660..1574c8885d78 100644 --- a/tools/perf/util/dsos.c +++ b/tools/perf/util/dsos.c @@ -284,12 +284,18 @@ static struct dso *__dsos__find_id(struct dsos *dsos, const char *name, const st return res; } +struct dso *__dsos__find(struct dsos *dsos, const char *name, bool cmp_short, bool write_locked) + __must_hold_shared(&dsos->lock) +{ + return __dsos__find_id(dsos, name, &dso_id_empty, cmp_short, write_locked); +} + struct dso *dsos__find(struct dsos *dsos, const char *name, bool cmp_short) { struct dso *res; down_read(&dsos->lock); - res = __dsos__find_id(dsos, name, &dso_id_empty, cmp_short, /*write_locked=*/false); + res = __dsos__find(dsos, name, cmp_short, /*write_locked=*/false); up_read(&dsos->lock); return res; } diff --git a/tools/perf/util/dsos.h b/tools/perf/util/dsos.h index a26774950866..dbd06f420753 100644 --- a/tools/perf/util/dsos.h +++ b/tools/perf/util/dsos.h @@ -30,6 +30,8 @@ void dsos__exit(struct dsos *dsos); int __dsos__add(struct dsos *dsos, struct dso *dso); int dsos__add(struct dsos *dsos, struct dso *dso); +struct dso *__dsos__find(struct dsos *dsos, const char *name, bool cmp_short, bool write_locked) + __must_hold_shared(&dsos->lock); struct dso *dsos__find(struct dsos *dsos, const char *name, bool cmp_short); struct dso *dsos__findnew_id(struct dsos *dsos, const char *name, const struct dso_id *id); diff --git a/tools/perf/util/vdso.c b/tools/perf/util/vdso.c index c12f5d8c4bf6..93828e660672 100644 --- a/tools/perf/util/vdso.c +++ b/tools/perf/util/vdso.c @@ -131,8 +131,13 @@ static struct dso *__machine__addnew_vdso(struct machine *machine, const char *s dso = dso__new(short_name); if (dso != NULL) { - __dsos__add(&machine->dsos, dso); + /* + * Set the long name before adding to machine->dsos so that + * __dsos__add() inserts it in sorted order without needing to + * re-take machine->dsos.lock. + */ dso__set_long_name(dso, long_name, false); + __dsos__add(&machine->dsos, dso); } return dso; @@ -250,15 +255,19 @@ static struct dso *__machine__findnew_compat(struct machine *machine, const char *file_name; struct dso *dso; - dso = dsos__find(&machine->dsos, vdso_file->dso_name, true); + down_write(&machine->dsos.lock); + dso = __dsos__find(&machine->dsos, vdso_file->dso_name, true, /*write_locked=*/true); if (dso) - return dso; + goto out_unlock; file_name = vdso__get_compat_file(vdso_file); if (!file_name) - return NULL; + goto out_unlock; - return __machine__addnew_vdso(machine, vdso_file->dso_name, file_name); + dso = __machine__addnew_vdso(machine, vdso_file->dso_name, file_name); +out_unlock: + up_write(&machine->dsos.lock); + return dso; } static int __machine__findnew_vdso_compat(struct machine *machine, @@ -332,33 +341,38 @@ struct dso *machine__findnew_vdso(struct machine *machine, { struct vdso_info *vdso_info; struct dso *dso = NULL; - char *file; + const char *file; + dso = machine__find_vdso(machine, thread); + if (dso) + return dso; + + down_write(&machine->dsos.lock); if (!machine->vdso_info) machine->vdso_info = vdso_info__new(); vdso_info = machine->vdso_info; - if (!vdso_info) + if (!vdso_info) { + up_write(&machine->dsos.lock); return NULL; - - dso = machine__find_vdso(machine, thread); - if (dso) - return dso; + } #if BITS_PER_LONG == 64 + up_write(&machine->dsos.lock); if (__machine__findnew_vdso_compat(machine, thread, vdso_info, &dso)) return dso; + down_write(&machine->dsos.lock); #endif - dso = dsos__find(&machine->dsos, DSO__NAME_VDSO, true); - if (dso) - return dso; - - file = get_file(&vdso_info->vdso); - if (!file) - return NULL; + dso = __dsos__find(&machine->dsos, DSO__NAME_VDSO, true, /*write_locked=*/true); + if (!dso) { + file = get_file(&vdso_info->vdso); + if (file) + dso = __machine__addnew_vdso(machine, DSO__NAME_VDSO, file); + } + up_write(&machine->dsos.lock); - return __machine__addnew_vdso(machine, DSO__NAME_VDSO, file); + return dso; } bool dso__is_vdso(struct dso *dso) -- 2.56.0.455.g6c5a503b38-goog