Building the Linux kernel with Clang and LLVM
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Josh Poimboeuf <jpoimboe@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Cc: Sasha Levin <sashal@kernel.org>,
	linux-kernel@vger.kernel.org, Bill Wendling <morbo@google.com>,
	Chuck Wolber <chuck@wolber.net>,
	Justin Stitt <justinstitt@google.com>,
	llvm@lists.linux.dev, Marco Elver <elver@google.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Thomas Gleixner <tglx@kernel.org>
Subject: Re: [PATCH v2 11/20] objtool: Detect code coverage instrumentation in noinstr code
Date: Fri, 13 Nov 2026 10:09:20 -0500	[thread overview]
Message-ID: <20261113150920.1953634-1-sashal@kernel.org> (raw)
In-Reply-To: <avX80WkCFuGyS1y0@jpoimboe>

On Thu, Nov 12, 2026 at 10:41:44AM -0800, Josh Poimboeuf wrote:
>I must be missing something, if somebody sets a watchpoint in
>exc_debug_kernel(), don't they get to keep the pieces?

Fair enough, the watchpoint was just the easiest way to show it. The
real reason is that noinstr isn't supposed to have compiler
instrumentation at all, and inlining sneaks the counters back in.

>It's also not clear why --hack-noinstr can't be extended to either NOP
>out the affected instructions, or change the address relocation to point
>to a dummy variable that won't trap.

I tried it, and I think it works better than patch 4, with some caveats :)

NOPing alone isn't enough: besides MC/DC, Clang sometimes loads a
counter address into a register and increments it later. So I NOP the
plain counter updates and point the rest at a dummy. With GCC that
gets all of them. With Clang, 230 of about 3500 still go to the dummy.

Compared to patch 4, a boot covers about 14% more code, since the
__always_inline helpers it dropped are some of the hottest code we
have. It also fixes a GCC MC/DC build failure and some objtool UACCESS
warnings that patch 4 caused, and it handles modules, which this check
never looked at.

The catch is that it's x86-64 only. Other architectures would stay
where they are today: whatever gets inlined into noinstr keeps its gcov
counters, and nothing checks. Keeping patch 4 just for them doesn't
look worth it to me. It cleans up Clang on arm64, but GCC still has
about 190 counters in noinstr there either way, and the GCC MC/DC
build failure shows up on arm64 too.

Peter, are you OK with fixing this on x86 only and leaving the other
architectures as they are? If so, I'll switch to this in v3 and drop
patch 4.

>And the changelog needs all that background, as the justification is not
>clear at all (to me).

Will do.

--
Thanks,
Sasha

  parent reply	other threads:[~2026-11-13 15:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03  1:52 [PATCH v2 00/20] Unify code coverage and add Clang source-based coverage with MC/DC Sasha Levin
2026-11-03  1:52 ` [PATCH v2 01/20] coverage: move gcov and kcov under kernel/coverage/ Sasha Levin
2026-11-05 17:38   ` Peter Oberparleiter
2026-11-13  0:45   ` Nathan Chancellor
2026-11-03  1:52 ` [PATCH v2 04/20] compiler_types.h: Don't instrument __always_inline functions for coverage Sasha Levin
2026-11-03  1:52 ` [PATCH v2 11/20] objtool: Detect code coverage instrumentation in noinstr code Sasha Levin
2026-11-12  6:23   ` Josh Poimboeuf
2026-11-12 13:09     ` Sasha Levin
2026-11-12 15:12       ` Peter Zijlstra
2026-11-12 18:41         ` Josh Poimboeuf
2026-11-12 18:51           ` Josh Poimboeuf
2026-11-13 15:09           ` Sasha Levin [this message]
2026-11-13 18:22             ` Josh Poimboeuf
2026-11-16 19:39               ` Sasha Levin
2026-11-03  1:52 ` [PATCH v2 12/20] x86/sev: Stop excluding noinstr.o from code coverage Sasha Levin
2026-11-03  1:52 ` [PATCH v2 14/20] coverage: add Clang's source-based " Sasha Levin
2026-11-03  1:52 ` [PATCH v2 15/20] x86: Enable " Sasha Levin
2026-11-03  1:52 ` [PATCH v2 16/20] coverage: add MC/DC measurement Sasha Levin
2026-11-13  0:45   ` Nathan Chancellor
2026-11-03  1:52 ` [PATCH v2 19/20] gcov: add MC/DC condition coverage support Sasha Levin
2026-11-05 17:56   ` Peter Oberparleiter
2026-11-06  1:05     ` Sasha Levin
2026-11-03  1:52 ` [PATCH v2 20/20] Documentation: dev-tools: document the common code coverage interface Sasha Levin
2026-11-05 17:36 ` [PATCH v2 00/20] Unify code coverage and add Clang source-based coverage with MC/DC Peter Oberparleiter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261113150920.1953634-1-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=chuck@wolber.net \
    --cc=elver@google.com \
    --cc=jpoimboe@kernel.org \
    --cc=justinstitt@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=mhiramat@kernel.org \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=peterz@infradead.org \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox