From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.50 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794919222; b=o8Xom2fQsC4EzS8mxOswuvrRjr1pyw+mjrnb50eVARvQNztjOzjUv5xQyDsUXg+Z7XEy lxTQ9u6FY44ojnwSC9dK71lZ7ovxOmPj1q56Jwt8RokcfLUPE6MkGh9LSYX2p8vXzP0wL 2UXx8mbcmQ4E4nKOBY+4a5tjyBcpEhO0ln/mY/BvVDfCHaOBjzY30KMqkcSycgIhxtzZ2 LiGsW1Xv9ArPTG76NULbBvyRqhOrH/sSp7r4DLa4CY97zrDcFlRjB5kB+GfNDlDqZCYsh seaJHbg9/LCgZQn69QHrzXrE05hwr1tD8bOBsU8ImePbHEt/5nBxkzvu7+3s1rMwsJA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794919222; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=C0jscx5DDVxF6lxNWbtWfTXvaQUi2T5SH8k3EmxiaYE=; b=4upsuak4lu35fKiPmOhrW4g48AYbXUasO2Gaa+Z8rarwup88dZaBuF4lM87PERPxPBYW H70YvFQr5X0WzWsu/A6c1pPDVIYyfwFGjMcGTpehN857NvmE5i2kuINCepAknuaGFFD2O d28dWHj/+/jxkhyEPMaWcYMc5bwVivbZTWxb363BMY84/HYT1qcMgd2wYFKICR23tHMGN IOiPcx9rBGBfqnu9Ci+oZ5IhhZstQtfP4YZ3VywgTATOtgaUt1p46g1AlJFp/0zTKDwy6 Y2sJlN9vPtSE07QNtft/4v06x1m1/Jn9YBcWHmg0YpSZzQ1KYhVw6l4KgK+uBWCCgRw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=WXLPs4X2; arc=none smtp.remote-ip=209.85.128.50 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B392E60A6F54 for ; Tue, 17 Nov 2026 12:40:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B392E60A6F54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=WXLPs4X2 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4bb606491faso17295405e9.3 for ; Tue, 17 Nov 2026 04:40:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794919220; x=1795524020; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=C0jscx5DDVxF6lxNWbtWfTXvaQUi2T5SH8k3EmxiaYE=; b=WXLPs4X2ThNliI6uAuAwYpKsITbI4alzcWGpCRyZET+VcwsYSyiLC73ia+SA1RCs7r DO7X8tAO0sa67CcMhSS2WTdoYsY6qlPnnatCyIxZ6rTl3oUsZi1Ri1J4STTtUrgTsbcP RQXSOl+j7yWmUh08k3La1KIMuA0MRnmeLFmuenqS6C/MgZ/yisOJPZIqQvhpopYXQ2jX ei8w9xFnHRArsoP6w3kxcbBq8fSEau24yvpbHYf+YXrlWidxsNaOUYCAg361jvSDWbGR sLjU9pogzKiPM8lWQJ5Me0Kn740PbxeBKk/V2H7Aa2AxJSONyV9HJxQD2hAO8v0D1hwH rFRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794919220; x=1795524020; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=C0jscx5DDVxF6lxNWbtWfTXvaQUi2T5SH8k3EmxiaYE=; b=UmFLnNqPd5txoL5gfLZpqsgOb0OguSC1CewcmhKwKRo+4i79emaLrsRSZEllGqekdP dvkOSRz6opSMQEP8T1rvdvGAIIcwICFCxIaPyGURi1pF12oV9E6K3BhH3CzhkGCDm5I2 PY5cyq1xK2d1KndXiRzq249oC8Ui9P3IcN4MCVzINzeJp34QkYMa9zpE67wQf56NPxY8 2bBFgi3eHkX4iHNJPKoqLW0FMLjiiESTwd9J8urXkRqWLOy97IJelyv6QLSwjjIeMitP /SY12KCZAOx6Ca9EwEErX5vas0U4GIgJhdhbxF2UeN+5MbHMY9Lb+e1nkVFLtSs1Nzll rDEQ== X-Forwarded-Encrypted: i=1; AL+hErGuM2YlU/rnQ2pj8IvY/uWUIOCE5+ZZa6y9wuAip49hZ/sQ0wKJp+PMJOd+bB8VO8P9csnp@lists.linux.dev X-Gm-Message-State: APuU4Z+vypWQ8i8euUlCOahkJaCwgRnuX9bQ9sSl+Jk2S+j1g8ZiXq8F 7LnWeJKn1DOSw8CgBIPSVUvq4Lq+gOWoUT9n8cZKHIalm9y5p2FIErJa X-Gm-Gg: AYBFou05CJmhSv/RdQzLkE/9LIyvZJSvW7rnI5TnmoN7EDDWyZ+cK2UMVwEDGOWGqik 1OGdtCnGytZZaYOxT3rcEiF8YrwCPX27XYaqqfjgsCxO80GLrY5HzUJOUlVrY0ZxHDrJNyTdlgF MMWciJbaA7B7OumUUVZv7aWA9D/MIRWb/TFd6ty7rZBahdoYY5aa00RYsFtkTUJhalT1F12ldII O3Uxd2amcXoMPbRKLwi6prcId3djSZaNWMJrgroxsmD4g0VcgyoljmN1Lb517303CArSZJtiTcp 7KQ846YCMtNmNoZ9mqDNeQcu0QcSSKU/xqsp6qNPPPgvmf05yY4HIhvYCaHghPTJEfOHldJbHPT N2FLwPGnVc4COvZkSy9TFcLkUpjwWjLDFm9MN06lO2GFevhcjmFt1DR/KGDyD1bZAYGOb60XMrV ML7EvMems75r7RLClv+xkLOdGK1fLBe90UytNpGE1pm2YXi8XeAcvxEzibC/vtg8OWPTGjVqDxt rOzX15wLK5j3MhzRRs3oZNzxo1ol6WRF+DQYRfvuvyrnZq7a6X3SKZQLmkerHjxgXOEHMq48eLE Bc2d34oHE3OdjpWEvPrhQ3Z0XWzkzSKYh9F9K6Bis8opbTpCi1gcS+ywJZaTc0YI87WrMLVvCnQ F5fX1Lyyav+45xLmI6pIJcGZdM3FHOeOQHQ== X-Received: by 2002:a05:600c:3b98:b0:4b7:6a8b:9df2 with SMTP id 5b1f17b1804b1-4bb55a8c128mr293542685e9.25.1794919220027; Tue, 17 Nov 2026 04:40:20 -0800 (PST) Received: from Ansuel-XPS24.localdomain (93-34-92-103.ip49.fastwebnet.it. [93.34.92.103]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4bb78386902sm73367065e9.1.2026.11.17.04.40.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 04:40:19 -0800 (PST) From: Christian Marangi To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Jonathan Corbet , Shuah Khan , Randy Dunlap , Christian Marangi , Lorenzo Bianconi , Heiner Kallweit , Russell King , Maxime Chevallier , Philipp Zabel , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , "Russell King (Oracle)" , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, llvm@lists.linux.dev Subject: [PATCH net-next v22 06/15] net: phylink: make phylink_validate state locked Date: Tue, 17 Nov 2026 13:39:46 +0100 Message-ID: <20261117123956.11981-7-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261117123956.11981-1-ansuelsmth@gmail.com> References: <20261117123956.11981-1-ansuelsmth@gmail.com> X-Mailing-List: llvm@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for support for PCS release/late attach, rework the phylink_validate functions to be locked under the state mutex. With the introduction of a notifier that can be called concurrently while a phylink_create is called or an interface mode validation is being run, on recalculating the supported interface and capabilities, an inconsistency can be introduced with 2 validation run at the same time. To handle this, make the phylink_validate lock under the phylink state mutex, add lockless variant for phylink_validate_mask and phylink_validate and add lockdep check to make sure the mutex is held in the inner validate functions. Function that already run phylink_validate under state mutex, are updated to use the lockless variant. Special care was needed for phy_get_rate_matching that required a lockless variant. This is introduced by adding an internal phy header. Signed-off-by: Christian Marangi --- drivers/net/phy/phy-internal.h | 22 ++++++++++++ drivers/net/phy/phy.c | 11 +++--- drivers/net/phy/phylink.c | 62 ++++++++++++++++++++++++++++------ 3 files changed, 79 insertions(+), 16 deletions(-) create mode 100644 drivers/net/phy/phy-internal.h diff --git a/drivers/net/phy/phy-internal.h b/drivers/net/phy/phy-internal.h new file mode 100644 index 000000000000..56d87495e1f0 --- /dev/null +++ b/drivers/net/phy/phy-internal.h @@ -0,0 +1,22 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef __PHY_INTERNAL_H +#define __PHY_INTERNAL_H + +#include +#include + +static inline int __phy_get_rate_matching(struct phy_device *phydev, + phy_interface_t iface) +{ + int ret = RATE_MATCH_NONE; + + lockdep_assert_held(&phydev->lock); + + if (phydev->drv->get_rate_matching) + return phydev->drv->get_rate_matching(phydev, iface); + + return ret; +} + +#endif /* __PHY_INTERNAL_H */ diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index fce9bc7be330..e305bbff16ad 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -38,6 +38,7 @@ #include "phylib-internal.h" #include "phy-caps.h" +#include "phy-internal.h" #define PHY_STATE_TIME HZ @@ -146,13 +147,11 @@ EXPORT_SYMBOL(phy_print_status); int phy_get_rate_matching(struct phy_device *phydev, phy_interface_t iface) { - int ret = RATE_MATCH_NONE; + int ret; - if (phydev->drv->get_rate_matching) { - mutex_lock(&phydev->lock); - ret = phydev->drv->get_rate_matching(phydev, iface); - mutex_unlock(&phydev->lock); - } + mutex_lock(&phydev->lock); + ret = __phy_get_rate_matching(phydev, iface); + mutex_unlock(&phydev->lock); return ret; } diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 091c3a79c120..88280866c19a 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include #include @@ -24,6 +25,7 @@ #include #include "phy-caps.h" +#include "phy-internal.h" #include "sfp.h" #include "swphy.h" @@ -550,6 +552,8 @@ static int phylink_validate_mac_and_pcs(struct phylink *pl, unsigned long capabilities; int ret; + lockdep_assert_held(&pl->state_mutex); + /* Get the PCS for this interface mode */ if (pl->mac_ops->mac_select_pcs) { pcs = pl->mac_ops->mac_select_pcs(pl->config, state->interface); @@ -628,13 +632,15 @@ static void phylink_validate_one(struct phylink *pl, struct phy_device *phy, __ETHTOOL_DECLARE_LINK_MODE_MASK(tmp_supported); struct phylink_link_state tmp_state; + lockdep_assert_held(&pl->state_mutex); + linkmode_copy(tmp_supported, supported); tmp_state = *state; tmp_state.interface = interface; if (phy) - tmp_state.rate_matching = phy_get_rate_matching(phy, interface); + tmp_state.rate_matching = __phy_get_rate_matching(phy, interface); if (!phylink_validate_mac_and_pcs(pl, tmp_supported, &tmp_state)) { phylink_dbg(pl, " interface %u (%s) rate match %s supports %*pbl\n", @@ -648,15 +654,17 @@ static void phylink_validate_one(struct phylink *pl, struct phy_device *phy, } } -static int phylink_validate_mask(struct phylink *pl, struct phy_device *phy, - unsigned long *supported, - struct phylink_link_state *state, - const unsigned long *interfaces) +static int __phylink_validate_mask(struct phylink *pl, struct phy_device *phy, + unsigned long *supported, + struct phylink_link_state *state, + const unsigned long *interfaces) { __ETHTOOL_DECLARE_LINK_MODE_MASK(all_adv) = { 0, }; __ETHTOOL_DECLARE_LINK_MODE_MASK(all_s) = { 0, }; int interface; + lockdep_assert_held(&pl->state_mutex); + for_each_set_bit(interface, interfaces, PHY_INTERFACE_MODE_MAX) phylink_validate_one(pl, phy, supported, state, interface, all_s, all_adv); @@ -667,14 +675,36 @@ static int phylink_validate_mask(struct phylink *pl, struct phy_device *phy, return phylink_is_empty_linkmode(supported) ? -EINVAL : 0; } -static int phylink_validate(struct phylink *pl, unsigned long *supported, - struct phylink_link_state *state) +static int phylink_validate_mask(struct phylink *pl, struct phy_device *phy, + unsigned long *supported, + struct phylink_link_state *state, + const unsigned long *interfaces) +{ + int ret; + + if (phy) + mutex_lock(&phy->lock); + + mutex_lock(&pl->state_mutex); + ret = __phylink_validate_mask(pl, phy, supported, state, interfaces); + mutex_unlock(&pl->state_mutex); + + if (phy) + mutex_unlock(&phy->lock); + + return ret; +} + +static int __phylink_validate(struct phylink *pl, unsigned long *supported, + struct phylink_link_state *state) { const unsigned long *interfaces = pl->supported_interfaces; + lockdep_assert_held(&pl->state_mutex); + if (state->interface == PHY_INTERFACE_MODE_NA) - return phylink_validate_mask(pl, NULL, supported, state, - interfaces); + return __phylink_validate_mask(pl, NULL, supported, state, + interfaces); if (!test_bit(state->interface, interfaces)) return -EINVAL; @@ -682,6 +712,18 @@ static int phylink_validate(struct phylink *pl, unsigned long *supported, return phylink_validate_mac_and_pcs(pl, supported, state); } +static int phylink_validate(struct phylink *pl, unsigned long *supported, + struct phylink_link_state *state) +{ + int ret; + + mutex_lock(&pl->state_mutex); + ret = __phylink_validate(pl, supported, state); + mutex_unlock(&pl->state_mutex); + + return ret; +} + static void phylink_fill_fixedlink_supported(unsigned long *supported) { linkmode_set_bit(ETHTOOL_LINK_MODE_Pause_BIT, supported); @@ -2117,7 +2159,7 @@ void phylink_update_mac_pause_capabilities(struct phylink *pl, unsigned long mac else if (pl->sfp_bus) linkmode_and(pl->supported, pl->supported, pl->sfp_support); - phylink_validate(pl, pl->supported, config); + __phylink_validate(pl, pl->supported, config); pause_state = config->pause; -- 2.55.0