From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.198 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794941361; b=CAkDRckWUtZfGX/zXS1DSdpAu2OsZj5DErYtbb7Fvh/M3UaY4DT+eMFFuWsMca6xDZg/ 0kusZRzjgH1WGgphSEyPvmRW+E+81aPOSNQ7zb+9h2PUG69STGZ7WNQy/won4jV799f8l eIOGJv02Ex3cR+RxmSwdvejSs64cgKPQa2AErpoYpGd7Zp05VmzAnKGlZrG/+r53dcakp MGAPACEenwYgE4Wdr9eU77W3Qi29pEf/CxOhZVEeyj/BvdQnIxFkY+8dqLgHaNDh/bH4a oqvd4MB+t41mdCov3vsPemG5eYCTI8I9RRo1Gan7ELf2fztHW+tQzVgny0DrCzVxAWA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794941361; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=eeTG4TqTHeCP3y4cQ5EWaophStPtsy5e25rUv6vANm8=; b=CbvNBtr8dkrgoxVo8QiFS1tUR8HGHHaiS5Sz2bY0bcOXkeaD9BAHi/xpkfcqc+jYd/Ce LBxAGBMh7hKpCV7vAKMNmPS5qXlCI3V7pa/Ui+BbsLYdQLRh7hj0F2tjgcYusBtLVukKU DmJqfbVDdMjV5S3eV9BQMZ5BY1r0RCZx1QrVyLu1j3OvytDujlNT45O76i8TGgceunvyO McBIrxpHOl1g4wrwkJX2gBfcUEO88Fw4e9YAOknXmqhHYVLVo6PcGj3DhbxHvGsa657kY dUZAUibPfCIIR0lr+DeFsZuYMKEA2MrKi92a4aMx1R95bHGgO58U7/Db8/VpK/9c5Gg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=TiMJSXg2; arc=none smtp.remote-ip=74.125.82.198 Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35B1E606A33B for ; Tue, 17 Nov 2026 18:49:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 35B1E606A33B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=TiMJSXg2 Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-3821eb27024so220355eec.1 for ; Tue, 17 Nov 2026 10:49:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1794941360; x=1795546160; darn=lists.linux.dev; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=eeTG4TqTHeCP3y4cQ5EWaophStPtsy5e25rUv6vANm8=; b=TiMJSXg24fegnEN8B/deBGTuO0fKkNfRjG3EfPJBztUIU8h6PDmLGal52ixuGWVKxi su4T0ofiQs7F5/3dcjrwUSgPynfBAqSbLOI7c3gqF95AQFjG1kKGazTEcd/LTuKzKd6X rLBntwiSoxOCn4ADAd7ts2/0yUa05vFzM70RLZ+TwbxiOdyfOEAL2j5iwFcDRfEPdLen oC6Vg8BEhbIEzevoWMMf4NItvqjNLP59mei1DD1s8mBBDfMki5y8xKCs7hr1n42LtYf/ bItQAc/tgFlMX4f0S34W39qqNpooWMliEKZf9VB+eYsS/P9LyZ8mCyd3tEcGNkY0YxST GSMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794941360; x=1795546160; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eeTG4TqTHeCP3y4cQ5EWaophStPtsy5e25rUv6vANm8=; b=svm//0QS6pxw2clOZtppfBl+okyjtvYmSoq66ISVS+7xXIq6nN1iemrT85Ko6UwYEm 8mr6X5SHEg/xJD6sbEdECnyV1lktCYi7F7VIJBD1Dlr5PwdHd8sHBZmqVwt+2ZLywepc LoDMm3SsZ5nICC8haraec0pvB5zm6Bx7m7EMmRqOIC7kkZcL2TnZeVLvljQVk9ioFaMm zbmqcPaknSzc91Mm3Fa32e2ILTyaecXqBbizf7ubdu3NtgEl3FE1VYYKqTvHx+lOQSgs MI9NxBe4LRsxO1WzFzg8JgicAw0SLfI3mEKGdPRKBxN3AJnME56nqSdAXVgS1oN5D/bd BUVw== X-Forwarded-Encrypted: i=1; AL+hErFMxkMaiHi5lKHmsohsIrBpqYt25cv2moSCSduds6Z7xPEMhAK1j1hh0eoX5ZJl9zen4Nen@lists.linux.dev X-Gm-Message-State: APuU4Z/ghbkUSbwQJDwlPT5Q+7LRjhtPxh9cSuRAzliBPpZEnnnbaNbr pTvMsuKDVi5Vz7WV8ZQ+Jiy7PboR66bh1CDQKfzDiu9mbhEoahEuZgW3rSJZuQ8thdsZgzQogOj Uw1fODTWN3w== X-Received: from dlbej6.prod.google.com ([2002:a05:7022:c46:b0:1a0:100d:fd6]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:701b:2409:b0:1b3:b833:6565 with SMTP id a92af1059eb24-1b543cd7213mr493110c88.20.1794941359867; Tue, 17 Nov 2026 10:49:19 -0800 (PST) Date: Tue, 17 Nov 2026 10:48:29 -0800 In-Reply-To: <20261117184844.99889-1-irogers@google.com> X-Mailing-List: llvm@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261117184844.99889-1-irogers@google.com> X-Mailer: git-send-email 2.56.1.703.gf848ed807c-goog Message-ID: <20261117184844.99889-9-irogers@google.com> Subject: [PATCH v14 08/23] perf dsos: Skip BPF and OOL DSOs in dsos__find_kernel_dso() From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Marco Elver Cc: Bart Van Assche , Jiri Olsa , Adrian Hunter , James Clark , Weilin Wang , linux-perf-users@vger.kernel.org, llvm@lists.linux.dev, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Ian Rogers Content-Type: text/plain; charset="UTF-8" Factor out dso__is_bpf_prog() from __map__is_bpf_prog() and update dsos__find_kernel_dso_cb() to skip dso__is_bpf_prog(dso), DSO_BINARY_TYPE__BPF_IMAGE, and DSO_BINARY_TYPE__OOL so that dsos__find_kernel_dso() does not match ksymbol DSOs in machine->dsos. In machine__process_ksymbol_register(), also check event->ksymbol.ksym_type == PERF_RECORD_KSYMBOL_TYPE_BPF before setting DSO_BINARY_TYPE__BPF_IMAGE for is_bpf_image() symbols prior to inserting the DSO. Signed-off-by: Ian Rogers --- tools/perf/util/dso.h | 16 ++++++++++++++++ tools/perf/util/dsos.c | 3 +++ tools/perf/util/machine.c | 9 ++++----- tools/perf/util/map.c | 14 ++------------ 4 files changed, 25 insertions(+), 17 deletions(-) diff --git a/tools/perf/util/dso.h b/tools/perf/util/dso.h index f6c60bafcde1..009bd3001ace 100644 --- a/tools/perf/util/dso.h +++ b/tools/perf/util/dso.h @@ -1022,6 +1022,22 @@ static inline bool dso__is_kallsyms(const struct dso *dso) return is_guest_kallsyms_pid_name(name); } +static inline bool dso__is_bpf_prog(const struct dso *dso) +{ + const char *name; + + if (dso__binary_type(dso) == DSO_BINARY_TYPE__BPF_PROG_INFO) + return true; + + /* + * If PERF_RECORD_BPF_EVENT is not included, the dso will not have + * type of DSO_BINARY_TYPE__BPF_PROG_INFO. In such cases, we can + * guess the type based on name. + */ + name = dso__short_name(dso); + return name && !strncmp(name, "bpf_prog_", sizeof("bpf_prog_") - 1); +} + static inline enum dso_binary_type dso__dbginfo_type(const struct dso *dso) { return RC_CHK_ACCESS(dso)->dbginfo_type; diff --git a/tools/perf/util/dsos.c b/tools/perf/util/dsos.c index 1574c8885d78..a7f6a98acbaf 100644 --- a/tools/perf/util/dsos.c +++ b/tools/perf/util/dsos.c @@ -475,6 +475,9 @@ static int dsos__find_kernel_dso_cb(struct dso *dso, void *data) * is_kernel_module() treats it as a kernel cpumode. */ if (!dso__kernel(dso) || + dso__is_bpf_prog(dso) || + dso__binary_type(dso) == DSO_BINARY_TYPE__BPF_IMAGE || + dso__binary_type(dso) == DSO_BINARY_TYPE__OOL || is_kernel_module(dso__long_name(dso), PERF_RECORD_MISC_CPUMODE_UNKNOWN)) return 0; diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index 5b4550e97172..4a3461d79593 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c @@ -791,6 +791,10 @@ static int machine__process_ksymbol_register(struct machine *machine, dso__set_binary_type(dso, DSO_BINARY_TYPE__OOL); dso__data(dso)->file_size = event->ksymbol.len; dso__set_loaded(dso); + } else if (event->ksymbol.ksym_type == PERF_RECORD_KSYMBOL_TYPE_BPF && + is_bpf_image(event->ksymbol.name)) { + dso__set_binary_type(dso, DSO_BINARY_TYPE__BPF_IMAGE); + dso__set_long_name(dso, "", false); } map__set_start(map, event->ksymbol.addr); @@ -802,11 +806,6 @@ static int machine__process_ksymbol_register(struct machine *machine, } dso__set_loaded(dso); - - if (is_bpf_image(event->ksymbol.name)) { - dso__set_binary_type(dso, DSO_BINARY_TYPE__BPF_IMAGE); - dso__set_long_name(dso, "", false); - } } else { dso = dso__get(map__dso(map)); } diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c index d5319ffa88a7..5155c95df85d 100644 --- a/tools/perf/util/map.c +++ b/tools/perf/util/map.c @@ -248,19 +248,9 @@ bool __map__is_extra_kernel_map(const struct map *map) bool __map__is_bpf_prog(const struct map *map) { - const char *name; - struct dso *dso = map__dso(map); - - if (dso__binary_type(dso) == DSO_BINARY_TYPE__BPF_PROG_INFO) - return true; + const struct dso *dso = map__dso(map); - /* - * If PERF_RECORD_BPF_EVENT is not included, the dso will not have - * type of DSO_BINARY_TYPE__BPF_PROG_INFO. In such cases, we can - * guess the type based on name. - */ - name = dso__short_name(dso); - return name && (strstr(name, "bpf_prog_") == name); + return dso && dso__is_bpf_prog(dso); } bool __map__is_bpf_image(const struct map *map) -- 2.56.1.703.gf848ed807c-goog