From: Yujie Liu <yujie.liu@intel.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>, Qu Wenruo <wqu@suse.com>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
<dsterba@suse.com>, <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
<linux-btrfs@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<llvm@lists.linux.dev>, Souptick Joarder <jrdr.linux@gmail.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] btrfs: Initialize ret to 0 in scrub_simple_mirror()
Date: Fri, 25 Feb 2022 17:35:42 +0800 [thread overview]
Message-ID: <28c71b3c-2f96-9962-22fd-eb707346a3c4@intel.com> (raw)
In-Reply-To: <205e5941-6ae0-0482-b083-874daf0e5a46@gmx.com>
Hi Qu,
On 2/24/2022 17:56, Qu Wenruo wrote:
>>
>> For clang analyzer reports, usually we do internal check firstly. We'll
>> send out the
>> report only when we think that it is highly possible to be a true alert.
>
> BTW, do performance benchmarks also go through the same procedure?
> Yes, runtime reports(including boot test, performance benchmarks,
etc.) also go through internal check procedure, but compared with
build issues, sometimes we are not that confident about performance
regressions.
> Although your bots are awesome at detect compiling warning/errors,
> sometimes it's not that straightforward to reproduce the same
> performance regressions.
>
> So it may be worthy some extra steps to verify certain performance
> regressions.
>
Runtime issues are much complicated than build issues, the
performance may fluctuate depending on different software and
hardware environment, so not that straightforward to reproduce.
Please feel free to contact LKP folks if found any false reports of
regressions or any issues in reproducing steps. We can learn more
experience from user feedback and keep optimizing our work flow to
improve the accuracy of catching real regressions.
Thanks,
Yujie
next prev parent reply other threads:[~2022-02-25 9:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-20 14:46 [PATCH] btrfs: Initialize ret to 0 in scrub_simple_mirror() Souptick Joarder
2022-02-21 0:15 ` Qu Wenruo
2022-02-22 7:50 ` Souptick Joarder
2022-02-22 8:04 ` Qu Wenruo
2022-02-22 8:09 ` Souptick Joarder
2022-02-24 9:48 ` Yujie Liu
2022-02-24 9:56 ` Qu Wenruo
2022-02-25 9:35 ` Yujie Liu [this message]
2022-02-25 5:16 ` Souptick Joarder
2022-02-25 10:02 ` Yujie Liu
2022-03-01 1:55 ` Yujie Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28c71b3c-2f96-9962-22fd-eb707346a3c4@intel.com \
--to=yujie.liu@intel.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox