From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 991971C6A0 for ; Sat, 11 May 2024 17:19:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715447966; cv=none; b=C6SaR2QHt7lxJfuuacLs/d767FbR5DyFIJQfOO5/U9c9pEOcpR4RU1Dl23GW8iJWTaCCZLgkrHNj/N16SaQWdxhtx+7FAzBZtQ7h/jKfgxLTEeTyLDi636/n0KZJyv0dX+50SvzUMVOSTG+8o+pHfTc9NWfeH3mDYGmvRPGEoVQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715447966; c=relaxed/simple; bh=pgsGnygtsFDYBZVmkmNEae+IbcuJAAlPGbGMWWujjy8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BwPXAsS2gC3hYu4tvCXJFTVG5uh5EJlWSwqpUsq9SBMMMTElZjNkh5Dj1vhDTDVEtVADoAH6JDaXBnY7S4epLxNzjAREmySxPW3ku+CT4kHGoBgk0CaleQRz08j/YamLZkuhi5pYssuqxr07Gz2rLLj90eydAB3PF6HhQt1tbSI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4A84D113E; Sat, 11 May 2024 10:19:44 -0700 (PDT) Received: from [10.57.65.1] (unknown [10.57.65.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9D0C53F641; Sat, 11 May 2024 10:19:16 -0700 (PDT) Message-ID: <3022c21b-a34d-4592-a0da-79e047372eef@arm.com> Date: Sat, 11 May 2024 18:19:14 +0100 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] selftests/openat2: fix clang build failures: -static-libasan, LOCAL_HDRS Content-Language: en-GB To: John Hubbard , Shuah Khan Cc: Andrew Morton , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Maciej Wieczor-Retman , Christian Brauner , Muhammad Usama Anjum , Alexey Gladkov , Valentin Obst , linux-kselftest@vger.kernel.org, LKML , llvm@lists.linux.dev References: <20240504044336.14411-1-jhubbard@nvidia.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/05/2024 19:22, John Hubbard wrote: > On 5/10/24 10:56 AM, John Hubbard wrote: >> On 5/10/24 4:52 AM, Ryan Roberts wrote: >>> On 04/05/2024 05:43, John Hubbard wrote: >> ... >>> It just occured to me that the bug report I was fixing with my attempt was >>> invoking make like this (see [1]): >>> >>> # tools/testing/selftests/fchmodat2$ make CC=clang >>> # tools/testing/selftests/openat2$ make CC=clang >>> >>> So LLVM is not set in this case. Perhaps my approach [2] (suggested by Arnd) of >>> using cc-option is more robust? (cc-option is alredy used by other selftests). >>> >> >> Yes, I think that would better handle the two cases: setting LLVM, >> and/or setting CC (!). >> >> For that, some nits, but only worth fussing over if the patch hasn't >> gone in yet, or if you're changing it for some other reason: >> > > I just remembered it needs the LOCAL_HDRS approach as well. Did your > patch already go in? Should I fix up this one here to use cc-option, > or go with yours? Either way is fine with me. I don't think my patch has been taken into any branch - I didn't see a notification anyway. So it would be great if you are happy to take ownership of it? - I'm on Paternity leave for the next 3 weeks so wouldn't get it done until I get back. > > thanks,