From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A2DA13FE6; Fri, 18 Aug 2023 03:29:29 +0000 (UTC) Received: from eig-obgw-5007a.ext.cloudfilter.net ([10.0.29.141]) by cmsmtp with ESMTP id WlYwqGrmMDKaKWqAyqKyBu; Fri, 18 Aug 2023 03:29:28 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id WqAxqtH3yor5tWqAyq5lVo; Fri, 18 Aug 2023 03:29:28 +0000 X-Authority-Analysis: v=2.4 cv=Vqcwvs6n c=1 sm=1 tr=0 ts=64dee598 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=WzbPXH4gqzPVN0x6HrNMNA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=UttIx32zK-AA:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=VwQbUJbxAAAA:8 a=i0EeH86SAAAA:8 a=ag1SF4gXAAAA:8 a=pGLkceISAAAA:8 a=KKAkSRfTAAAA:8 a=cm27Pg_UAAAA:8 a=HvF037n1xESchLcPDVoA:9 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 a=Yupwre4RP9_Eg_Bd0iYG:22 a=cvBusfyB2V15izCimMoJ:22 a=xmb-EsYY8bH0VWELuYED:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=xjbvOG8NauNugvpOqj5VzY/ZF7EzjNHNjmP6B/aOxVs=; b=GktlTe+To9HeV2kO5WDru79R4Z iPt3hR2DTvbJTAbpAJdiGBR1tHjoxbh2D7yvTwDADE8m7GgshWFJODYMp5erxnU3CLd82EIABjG7H xhyfGfuBMtuTE0dy4NfU3vbLW/Csg9i925fkn76j5Hld2++LwTepnkCwsV2xzyP38l32sknEXMwC4 UgkIZOhlae1+upzO11Jy5u5gRF0eUjjRb97JZ0wdVIj0dvRdL3EHPA6C913q6IsuGjWVzdFtj/+ed SeBHJgNlftyRqD2rnEOWLaV69sY+BL7JTFvbjiZG8nAu4kqCS2hi/09lvgwW3+tVlsjyL1WIdePXl CW5F0a5g==; Received: from 187-162-21-192.static.axtel.net ([187.162.21.192]:41860 helo=[192.168.15.8]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1qWp2c-001FrW-21; Thu, 17 Aug 2023 21:16:46 -0500 Message-ID: <33143205-00db-9ba5-34df-03dbedef3eb8@embeddedor.com> Date: Thu, 17 Aug 2023 20:17:45 -0600 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 21/21] dmaengine: usb-dmac: Annotate struct usb_dmac_desc with __counted_by Content-Language: en-US To: Kees Cook , Vinod Koul Cc: Yu Kuai , Greg Kroah-Hartman , Jordy Zomer , Jernej Skrabec , Tudor Ambarus , dmaengine@vger.kernel.org, Hector Martin , Sven Peter , Alyssa Rosenzweig , Ludovic Desroches , Lars-Peter Clausen , Zhou Wang , Jie Hai , Andy Gross , Bjorn Andersson , Konrad Dybcio , Green Wan , Orson Zhai , Baolin Wang , Chunyan Zhang , Patrice Chotard , Maxime Coquelin , Alexandre Torgue , Laxman Dewangan , Jon Hunter , Thierry Reding , Peter Ujfalusi , Kunihiko Hayashi , Masami Hiramatsu , Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-kernel@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org References: <20230817235428.never.111-kees@kernel.org> <20230817235859.49846-21-keescook@chromium.org> From: "Gustavo A. R. Silva" In-Reply-To: <20230817235859.49846-21-keescook@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - lists.linux.dev X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.21.192 X-Source-L: No X-Exim-ID: 1qWp2c-001FrW-21 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-21-192.static.axtel.net ([192.168.15.8]) [187.162.21.192]:41860 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 0 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfKYc8fdl5Gq+rcCLpRrDWkjaqmc5iRgEo9H0jrnTbAs+78ohqCZ3NJInFEp4KOGdARqXxKv3qoGeR6v5NayXH+d75QPutI3lWOcbK19SDVvMiU7zXK3X mO6vBdkp4899n3zSHhZGv2F80vliuzgx+5M0pk9DH3NiMFdNgoqFlFqh5yfjjUep5Cn8De5TJD7XCi3tyYJNyZkTq5OSDBDu9oi+WiJitMQ8qjj6Dx9wLSXK w6aZnYiw5XvSNTJhAewt5w== On 8/17/23 17:58, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct usb_dmac_desc. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Vinod Koul > Cc: Yu Kuai > Cc: Greg Kroah-Hartman > Cc: Jordy Zomer > Cc: Jernej Skrabec > Cc: Tudor Ambarus > Cc: dmaengine@vger.kernel.org > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/dma/sh/usb-dmac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c > index b14cf350b669..4cfcd23e3268 100644 > --- a/drivers/dma/sh/usb-dmac.c > +++ b/drivers/dma/sh/usb-dmac.c > @@ -57,7 +57,7 @@ struct usb_dmac_desc { > u32 residue; > struct list_head node; > dma_cookie_t done_cookie; > - struct usb_dmac_sg sg[]; > + struct usb_dmac_sg sg[] __counted_by(sg_allocated_len); > }; > > #define to_usb_dmac_desc(vd) container_of(vd, struct usb_dmac_desc, vd)