From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14FD825DB1D for ; Wed, 20 Aug 2025 01:56:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755654973; cv=none; b=p2I8sfJlmkODEogZjdZQE6yP+0TqLMpikZL0e3QM6xHSNNw9eBM0UQuDOTTmGAiU3mNoaCuVVwEpN/qHxd+Rz0Ml2mfpm7ozUYnIJCcOD2YxO/zEXE0ZWQEwGyxfpQgMA4X1PA7eSfHlqdBpiCMs8JQ1LUikv6EnEcl3Cygudmg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755654973; c=relaxed/simple; bh=4AN/tT/8MLg491te4DnALVVbYyv56y92GYARFuneBg8=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=gkRUIXUvvLXcpLycV9nOqOmZ/UKbSVAFYT/DbTGv52+a4Q+KM0FISM4MSlQH9YQAUs+vyHzhMfI3phkZstVWWoxOsnZUl2FBHOUPqxx0KFiQfb17D/vpxbyQHIeuI8BnOkFXZsNrpc+EXVbFfJ2z3x0ALnO83bEMa1h2rdBn1b0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=kwbjZqVD; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="kwbjZqVD" Message-ID: <33a897b4-7d9a-4641-9c7a-07c19bb9cb6f@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1755654969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T+sb60WMq9s+elk6LLcRRaUDEvLIfQYZTGy2RixZQEM=; b=kwbjZqVDNzhxhfdfPer2yb389B+y86OOTxcjkR3Z5WdIxZK5hxajSVjDJ6DOZKC+gG1Vaw 74SgsC1UPpikSliYOCg9ZZBnKIM984GAx1V4aMf1ks2uDUlsh0gjdgLwbSGJFjILDvSgN9 p52u73u9TPzDj9GN5/1Td8o5eilfKMc= Date: Wed, 20 Aug 2025 09:56:05 +0800 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] panic: Clean up message about deprecated 'panic_print' parameter Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Lance Yang To: kernel test robot , Petr Mladek , Feng Tang Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List , Steven Rostedt , Jonathan Corbet , linux-kernel@vger.kernel.org, paulmck@kernel.org, john.ogness@linutronix.de References: <202508200907.PsZ3geub-lkp@intel.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 2025/8/20 09:54, Lance Yang wrote: > > > On 2025/8/20 09:31, kernel test robot wrote: >> Hi Petr, >> >> kernel test robot noticed the following build errors: >> >> >> >> url:    https://github.com/intel-lab-lkp/linux/commits/ >> UPDATE-20250819-180717/Feng-Tang/lib-sys_info-handle-sys_info_mask-0- >> case/20250815-152131 >> base:   the 3th patch of https://lore.kernel.org/ >> r/20250815071428.98041-4-feng.tang%40linux.alibaba.com >> patch link:    https://lore.kernel.org/r/ >> aKRJKZHgcxyNF3y7%40pathway.suse.cz >> patch subject: [PATCH] panic: Clean up message about deprecated >> 'panic_print' parameter >> config: i386-buildonly-randconfig-004-20250820 (https:// >> download.01.org/0day-ci/archive/20250820/202508200907.PsZ3geub- >> lkp@intel.com/config) >> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project >> 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) >> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/ >> archive/20250820/202508200907.PsZ3geub-lkp@intel.com/reproduce) >> >> If you fix the issue in a separate patch/commit (i.e. not just a new >> version of >> the same patch/commit), kindly add following tags >> | Reported-by: kernel test robot >> | Closes: https://lore.kernel.org/oe-kbuild-all/202508200907.PsZ3geub- >> lkp@intel.com/ >> >> All errors (new ones prefixed by >>): >> >>>> kernel/panic.c:952:2: error: call to undeclared function >>>> 'panic_print_deprecated'; ISO C99 and later do not support implicit >>>> function declarations [-Wimplicit-function-declaration] >>       952 |         panic_print_deprecated(); >>           |         ^ >>     kernel/panic.c:958:2: error: call to undeclared function >> 'panic_print_deprecated'; ISO C99 and later do not support implicit >> function declarations [-Wimplicit-function-declaration] >>       958 |         panic_print_deprecated(); >>           |         ^ >>     2 errors generated. > > > Oops, panic_print_deprecated() is defined within the #ifdef > CONFIG_PROC_SYSCTL block, but it's also called from panic_print_set() Correction: CONFIG_SYSCTL block - sorry ;( > and panic_print_get(), which are outside of that block. > > So, we need to move the definition out of the block to a common > scope where all its callers can see it. @Petr wdyt? > > Thanks, > Lance > >> >> >> vim +/panic_print_deprecated +952 kernel/panic.c >> >>     949 >>     950    static int panic_print_set(const char *val, const struct >> kernel_param *kp) >>     951    { >>   > 952        panic_print_deprecated(); >>     953        return  param_set_ulong(val, kp); >>     954    } >>     955 >> >