llvm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com,
	sudipm.mukherjee@gmail.com,
	Alex Deucher <alexander.deucher@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Tom Rix <trix@redhat.com>,
	Andrey Grodzovsky <andrey.grodzovsky@amd.com>,
	Luben Tuikov <luben.tuikov@amd.com>,
	Philip Yang <Philip.Yang@amd.com>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] drm/amdgpu: initialize r variable into amdgpu_cs_submit function
Date: Tue, 20 Sep 2022 14:23:58 +0200	[thread overview]
Message-ID: <3430255f-3675-eef2-92bd-4eb8be582c83@amd.com> (raw)
In-Reply-To: <20220920122216.346321-1-tommaso.merciai@amarulasolutions.com>

Am 20.09.22 um 14:22 schrieb Tommaso Merciai:
> The builds of arm64 allmodconfig with clang failed to build
> next-20220920 with the following result:
>
> 1190:3: error: variable 'r' is uninitialized when used here [-Werror,-Wuninitialized]
> note: initialize the variable 'r' to silence this warning
>
> This fix compilation error

I've already send a patch to fix this to the mailing list 7 Minutes ago :)

Please review or ack that one.

Thanks,
Christian.

>
> Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index 58088c663125..efa3dc9b69fd 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -1168,7 +1168,7 @@ static int amdgpu_cs_submit(struct amdgpu_cs_parser *p,
>   	struct amdgpu_bo_list_entry *e;
>   	struct amdgpu_job *job;
>   	uint64_t seq;
> -	int r;
> +	int r = 0;
>   
>   	job = p->job;
>   	p->job = NULL;


  reply	other threads:[~2022-09-20 12:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20 12:22 [PATCH] drm/amdgpu: initialize r variable into amdgpu_cs_submit function Tommaso Merciai
2022-09-20 12:23 ` Christian König [this message]
2022-09-20 12:32   ` Tommaso Merciai
2022-09-20 12:57     ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3430255f-3675-eef2-92bd-4eb8be582c83@amd.com \
    --to=christian.koenig@amd.com \
    --cc=Philip.Yang@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=andrey.grodzovsky@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxfancy@googlegroups.com \
    --cc=llvm@lists.linux.dev \
    --cc=luben.tuikov@amd.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=tommaso.merciai@amarulasolutions.com \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).