Re: [CRASH][BISECTED] 6.4.1 crash in boot

[Kees Cook <kees@kernel.org>]

On July 4, 2023 10:20:11 AM PDT, Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr> wrote:
>On 7/4/23 01:09, Kees Cook wrote:> On Mon, Jul 03, 2023 at 12:03:23PM -0700, Kees Cook wrote:
>>> Cool. xhci-hub is in your backtrace, and the above patch was made for
>>> something very similar (though, again, I don't see why you're getting a
>>> _crash_, it should _warn_ and continue normally). And, actually, also
>>> include this patch:
>>> https://lore.kernel.org/lkml/20230614181307.gonna.256-kees@kernel.org/
>> 
>> This is now in Linus's tree:
>> 09b69dd4378b ("usb: ch9: Replace 1-element array with flexible array")
>> 
>> Please also still try with the first patch I mentioned, which is very similar:
>> https://lore.kernel.org/lkml/20230629190900.never.787-kees@kernel.org/
>
>Hi,
>
>I have finally built w both patches (and recommended PSTORE settings were
>default already).

Were you able to find the crashes saved by pstore?

>
>This second patch fixes the booting problem, but alas there is still a problem -

Ah! That's great! They're is still an unexpected crash source, but the trigger is fixed.

>all Wayland and X11.org GUI applications fail to start, with errors like this one:
>
>Jul  4 19:09:07 defiant kernel: [   40.529719] invalid opcode: 0000 [#1] PREEMPT SMP NOPTI

Hmm, is CONFIG_UBSAN_TRAP set?

>Jul  4 19:09:07 defiant kernel: [   40.529726] RIP: 0010:alloc_pid+0x46c/0x480

Hmm, is this patch in your kernel?
https://git.kernel.org/linus/b69f0aeb068980af983d399deafc7477cec8bc04


-- 
Kees Cook