Re: [pdx86-platform-drivers-x86:review-ilpo-next 74/89] drivers/platform/x86/asus-wmi.c:5028:35: error: variable has incomplete type 'struct acpi_s2idle_dev_ops'

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3853 bytes --]

On Tue, 20 May 2025, Luke Jones wrote:

> On Tue, 20 May 2025, at 3:40 PM, Ilpo Järvinen wrote:
> > Luke,
> >
> > Ping? This is still unsolved.
> 
> Oh, my apologies. I've not had much time for kernel work recently but I 
> will try to get to this sometime this week. Thank you for bringing to my 
> attention.

Hi,

Regrettably, I'll probably end up reverting this commit as I'm not going 
send a PR early next week with known problems still unsolved. Delaying PR
is not going the be an option in this round due to the lamparray 
controversy.

I couldn't add the #ifdeffery myself as I was unsure what should be done 
for asus_hotk_prepare().

-- 
 i.

> > On Fri, 9 May 2025, Ilpo Järvinen wrote:
> >> On Fri, 9 May 2025, kernel test robot wrote:
> >> 
> >> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-ilpo-next
> >> > head:   83579675331059689e2869bf752ca9e17fadbd82
> >> > commit: feea7bd6b02d43a794e3f065650d89cf8d8e8e59 [74/89] platform/x86: asus-wmi: Refactor Ally suspend/resume
> >> > config: x86_64-buildonly-randconfig-004-20250509 (https://download.01.org/0day-ci/archive/20250509/202505090418.DaeaXe4i-lkp@intel.com/config)
> >> > compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
> >> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250509/202505090418.DaeaXe4i-lkp@intel.com/reproduce)
> >> > 
> >> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> >> > the same patch/commit), kindly add following tags
> >> > | Reported-by: kernel test robot <lkp@intel.com>
> >> > | Closes: https://lore.kernel.org/oe-kbuild-all/202505090418.DaeaXe4i-lkp@intel.com/
> >> > 
> >> > All errors (new ones prefixed by >>):
> >> > 
> >> > >> drivers/platform/x86/asus-wmi.c:5028:35: error: variable has incomplete type 'struct acpi_s2idle_dev_ops'
> >> >     5028 | static struct acpi_s2idle_dev_ops asus_ally_s2idle_dev_ops = {
> >> >          |                                   ^
> >> >    drivers/platform/x86/asus-wmi.c:5028:15: note: forward declaration of 'struct acpi_s2idle_dev_ops'
> >> >     5028 | static struct acpi_s2idle_dev_ops asus_ally_s2idle_dev_ops = {
> >> >          |               ^
> >> > >> drivers/platform/x86/asus-wmi.c:5063:8: error: call to undeclared function 'acpi_register_lps0_dev'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> >> >     5063 |         ret = acpi_register_lps0_dev(&asus_ally_s2idle_dev_ops);
> >> >          |               ^
> >> > >> drivers/platform/x86/asus-wmi.c:5099:2: error: call to undeclared function 'acpi_unregister_lps0_dev'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> >> >     5099 |         acpi_unregister_lps0_dev(&asus_ally_s2idle_dev_ops);
> >> >          |         ^
> >> >    3 errors generated.
> >> > 
> >> > 
> >> > vim +5028 drivers/platform/x86/asus-wmi.c
> >> > 
> >> >   5026	
> >> >   5027	/* Use only for Ally devices due to the wake_on_ac */
> >> > > 5028	static struct acpi_s2idle_dev_ops asus_ally_s2idle_dev_ops = {
> >> >   5029		.restore = asus_ally_s2idle_restore,
> >> >   5030	};
> >> >   5031	
> >> 
> >> > > 5063		ret = acpi_register_lps0_dev(&asus_ally_s2idle_dev_ops);
> >> 
> >> > > 5099		acpi_unregister_lps0_dev(&asus_ally_s2idle_dev_ops);
> >> 
> >> Hi Luke,
> >> 
> >> It seems CONFIG_SUSPEND is not defined in this config leading to the 
> >> failure. Can you please look at this as I was slight unsure what way the 
> >> fix should go although it looked like some ifdeffery is necessary and 
> >> probably wrapping those register/unregister functions.
> >> 
> >> 
> >
> > -- 
> >  i.
>