From: Val Packett <val@packett.cool>
To: Bjorn Andersson <andersson@kernel.org>
Cc: "Mathieu Poirier" <mathieu.poirier@linaro.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <nick.desaulniers+lkml@gmail.com>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>,
"Matti Lehtimäki" <matti.lehtimaki@gmail.com>,
"Luca Weiss" <luca@lucaweiss.eu>,
"Vladimir Lypak" <vladimir.lypak@gmail.com>,
"Barnabás Czémán" <barnabas.czeman@mainlining.org>,
"Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-remoteproc@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH v2] remoteproc: qcom_wcnss: Fix handling the lack of PD regulators in v3
Date: Fri, 27 Feb 2026 01:20:48 -0300 [thread overview]
Message-ID: <4c8e310c-ab39-491b-9a39-99ddbc943b00@packett.cool> (raw)
In-Reply-To: <mteufo3laiiuhcgbihxnossy4xfkxhct57mkav2fr4oxvaldp7@k6p7edkfgjt4>
On 2/27/26 12:52 AM, Bjorn Andersson wrote:
> On Tue, Feb 24, 2026 at 03:45:05PM -0300, Val Packett wrote:
>> On 2/23/26 5:03 PM, Bjorn Andersson wrote:
>>> On Sun, Feb 01, 2026 at 05:55:03PM -0300, Val Packett wrote:
>>>> The changes introduced to handle single power domain platforms have
>>>> swapped the info pointer increment from num_pd_vregs to num_pds, which
>>>> would shift the info pointer past the end of the array for pronto-v3,
>>>> which does not list power domain regulators in vregs.
>>>>
>>>> This showed up as a difference between GCC- and LLVM-compiled kernels
>>>> on SDM632 devices, where only with LLVM one would get the
>>>> "regulator request with no identifier" error, because the out-of-bounds
>>>> memory ended up being zeroed. Fix by skipping the increment when there
>>>> are more power domains than regulators.
>>>>
>>> Is the error only an error print, or did the thing stop working as well?
>> It's a real error. Likely no one would've bothered debugging it if it
>> weren't breaking everything :)
>>
>> It was a blocker for allowing LLVM/clang builds of the msm8953 kernel in
>> postmarketOS, the whole reason to dig into this was "switching to clang
>> breaks the modem, WTF?!"
>>
> Can you provide me with a Fixes: line please?
>
Oops, did I lose it at some point? o.0 Sorry!
Fixes: 65991ea8a6d1 ("remoteproc: qcom_wcnss: Handle platforms with only
single power domain")
~val
next prev parent reply other threads:[~2026-02-27 4:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-01 20:55 [PATCH v2] remoteproc: qcom_wcnss: Fix handling the lack of PD regulators in v3 Val Packett
2026-02-02 10:57 ` Konrad Dybcio
2026-02-23 20:03 ` Bjorn Andersson
2026-02-24 18:45 ` Val Packett
2026-02-27 3:52 ` Bjorn Andersson
2026-02-27 4:20 ` Val Packett [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-02-09 23:05 Yoann Lecuyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c8e310c-ab39-491b-9a39-99ddbc943b00@packett.cool \
--to=val@packett.cool \
--cc=andersson@kernel.org \
--cc=barnabas.czeman@mainlining.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=justinstitt@google.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux@mainlining.org \
--cc=llvm@lists.linux.dev \
--cc=luca@lucaweiss.eu \
--cc=mathieu.poirier@linaro.org \
--cc=matti.lehtimaki@gmail.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=vladimir.lypak@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox