* Re: [PATCH rtw-next v2 14/14] wifi: rtw89: Enable the new USB modules [not found] <663044d3-0816-4b1b-874d-776835e774e9@gmail.com> @ 2025-06-10 11:55 ` kernel test robot 2025-06-10 13:33 ` Bitterblue Smith 0 siblings, 1 reply; 7+ messages in thread From: kernel test robot @ 2025-06-10 11:55 UTC (permalink / raw) To: Bitterblue Smith, linux-wireless@vger.kernel.org Cc: llvm, oe-kbuild-all, Ping-Ke Shih Hi Bitterblue, kernel test robot noticed the following build errors: [auto build test ERROR on wireless-next/main] [also build test ERROR on wireless/main linus/master v6.16-rc1 next-20250610] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Bitterblue-Smith/wifi-rtw89-8851b-Accept-USB-devices-and-load-their-MAC-address/20250610-033543 base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main patch link: https://lore.kernel.org/r/663044d3-0816-4b1b-874d-776835e774e9%40gmail.com patch subject: [PATCH rtw-next v2 14/14] wifi: rtw89: Enable the new USB modules config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20250610/202506101956.cNXM2Qvb-lkp@intel.com/config) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250610/202506101956.cNXM2Qvb-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202506101956.cNXM2Qvb-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/net/wireless/realtek/rtw89/rtw8851b.c:523:47: error: use of undeclared identifier 'B_AX_SOP_EDSWR' 523 | rtw89_write32_clr(rtwdev, R_AX_SYS_PW_CTRL, B_AX_SOP_EDSWR); | ^ 1 error generated. vim +/B_AX_SOP_EDSWR +523 drivers/net/wireless/realtek/rtw89/rtw8851b.c 31df6df89f9394 Ping-Ke Shih 2023-05-12 477 31df6df89f9394 Ping-Ke Shih 2023-05-12 478 static int rtw8851b_pwr_off_func(struct rtw89_dev *rtwdev) 31df6df89f9394 Ping-Ke Shih 2023-05-12 479 { 31df6df89f9394 Ping-Ke Shih 2023-05-12 480 u32 val32; 66595e31988626 Ping-Ke Shih 2024-10-09 481 int ret; 31df6df89f9394 Ping-Ke Shih 2023-05-12 482 31df6df89f9394 Ping-Ke Shih 2023-05-12 483 ret = rtw89_mac_write_xtal_si(rtwdev, XTAL_SI_ANAPAR_WL, XTAL_SI_RFC2RF, 31df6df89f9394 Ping-Ke Shih 2023-05-12 484 XTAL_SI_RFC2RF); 31df6df89f9394 Ping-Ke Shih 2023-05-12 485 if (ret) 31df6df89f9394 Ping-Ke Shih 2023-05-12 486 return ret; 31df6df89f9394 Ping-Ke Shih 2023-05-12 487 ret = rtw89_mac_write_xtal_si(rtwdev, XTAL_SI_ANAPAR_WL, 0, XTAL_SI_OFF_EI); 31df6df89f9394 Ping-Ke Shih 2023-05-12 488 if (ret) 31df6df89f9394 Ping-Ke Shih 2023-05-12 489 return ret; 31df6df89f9394 Ping-Ke Shih 2023-05-12 490 ret = rtw89_mac_write_xtal_si(rtwdev, XTAL_SI_ANAPAR_WL, 0, XTAL_SI_OFF_WEI); 31df6df89f9394 Ping-Ke Shih 2023-05-12 491 if (ret) 31df6df89f9394 Ping-Ke Shih 2023-05-12 492 return ret; 31df6df89f9394 Ping-Ke Shih 2023-05-12 493 ret = rtw89_mac_write_xtal_si(rtwdev, XTAL_SI_WL_RFC_S0, 0, XTAL_SI_RF00); 31df6df89f9394 Ping-Ke Shih 2023-05-12 494 if (ret) 31df6df89f9394 Ping-Ke Shih 2023-05-12 495 return ret; 31df6df89f9394 Ping-Ke Shih 2023-05-12 496 ret = rtw89_mac_write_xtal_si(rtwdev, XTAL_SI_ANAPAR_WL, XTAL_SI_SRAM2RFC, 31df6df89f9394 Ping-Ke Shih 2023-05-12 497 XTAL_SI_SRAM2RFC); 31df6df89f9394 Ping-Ke Shih 2023-05-12 498 if (ret) 31df6df89f9394 Ping-Ke Shih 2023-05-12 499 return ret; 31df6df89f9394 Ping-Ke Shih 2023-05-12 500 ret = rtw89_mac_write_xtal_si(rtwdev, XTAL_SI_ANAPAR_WL, 0, XTAL_SI_PON_EI); 31df6df89f9394 Ping-Ke Shih 2023-05-12 501 if (ret) 31df6df89f9394 Ping-Ke Shih 2023-05-12 502 return ret; 31df6df89f9394 Ping-Ke Shih 2023-05-12 503 ret = rtw89_mac_write_xtal_si(rtwdev, XTAL_SI_ANAPAR_WL, 0, XTAL_SI_PON_WEI); 31df6df89f9394 Ping-Ke Shih 2023-05-12 504 if (ret) 31df6df89f9394 Ping-Ke Shih 2023-05-12 505 return ret; 31df6df89f9394 Ping-Ke Shih 2023-05-12 506 31df6df89f9394 Ping-Ke Shih 2023-05-12 507 rtw89_write32_set(rtwdev, R_AX_WLAN_XTAL_SI_CONFIG, 31df6df89f9394 Ping-Ke Shih 2023-05-12 508 B_AX_XTAL_SI_ADDR_NOT_CHK); 31df6df89f9394 Ping-Ke Shih 2023-05-12 509 rtw89_write32_set(rtwdev, R_AX_SYS_PW_CTRL, B_AX_EN_WLON); 31df6df89f9394 Ping-Ke Shih 2023-05-12 510 rtw89_write32_clr(rtwdev, R_AX_WLRF_CTRL, B_AX_AFC_AFEDIG); 31df6df89f9394 Ping-Ke Shih 2023-05-12 511 rtw89_write8_clr(rtwdev, R_AX_SYS_FUNC_EN, B_AX_FEN_BB_GLB_RSTN | B_AX_FEN_BBRSTB); 31df6df89f9394 Ping-Ke Shih 2023-05-12 512 31df6df89f9394 Ping-Ke Shih 2023-05-12 513 rtw89_write32_set(rtwdev, R_AX_SYS_PW_CTRL, B_AX_APFM_OFFMAC); 31df6df89f9394 Ping-Ke Shih 2023-05-12 514 31df6df89f9394 Ping-Ke Shih 2023-05-12 515 ret = read_poll_timeout(rtw89_read32, val32, !(val32 & B_AX_APFM_OFFMAC), 31df6df89f9394 Ping-Ke Shih 2023-05-12 516 1000, 20000, false, rtwdev, R_AX_SYS_PW_CTRL); 31df6df89f9394 Ping-Ke Shih 2023-05-12 517 if (ret) 31df6df89f9394 Ping-Ke Shih 2023-05-12 518 return ret; 31df6df89f9394 Ping-Ke Shih 2023-05-12 519 cb97e6b5232342 Bitterblue Smith 2025-06-09 520 if (rtwdev->hci.type == RTW89_HCI_TYPE_PCIE) 31df6df89f9394 Ping-Ke Shih 2023-05-12 521 rtw89_write32(rtwdev, R_AX_WLLPS_CTRL, SW_LPS_OPTION); cb97e6b5232342 Bitterblue Smith 2025-06-09 522 else if (rtwdev->hci.type == RTW89_HCI_TYPE_USB) cb97e6b5232342 Bitterblue Smith 2025-06-09 @523 rtw89_write32_clr(rtwdev, R_AX_SYS_PW_CTRL, B_AX_SOP_EDSWR); 31df6df89f9394 Ping-Ke Shih 2023-05-12 524 31df6df89f9394 Ping-Ke Shih 2023-05-12 525 if (rtwdev->hal.cv == CHIP_CAV) { 31df6df89f9394 Ping-Ke Shih 2023-05-12 526 rtw8851b_patch_swr_pfm2pwm(rtwdev); 31df6df89f9394 Ping-Ke Shih 2023-05-12 527 } else { 31df6df89f9394 Ping-Ke Shih 2023-05-12 528 rtw89_write32_set(rtwdev, R_AX_SPSLDO_ON_CTRL1, B_AX_FPWMDELAY); 31df6df89f9394 Ping-Ke Shih 2023-05-12 529 rtw89_write32_set(rtwdev, R_AX_SPSANA_ON_CTRL1, B_AX_FPWMDELAY); 31df6df89f9394 Ping-Ke Shih 2023-05-12 530 } 31df6df89f9394 Ping-Ke Shih 2023-05-12 531 cb97e6b5232342 Bitterblue Smith 2025-06-09 532 if (rtwdev->hci.type == RTW89_HCI_TYPE_PCIE) { 31df6df89f9394 Ping-Ke Shih 2023-05-12 533 rtw89_write32_set(rtwdev, R_AX_SYS_PW_CTRL, B_AX_APFM_SWLPS); cb97e6b5232342 Bitterblue Smith 2025-06-09 534 } else if (rtwdev->hci.type == RTW89_HCI_TYPE_USB) { cb97e6b5232342 Bitterblue Smith 2025-06-09 535 val32 = rtw89_read32(rtwdev, R_AX_SYS_PW_CTRL); cb97e6b5232342 Bitterblue Smith 2025-06-09 536 val32 &= ~B_AX_AFSM_PCIE_SUS_EN; cb97e6b5232342 Bitterblue Smith 2025-06-09 537 val32 |= B_AX_AFSM_WLSUS_EN; cb97e6b5232342 Bitterblue Smith 2025-06-09 538 rtw89_write32(rtwdev, R_AX_SYS_PW_CTRL, val32); cb97e6b5232342 Bitterblue Smith 2025-06-09 539 } 31df6df89f9394 Ping-Ke Shih 2023-05-12 540 31df6df89f9394 Ping-Ke Shih 2023-05-12 541 return 0; 31df6df89f9394 Ping-Ke Shih 2023-05-12 542 } 31df6df89f9394 Ping-Ke Shih 2023-05-12 543 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH rtw-next v2 14/14] wifi: rtw89: Enable the new USB modules 2025-06-10 11:55 ` [PATCH rtw-next v2 14/14] wifi: rtw89: Enable the new USB modules kernel test robot @ 2025-06-10 13:33 ` Bitterblue Smith 2025-06-11 0:32 ` Ping-Ke Shih 0 siblings, 1 reply; 7+ messages in thread From: Bitterblue Smith @ 2025-06-10 13:33 UTC (permalink / raw) To: kernel test robot, linux-wireless@vger.kernel.org Cc: llvm, oe-kbuild-all, Ping-Ke Shih On 10/06/2025 14:55, kernel test robot wrote: > Hi Bitterblue, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on wireless-next/main] > [also build test ERROR on wireless/main linus/master v6.16-rc1 next-20250610] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Bitterblue-Smith/wifi-rtw89-8851b-Accept-USB-devices-and-load-their-MAC-address/20250610-033543 > base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main > patch link: https://lore.kernel.org/r/663044d3-0816-4b1b-874d-776835e774e9%40gmail.com > patch subject: [PATCH rtw-next v2 14/14] wifi: rtw89: Enable the new USB modules > config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20250610/202506101956.cNXM2Qvb-lkp@intel.com/config) > compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250610/202506101956.cNXM2Qvb-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@intel.com> > | Closes: https://lore.kernel.org/oe-kbuild-all/202506101956.cNXM2Qvb-lkp@intel.com/ > > All errors (new ones prefixed by >>): > >>> drivers/net/wireless/realtek/rtw89/rtw8851b.c:523:47: error: use of undeclared identifier 'B_AX_SOP_EDSWR' > 523 | rtw89_write32_clr(rtwdev, R_AX_SYS_PW_CTRL, B_AX_SOP_EDSWR); > | ^ > 1 error generated. > Oops, I'll add that to reg.h in v3. ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH rtw-next v2 14/14] wifi: rtw89: Enable the new USB modules 2025-06-10 13:33 ` Bitterblue Smith @ 2025-06-11 0:32 ` Ping-Ke Shih 2025-06-11 0:33 ` Ping-Ke Shih 2025-06-11 12:37 ` Bitterblue Smith 0 siblings, 2 replies; 7+ messages in thread From: Ping-Ke Shih @ 2025-06-11 0:32 UTC (permalink / raw) To: Bitterblue Smith, kernel test robot, linux-wireless@vger.kernel.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev > > > >>> drivers/net/wireless/realtek/rtw89/rtw8851b.c:523:47: error: use of undeclared identifier > 'B_AX_SOP_EDSWR' > > 523 | rtw89_write32_clr(rtwdev, R_AX_SYS_PW_CTRL, B_AX_SOP_EDSWR); > > | ^ > > 1 error generated. > > > Oops, I'll add that to reg.h in v3. The NAPI also reported the same things [1] [2]. Not sure if you will send v3 right away. If so, I will ignore v2. [1] http://wifibot.sipsolutions.net/results/969980/14111187/build_32bit/stderr [2] https://patchwork.kernel.org/project/linux-wireless/list/?series=969980 ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH rtw-next v2 14/14] wifi: rtw89: Enable the new USB modules 2025-06-11 0:32 ` Ping-Ke Shih @ 2025-06-11 0:33 ` Ping-Ke Shih 2025-06-11 12:37 ` Bitterblue Smith 1 sibling, 0 replies; 7+ messages in thread From: Ping-Ke Shih @ 2025-06-11 0:33 UTC (permalink / raw) To: Bitterblue Smith, kernel test robot, linux-wireless@vger.kernel.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev > > > > > >>> drivers/net/wireless/realtek/rtw89/rtw8851b.c:523:47: error: use of undeclared identifier > > 'B_AX_SOP_EDSWR' > > > 523 | rtw89_write32_clr(rtwdev, R_AX_SYS_PW_CTRL, B_AX_SOP_EDSWR); > > > | ^ > > > 1 error generated. > > > > > Oops, I'll add that to reg.h in v3. > > The NAPI also reported the same things [1] [2]. Sorry. I meant NIPA instead. > > Not sure if you will send v3 right away. If so, I will ignore v2. > > [1] http://wifibot.sipsolutions.net/results/969980/14111187/build_32bit/stderr > [2] https://patchwork.kernel.org/project/linux-wireless/list/?series=969980 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH rtw-next v2 14/14] wifi: rtw89: Enable the new USB modules 2025-06-11 0:32 ` Ping-Ke Shih 2025-06-11 0:33 ` Ping-Ke Shih @ 2025-06-11 12:37 ` Bitterblue Smith 2025-06-12 1:27 ` Ping-Ke Shih 1 sibling, 1 reply; 7+ messages in thread From: Bitterblue Smith @ 2025-06-11 12:37 UTC (permalink / raw) To: Ping-Ke Shih, kernel test robot, linux-wireless@vger.kernel.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev On 11/06/2025 03:32, Ping-Ke Shih wrote: >>> >>>>> drivers/net/wireless/realtek/rtw89/rtw8851b.c:523:47: error: use of undeclared identifier >> 'B_AX_SOP_EDSWR' >>> 523 | rtw89_write32_clr(rtwdev, R_AX_SYS_PW_CTRL, B_AX_SOP_EDSWR); >>> | ^ >>> 1 error generated. >>> >> Oops, I'll add that to reg.h in v3. > > The NAPI also reported the same things [1] [2]. > > Not sure if you will send v3 right away. If so, I will ignore v2. > > [1] http://wifibot.sipsolutions.net/results/969980/14111187/build_32bit/stderr > [2] https://patchwork.kernel.org/project/linux-wireless/list/?series=969980 > I would prefer to wait for your review. Is that okay? ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH rtw-next v2 14/14] wifi: rtw89: Enable the new USB modules 2025-06-11 12:37 ` Bitterblue Smith @ 2025-06-12 1:27 ` Ping-Ke Shih 2025-06-16 3:15 ` Ping-Ke Shih 0 siblings, 1 reply; 7+ messages in thread From: Ping-Ke Shih @ 2025-06-12 1:27 UTC (permalink / raw) To: Bitterblue Smith, kernel test robot, linux-wireless@vger.kernel.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote: > On 11/06/2025 03:32, Ping-Ke Shih wrote: > >>> > >>>>> drivers/net/wireless/realtek/rtw89/rtw8851b.c:523:47: error: use of undeclared identifier > >> 'B_AX_SOP_EDSWR' > >>> 523 | rtw89_write32_clr(rtwdev, R_AX_SYS_PW_CTRL, B_AX_SOP_EDSWR); > >>> | ^ > >>> 1 error generated. > >>> > >> Oops, I'll add that to reg.h in v3. > > > > The NAPI also reported the same things [1] [2]. > > > > Not sure if you will send v3 right away. If so, I will ignore v2. > > > > [1] http://wifibot.sipsolutions.net/results/969980/14111187/build_32bit/stderr > > [2] https://patchwork.kernel.org/project/linux-wireless/list/?series=969980 > > > > I would prefer to wait for your review. Is that okay? Yes. I will review v2. ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH rtw-next v2 14/14] wifi: rtw89: Enable the new USB modules 2025-06-12 1:27 ` Ping-Ke Shih @ 2025-06-16 3:15 ` Ping-Ke Shih 0 siblings, 0 replies; 7+ messages in thread From: Ping-Ke Shih @ 2025-06-16 3:15 UTC (permalink / raw) To: Bitterblue Smith, kernel test robot, linux-wireless@vger.kernel.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev Ping-Ke Shih <pkshih@realtek.com> wrote: > Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote: > > On 11/06/2025 03:32, Ping-Ke Shih wrote: > > >>> > > >>>>> drivers/net/wireless/realtek/rtw89/rtw8851b.c:523:47: error: use of undeclared identifier > > >> 'B_AX_SOP_EDSWR' > > >>> 523 | rtw89_write32_clr(rtwdev, R_AX_SYS_PW_CTRL, B_AX_SOP_EDSWR); > > >>> | ^ > > >>> 1 error generated. > > >>> > > >> Oops, I'll add that to reg.h in v3. > > > > > > The NAPI also reported the same things [1] [2]. > > > > > > Not sure if you will send v3 right away. If so, I will ignore v2. > > > > > > [1] http://wifibot.sipsolutions.net/results/969980/14111187/build_32bit/stderr > > > [2] https://patchwork.kernel.org/project/linux-wireless/list/?series=969980 > > > > > > > I would prefer to wait for your review. Is that okay? > > Yes. I will review v2. I have reviewed v2. Since compiler errors exist, I can't build this patchset with sparse/smatch locally. Please do it yourself before sending v3. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-06-16 3:15 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <663044d3-0816-4b1b-874d-776835e774e9@gmail.com>
2025-06-10 11:55 ` [PATCH rtw-next v2 14/14] wifi: rtw89: Enable the new USB modules kernel test robot
2025-06-10 13:33 ` Bitterblue Smith
2025-06-11 0:32 ` Ping-Ke Shih
2025-06-11 0:33 ` Ping-Ke Shih
2025-06-11 12:37 ` Bitterblue Smith
2025-06-12 1:27 ` Ping-Ke Shih
2025-06-16 3:15 ` Ping-Ke Shih
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).