From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A27691547E4 for ; Sun, 10 Nov 2024 11:59:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731239976; cv=none; b=Sr8SLhP5Ok8q00Smx5pfoTT+pBLhOXHgCZ9d7tTAgp2i4/ZExXPObjLjoGNXYMyVj8HMC0IKRIjRIqYUPd8Zpn+86biDWMiZ6xuNbFz9g/QW++JkRLYqKarOmBIZIEBd8quyoLqN8rzx6npPImDsksxHfVHf4nYGH0DzSjVX5Ys= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731239976; c=relaxed/simple; bh=zfgHxG2V7R6MBYczHFOAGh8VsRb1hk8pspj/yDEss10=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DKf/jq2+VYbSwSzK4LNl4wErS+TcxUeEMMawrsMC2vx9zdOzm3DSOagMvAAINNqdNSyBX06G25ZRzhqfr5C9B6LASFOtx4e3Shax5AcFva0zPf+mGZlhFpX5XckwqUDB7MbCjQ28Cy7bjF1iHgwCK2U5DdJk2+iUKAO7G1Gj85s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dnpZRdPx; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dnpZRdPx" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4315f24a6bbso27959145e9.1 for ; Sun, 10 Nov 2024 03:59:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731239973; x=1731844773; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=yFaKqABtVje41PveytIEZx/xFmb5usiiYyWy+vMnsAA=; b=dnpZRdPxiAMAoMW41sSYzLXqIng19TAhRgpUlm4BKlVVRafPt+RnheBXKu/NX+dcC6 ct2tmIa64zJa/hthDNyh3G2SQ/XtFYzklQr5Aw89z4NDCQugO4o/5tArV2HsjAFFhGxB BMlfnADbbLuM2g4n+eUtKoo26b1MpUkCbyHKPpZiVGayElTQwNNqlBtCGDT4es+nuhb/ a2fhaos21icUSe+FcrIU91tiLmb20BbzZ6lry1IgV2a4p8JbHzNWB3uS/Ukg0G8PJ3a2 pLqjQjnkfiTBroaBqeVi0nWCOSy3ME0Mf9Nj4pXVI5xe/48z/8QvdoMVnzWhm4VwX+WD +RAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731239973; x=1731844773; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yFaKqABtVje41PveytIEZx/xFmb5usiiYyWy+vMnsAA=; b=aOU4cZmPMxow0kHukQzo/lxcHj8naRC42LGyytiKia73iNajWRBh7tDs2bzhAoFNG5 1/wKYtmAfJRC1fDMALG44Chczr1GQmaB7NF0NjWNixWhc8xB7osVuVDRle5VTiU3b4L8 CaBZSn7L+X8XLeL1A05zeU6GIy+P4Nn0EOGx96x+26aK3lDnb5vLmvcSPC/VfLZTNVOc YACIHOsnvl+CMZn3QGl8Ek7za5YDnznAY+23TU2fcyTak14Z5nbPVEXp10bmjiHbDC7J 00pXILFn7kbgtUdhjuSourj6sQn9a8B5TDiELMO3wpTj9xW8RGNGwqQeGKlOSuHAOSwI xaEw== X-Forwarded-Encrypted: i=1; AJvYcCV5/CEZjkBy60GqgFyc++ECPxh9OgSP96fwhYM0uWMKGhfUXSsOz2rGQvmuLxpkVVDUP9/P@lists.linux.dev X-Gm-Message-State: AOJu0Yw8pqBYyn1ep3qxNI2GS6z6+88RrPM11ofiGgb/ablyFvPwVsi9 wulP1NhqdXCHl5f2J6yG4zNUSMApecQpuXygDROSGiHOF6OaW2ij X-Google-Smtp-Source: AGHT+IE+w+f1yqAk37VzarCVULMGirAo8M7q+uexJAXDVO4xf99ztjU27W78o86exqp0sU3HrqQqpQ== X-Received: by 2002:a05:6000:402c:b0:37c:d183:a8f8 with SMTP id ffacd0b85a97d-381f186b35bmr6512046f8f.19.1731239972786; Sun, 10 Nov 2024 03:59:32 -0800 (PST) Received: from Ansuel-XPS. (93-34-91-161.ip49.fastwebnet.it. [93.34.91.161]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432aa74abb9sm179621495e9.42.2024.11.10.03.59.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Nov 2024 03:59:32 -0800 (PST) Message-ID: <6730a024.050a0220.17c784.0c41@mx.google.com> X-Google-Original-Message-ID: Date: Sun, 10 Nov 2024 12:59:29 +0100 From: Christian Marangi To: Herbert Xu Cc: "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Antoine Tenart , Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, upstream@airoha.com, Richard van Schagen Subject: Re: [PATCH v6 3/3] crypto: Add Mediatek EIP-93 crypto engine support References: <20241102175045.10408-1-ansuelsmth@gmail.com> <20241102175045.10408-3-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, Nov 10, 2024 at 11:46:24AM +0800, Herbert Xu wrote: > On Sat, Nov 02, 2024 at 06:50:35PM +0100, Christian Marangi wrote: > > > > +static int eip93_hash_import(struct ahash_request *req, const void *in) > > +{ > > + struct eip93_hash_reqctx *rctx = ahash_request_ctx(req); > > + const struct eip93_hash_export_state *state = in; > > + int ret; > > + > > + ret = _eip93_hash_init(req, state->sa_state, state->sa_state_base); > > You cannot export/import any kernel pointers. The state is meant > to be a serialised version of the hash state. > > So state->sa_state_base has got to go. > Hoped it was OK since it greatly simplify the logic but OK will do this change. -- Ansuel