From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF8B414372D; Thu, 30 May 2024 08:33:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717057989; cv=none; b=EmF4Ll8arauAJOoL/Kko4V7bZDHqV+qaSkMXwZ4TIuZt57VwwpgzxC//ycw69iEHqlYh+PdntAwf/YsCK74qPs9ylJPpMZZ8T/tDuvTcFn4kJef0d8HSpxM0jbVPzYEIEl9OkqrmZ6Pbg2Jqcy7Dqe0rY4yue7TYc6/p8B1cHxg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717057989; c=relaxed/simple; bh=Lh0EiR8MsmykjlpKs06/3Ea3aRQO385pIfW9SimWnAg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ea5lXXaamIrBS7ZVDeRU7HSWhVYN9a9a6tURbTqMMvIsxag57MymvIZkb6ADnU0ZOjv3TWmnZDqASmgK2BsskGls9cW4S3UcySpS9VZh4UBOsoqk4sf+OFEEMMmC+Se7FZcUq//+0x1US3g1/tDNItODmVLaQuRdR4/uZUvkyjQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-52b7fcd1db4so269825e87.3; Thu, 30 May 2024 01:33:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717057986; x=1717662786; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=P08idekIOg20mZIarxRKyXgHpULyinHaFcyaYJ01jjM=; b=qVEu+44wIxMP3Vj4/lFspJOp1ZMocoOKHvw74vEeEV/08IEUL43ujqoy9vechIY2ju b1W1qtjxFY7DPwlgpIf7H3rBjppJGYXvcgicSKBj/sgB1Hk7vQOJph0BdgY3jpaySFGK 4m5tjUtD9Sy7cvGDNPYg5FdZ0ofgxCgR6OJGUsIxWk+lc/A3jA5hSWvNpsFVRG967P0g 7IG9mTPfZTmdyvsVwFHeUNv8orobAs3iTD8b8qlTGIBB39/iaBZjFoQgpbTF+j1JQhIU t9KoyfBpDrb+V1FLEoRhPIeDkimVAwsv/UYhWKw2JL3YEdWGeBLtEkHc44X5xTFj9iKl MPfg== X-Forwarded-Encrypted: i=1; AJvYcCUoW6FKTmksjAh3elilK3Mvd6V050pZyTvG+9WIdRxKv4B8hUuqztfKZJGPouxoNrhtxJ9KD5mxaxw81NTcWp9WMoUBSvwXmVWZUrMrSQNGFL9ERJpXJPhgvi2SmrUxCTrQCAiQjSBRcidRNgEcZSnIUKc= X-Gm-Message-State: AOJu0YyzVm/fSpZLr0mVfuAbN75sSbmgCWHB+H2KmLpXRU7trpqppT0F VnMGcz8F4ZAKo/joc8oOe1uIPTVbVMjfspnHw4/UsnicnvjxhKX2 X-Google-Smtp-Source: AGHT+IF4HO8WkpganMOJCdBH7V8iwOAnUumE3Ekt6DwpuB6tfpjJzjPSXyKJMzGQmQKHNUMBfqb5bg== X-Received: by 2002:ac2:5286:0:b0:51e:2282:63cf with SMTP id 2adb3069b0e04-52b7d46a259mr789449e87.45.1717057985739; Thu, 30 May 2024 01:33:05 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:69? ([2a0b:e7c0:0:107::aaaa:69]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35579d7de7esm16625872f8f.14.2024.05.30.01.33.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 May 2024 01:33:04 -0700 (PDT) Message-ID: <68293959-9141-4184-a436-ea67efa9aa7c@kernel.org> Date: Thu, 30 May 2024 10:33:03 +0200 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tty: mxser: Remove __counted_by from mxser_board.ports[] To: "Gustavo A. R. Silva" , Greg Kroah-Hartman , Nathan Chancellor Cc: Kees Cook , "Gustavo A. R. Silva" , Bill Wendling , Justin Stitt , linux-serial@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-hardening@vger.kernel.org, llvm@lists.linux.dev, patches@lists.linux.dev, stable@vger.kernel.org References: <20240529-drop-counted-by-ports-mxser-board-v1-1-0ab217f4da6d@kernel.org> <2024053008-sadly-skydiver-92be@gregkh> <09445a96-4f86-4d34-9984-4769bd6f4bc1@embeddedor.com> Content-Language: en-US From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <09445a96-4f86-4d34-9984-4769bd6f4bc1@embeddedor.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 30. 05. 24, 10:12, Gustavo A. R. Silva wrote: > > > On 30/05/24 09:40, Greg Kroah-Hartman wrote: >> On Thu, May 30, 2024 at 08:22:03AM +0200, Jiri Slaby wrote: >>>>   This will be an error in a future compiler version >>>> [-Werror,-Wbounds-safety-counted-by-elt-type-unknown-size] >>>>       291 |         struct mxser_port ports[] __counted_by(nports); >>>>           |         ^~~~~~~~~~~~~~~~~~~~~~~~~ >>>>     1 error generated. >>>> >>>> Remove this use of __counted_by to fix the warning/error. However, >>>> rather than remove it altogether, leave it commented, as it may be >>>> possible to support this in future compiler releases. >>> >>> This looks like a compiler bug/deficiency. >> >> I agree, why not just turn that option off in the compiler so that these >> "warnings" will not show up? > > It's not a compiler bug. It is, provided the code compiles and runs. > The flexible array is nested four struct layers deep, see: > > ports[].port.buf.sentinel.data[] > > The error report could be more specific, though. Ah, ok. The assumption is sentinel.data[] shall be unused. That's why it all works. The size is well known, [] is zero size, right? Still, fix the compiler, not the code. thanks, -- js suse labs