From: John Hubbard <jhubbard@nvidia.com>
To: Shuah Khan <skhan@linuxfoundation.org>, Shuah Khan <shuah@kernel.org>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Darren Hart" <dvhart@infradead.org>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"Edward Liaw" <edliaw@google.com>,
"André Almeida" <andrealmeid@igalia.com>,
"Nysal Jan K . A" <nysal@linux.ibm.com>,
"Mark Brown" <broonie@kernel.org>,
"Valentin Obst" <kernel@valentinobst.de>,
linux-kselftest@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
llvm@lists.linux.dev
Subject: Re: [PATCH v2 1/3] selftests/futex: don't redefine .PHONY targets (all, clean)
Date: Thu, 30 May 2024 14:14:43 -0700 [thread overview]
Message-ID: <6bca860d-2189-40a8-9588-11edd3b3840e@nvidia.com> (raw)
In-Reply-To: <3db9068e-9f95-4ad9-86fa-e24b06da8828@linuxfoundation.org>
On 5/30/24 2:12 PM, Shuah Khan wrote:
> On 5/30/24 13:13, John Hubbard wrote:
>> On 5/30/24 12:03 PM, Shuah Khan wrote:
>>> On 5/28/24 20:29, John Hubbard wrote:
>>>> The .PHONY targets "all" and "clean" are both defined in the file that
>>>> is included in the very next line: ../lib.mk.
>>>>
>>>
>>> What problems are you seeing without this patch?
>>
>> Code duplication. It's a sin. :)
>
> Please mention that you are removing duplicate code.
>
> futex Makefile overrides CLEAN - just making sure it
(Overrides of Makefile things are per-item, so to speak, not per
file, just to be clear.)
> does the cleanup correctly.
>
OK sure, I'll update the commit message and post a v3, coming soon.
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2024-05-30 21:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 2:29 [PATCH v2 0/3] selftests/futex: clang-inspired fixes John Hubbard
2024-05-29 2:29 ` [PATCH v2 1/3] selftests/futex: don't redefine .PHONY targets (all, clean) John Hubbard
2024-05-30 19:03 ` Shuah Khan
2024-05-30 19:13 ` John Hubbard
2024-05-30 21:12 ` Shuah Khan
2024-05-30 21:14 ` John Hubbard [this message]
2024-05-29 2:29 ` [PATCH v2 2/3] selftests/futex: don't pass a const char* to asprintf(3) John Hubbard
2024-05-30 19:04 ` Shuah Khan
2024-05-30 19:16 ` John Hubbard
2024-05-30 21:13 ` Shuah Khan
2024-05-30 21:15 ` John Hubbard
2024-05-29 2:29 ` [PATCH v2 3/3] selftests/futex: pass _GNU_SOURCE without a value to the compiler John Hubbard
2024-05-30 19:07 ` Shuah Khan
2024-05-30 14:23 ` [PATCH v2 0/3] selftests/futex: clang-inspired fixes Shuah Khan
2024-05-30 19:09 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bca860d-2189-40a8-9588-11edd3b3840e@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=andrealmeid@igalia.com \
--cc=broonie@kernel.org \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=edliaw@google.com \
--cc=kernel@valentinobst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mingo@redhat.com \
--cc=nysal@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox