From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92A293A453B for ; Mon, 10 Aug 2026 09:41:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786354920; cv=none; b=I7aJMSFCeo0QhTzz8YFR1y+hgjg1QfCvKURZd3lSrvjW/qlDC3GHVe19ZXVmujZKdKR5OeZwsO2Qz1oC/menJqRAtS/4sUwW0NweRfR23T+FT07IdxPyakmyW1LjmCKiAEG2AArjMI1KxJOPdkPtCuzg+pyt3nxKIq3MxBcAUuo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786354920; c=relaxed/simple; bh=lAlJ21024iVEAiB1omuqDYIS76cnSpFr0AtgmGJNB4k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To: Content-Type:References; b=bp5GsY1wdHMnUhBrwFR3w7/d7DG19FqVUxl72w/Jx5rzudawLn0z9s4d6KQYts1nRcICof2eHjYJgT3/NZxJGJKoBwUqW5pIPFMEWgt5MgjCy0hxKSA7Rp9wqXoR+xx2HJKT2rV29YhXjhAT7IPlLU0SR+HzLuNgLgDj5RSn6HM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=ble4axPc; arc=none smtp.client-ip=210.118.77.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="ble4axPc" Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20260810094154euoutp026efa85bdc4a0978765e42bacd22cf088~KaFSXg1GA1630116301euoutp02G for ; Mon, 10 Aug 2026 09:41:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20260810094154euoutp026efa85bdc4a0978765e42bacd22cf088~KaFSXg1GA1630116301euoutp02G DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1786354914; bh=AmOptGmSSwb48Q3nQS4iFyaNRaAar+3mAWyPKqr/PZc=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=ble4axPczDpJRsTJenkxPmIfVecz+JLi0iHpAR4YcF2TnitaLf9xU89sxJ2AwaBgZ /JMG0I5RUxNOgAqqlbGedKylHLO58WWFx6CUtasFjhL8YGvVKF90lp9KTw8buQj1wm QuYm6V7Vke4seybUzDddIxlxx2jCaqqmquQ/kQvs= Received: from eusmtip2.samsung.com (unknown [203.254.199.222]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20260810094154eucas1p14114a0cb677a4b4da96242f50cae88c0~KaFR42qow0110201102eucas1p1u; Mon, 10 Aug 2026 09:41:54 +0000 (GMT) Received: from [192.168.1.44] (unknown [106.210.136.40]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20260810094153eusmtip22c92126836a048d2e2c83409f520ae1c~KaFQzzhe_0770707707eusmtip2n; Mon, 10 Aug 2026 09:41:53 +0000 (GMT) Message-ID: <7418f71a-cf53-4641-bdf3-e967e776b0a8@samsung.com> Date: Mon, 10 Aug 2026 11:41:52 +0200 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] pwm: th1520: use vertical import style To: Guru Das Srinagesh , Link Mauve , Drew Fustini , Guo Ren , Fu Wei , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?UTF-8?Q?Onur_=C3=96zkan?= , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-riscv@lists.infradead.org, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, llvm@lists.linux.dev Content-Language: en-US From: Michal Wilczynski In-Reply-To: <20260721-pwm-rust-vert-imp-v2-1-9f91547f5e07@gurudas.dev> Content-Transfer-Encoding: 7bit X-CMS-MailID: 20260810094154eucas1p14114a0cb677a4b4da96242f50cae88c0 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20260721074943eucas1p20eaf6768a8a3db90d29a9d45746554ab X-EPHeader: CA X-CMS-RootMailID: 20260721074943eucas1p20eaf6768a8a3db90d29a9d45746554ab References: <20260721-pwm-rust-vert-imp-v2-1-9f91547f5e07@gurudas.dev> Hi, On 7/21/26 09:49, Guru Das Srinagesh wrote: > Convert `use` imports to vertical layout for better readability and > maintainability. > > Signed-off-by: Guru Das Srinagesh > --- > Came across a recent commit bc58905eb07 ("samples: rust_misc_device: use > vertical import style") and found a few more locations that could > benefit from this cleanup. No functional changes. > > Separating out patches per-subsystem as per the review feedback in [0]. > > Tested via: > > $ make LLVM=1 rustfmtcheck || echo "fail" > $ > > [0]: https://lore.kernel.org/lkml/20260628-b4-rust-vertical-imports-v1-0-98bc71d4810b@gurudas.dev/ > --- Looks good to me, Reviewed-by: Michal Wilczynski