From: Michal Orzel <michalorzel.eng@gmail.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] ipc/sem: Remove redundant assignments
Date: Tue, 12 Apr 2022 17:19:25 +0200 [thread overview]
Message-ID: <7d6893a9-01d2-e1ab-06c2-745aa8bcd2b0@gmail.com> (raw)
In-Reply-To: <YlRNmXucZwNasoFq@thelio-3990X>
Hi Nathan,
On 11.04.2022 17:47, Nathan Chancellor wrote:
> Hi Michal,
>
> On Sat, Apr 09, 2022 at 12:19:31PM +0200, Michal Orzel wrote:
>> Get rid of redundant assignments which end up in values not being
>> read either because they are overwritten or the function ends.
>>
>> Reported by clang-tidy [deadcode.DeadStores]
>>
>> Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com>
>
> Thank you for the patch! This should go through Andrew Morton, now CC'd.
>
> For the future, having some history behind the origin of these warnings
> would make review a little easier. I'll comment on each below.
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>
Thanks,
I will keep that in mind when sending other patches fixing static analyzer findings.
Cheers,
Michal
prev parent reply other threads:[~2022-04-12 15:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 10:19 [PATCH] ipc/sem: Remove redundant assignments Michal Orzel
2022-04-09 10:19 ` [PATCH] block: " Michal Orzel
2022-04-09 12:01 ` Tom Rix
2022-04-09 13:20 ` Michal Orzel
2022-04-09 16:03 ` Tom Rix
2022-04-12 15:23 ` Michal Orzel
2022-04-09 11:47 ` [PATCH] ipc/sem: " Tom Rix
2022-04-11 15:47 ` Nathan Chancellor
2022-04-12 15:19 ` Michal Orzel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d6893a9-01d2-e1ab-06c2-745aa8bcd2b0@gmail.com \
--to=michalorzel.eng@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).