From: Tom Lendacky <thomas.lendacky@amd.com>
To: "H. Peter Anvin" <hpa@zytor.com>,
Adam Dunlap <acdunlap@google.com>,
Peter Gonda <pgonda@google.com>
Cc: Sean Christopherson <seanjc@google.com>,
Dave Hansen <dave.hansen@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
the arch/x86 maintainers <x86@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>, Ben Dooks <ben-linux@fluff.org>,
LKML <linux-kernel@vger.kernel.org>,
llvm@lists.linux.dev, Jacob Xu <jacobhxu@google.com>,
Alper Gun <alpergun@google.com>, Marc Orr <marcorr@google.com>
Subject: Re: [PATCH v2 RESEND] x86/asm: Force native_apic_mem_read to use mov
Date: Wed, 5 Oct 2022 08:28:56 -0500 [thread overview]
Message-ID: <81950d38-4d5a-6902-bc2e-327d2800eb58@amd.com> (raw)
In-Reply-To: <B7175642-351D-44A0-B7AD-E69C6B64FC18@zytor.com>
On 10/3/22 18:11, H. Peter Anvin wrote:
> On October 3, 2022 4:01:01 PM PDT, Adam Dunlap <acdunlap@google.com> wrote:
>> Thanks for all the responses. Is the consensus that we should use the
>> readl function here or instead use inline assembly directly as in the patch
>> I originally sent out:
>>
>> asm_inline("movl %1, %0" : "=r"(out) : "m"(*addr));
>>
>> ? The readl function has this exact same code, I'm just not sure
>> which version fits better stylistically.
>
> Is mov with an arbitrary addressing mode still acceptable for whatever is causing this problem?
The acceptable forms of MOV are covered by insn_decode_mmio() in
arch/x86/lib/insn-eval.c.
Thanks,
Tom
next prev parent reply other threads:[~2022-10-05 13:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 18:00 [PATCH] x86/asm: Force native_apic_mem_read to use mov Adam Dunlap
2022-08-11 19:27 ` Sean Christopherson
2022-08-11 19:57 ` H. Peter Anvin
2022-08-11 20:03 ` Sean Christopherson
2022-08-12 4:40 ` H. Peter Anvin
2022-08-12 18:32 ` Adam Dunlap
2022-08-12 18:35 ` [PATCH v2] " Adam Dunlap
2022-09-08 17:04 ` [PATCH v2 RESEND] " Adam Dunlap
2022-09-14 11:13 ` Peter Gonda
2022-09-14 11:59 ` Marc Orr
2022-09-14 11:59 ` Marc Orr
2022-09-15 7:51 ` Tom Lendacky
2022-09-14 12:03 ` Dave Hansen
2022-09-14 16:22 ` Sean Christopherson
2022-09-15 8:09 ` Peter Gonda
[not found] ` <CAMBK9=YB=8EQymDUda300qPFAL1=7dzC61c0pshrWEC5ibrUfQ@mail.gmail.com>
2022-10-03 23:07 ` Adam Dunlap
[not found] ` <B7175642-351D-44A0-B7AD-E69C6B64FC18@zytor.com>
2022-10-05 13:28 ` Tom Lendacky [this message]
2022-11-17 21:23 ` Marc Orr
2023-11-17 18:14 ` Sidharth Telang
2023-11-17 19:23 ` Dave Hansen
2022-08-11 19:53 ` [PATCH] " H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81950d38-4d5a-6902-bc2e-327d2800eb58@amd.com \
--to=thomas.lendacky@amd.com \
--cc=acdunlap@google.com \
--cc=ak@linux.intel.com \
--cc=alpergun@google.com \
--cc=ben-linux@fluff.org \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jacobhxu@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=marcorr@google.com \
--cc=mingo@redhat.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=pgonda@google.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=trix@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox