From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 467601C5D7A; Mon, 10 Feb 2025 10:37:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739183828; cv=none; b=Sc3kWZp0DUMYuULEpxb6Eg4HqRJ9SKHKaGq8kmrqoThBGiP1EI9Jc/LbVBqfUARmdd41P2Zu/e63QfZZO5cGzFnE5DO5Nj91cNeGeMtni3lrMoIcFHPSvpjyfJdsIfI98JsAb4z9HWG2xb/RPCxRg+z5qJA34mThe1ynU1hFKws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739183828; c=relaxed/simple; bh=pG6Tqs286wmBxiyIrD2niNQiQm0sXRVyX326LKA8yac=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=qLRr7Cxhv8UqBywU9POn1o1JBlnC348AVbSZGXqjrqMNDLddm5p+iq+bRzBQET0rIcdyRAj+bLD4hZzniqXLSFYxn+K9IDF9HMMi3Q0zCJRTQikXo7zw5y9tjKNKsP9hW2bqnYJyyuKvjv5Ul+oz3eDgiJzHHSZhjcRez2aIkhQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AGKkoYP5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AGKkoYP5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B843CC4CED1; Mon, 10 Feb 2025 10:37:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739183827; bh=pG6Tqs286wmBxiyIrD2niNQiQm0sXRVyX326LKA8yac=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AGKkoYP5igiaE1J04wDcluloHolkVn+i1DkGIKSRHw/WVHn06EeyuUTTHQFlcTgQy Zm2jZaJJp3/Sb2nPukzabStV9ktJQBSShcHgxRdx/pYdCh0OoQKxX8S1EZDFMbianH nMD0yc6gSeonoa+toHfJEHl62XweOaUvAr89dVAMd9oED8Z9kWvVB3nY/lP0GRChw5 uHKRifwfQbB6Odot3TmdJfSssXjOOSSgB+srR7MWDP04Ss3fKsVhqgWJdKcNjLO9v3 w4MqcV9Oo0HWrsMpLTPvN4MFS9bR1TLSpwvj6TVOnldmhDwp5/ZH1dzSxqsLs+6UlH hJ4EWFlMHmTvA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1thRA1-002VDH-6q; Mon, 10 Feb 2025 10:37:05 +0000 Date: Mon, 10 Feb 2025 10:37:03 +0000 Message-ID: <867c5yt7ao.wl-maz@kernel.org> From: Marc Zyngier To: Quentin Perret Cc: kernel test robot , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvmarm , Oliver Upton Subject: Re: [kvmarm:fixes 18/18] arch/arm64/kvm/hyp/nvhe/mem_protect.c:1086:9: warning: variable 'ret' is uninitialized when used here In-Reply-To: References: <202502100911.8c9DbtKD-lkp@intel.com> <868qqetasm.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: qperret@google.com, lkp@intel.com, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, oliver.upton@linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 10 Feb 2025 09:44:02 +0000, Quentin Perret wrote: > > On Monday 10 Feb 2025 at 09:21:29 (+0000), Marc Zyngier wrote: > > On Mon, 10 Feb 2025 01:39:04 +0000, > > kernel test robot wrote: > > > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git fixes > > > head: eabc7aaef7a553b64bf6e631ce04526af6c8d104 > > > commit: eabc7aaef7a553b64bf6e631ce04526af6c8d104 [18/18] KVM: arm64: Simplify np-guest hypercalls > > > config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20250210/202502100911.8c9DbtKD-lkp@intel.com/config) > > > compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff) > > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250210/202502100911.8c9DbtKD-lkp@intel.com/reproduce) > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > > the same patch/commit), kindly add following tags > > > | Reported-by: kernel test robot > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202502100911.8c9DbtKD-lkp@intel.com/ > > > > > > All warnings (new ones prefixed by >>): > > > > > > >> arch/arm64/kvm/hyp/nvhe/mem_protect.c:1086:9: warning: variable 'ret' is uninitialized when used here [-Wuninitialized] > > > 1086 | return ret; > > > | ^~~ > > > arch/arm64/kvm/hyp/nvhe/mem_protect.c:1076:9: note: initialize the variable 'ret' to silence this warning > > > 1076 | int ret; > > > | ^ > > > | = 0 > > > 1 warning generated. > > > > Nice catch. I wish the compiler would warn for these by default... > > So do I... > > > Quentin, are you happy with the following patch that I can stash on > > top of the current set of fixes? > > Absolutely, thanks for the patch and sorry the mess! > > Reviewed-by: Quentin Perret Now queued and pushed out. LKP people: please fix the mailing address you are using, as it changed over two years ago, and you're still using the old one. Thanks, M. -- Without deviation from the norm, progress is not possible.