From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25025145B34 for ; Thu, 18 Apr 2024 13:01:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=150.107.74.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713445299; cv=none; b=NKCs3HBYMmLEtVq1w+oFPc3OKPBoGMDK04Kj37MAdXAy8LC9VOnApS3b6Jy0RVMLtWjo9U5KqEuLuGZ7bGy8PIRQczX1aehwYjUW4C5Ynnf/6Gy1vVqlZQV639OVpq2Z5u2V7VmUOYHuhRMHmGUy0g41EF0wgY3udY58zr+dMo8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713445299; c=relaxed/simple; bh=/XJcPlw0F03P3amsg0KmHILuo/lC6Cw5M2DfUOpYyuc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Bd5qFzFoIMWba6AQhhd9I+b5igxeqJInaAgN9/CGa2J7AcjvTOjqqOk3bl7hxJlAz50aduyZI2ahlV7FOKTORtVFU1jxiUj6zat6OG5vso2DyM0j9nHOx9xH1qBRvPqAfdPitm/MPdmf2zNl4W5UNlol6MyWx+OxbuOYN2qgIds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au; spf=pass smtp.mailfrom=ellerman.id.au; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b=q9TFzCh7; arc=none smtp.client-ip=150.107.74.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ellerman.id.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="q9TFzCh7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1713445289; bh=vNeZ/qdX3LOH0LHZJhAOcqMpEwfgHMqhf2DU3H1Xszg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=q9TFzCh7EhJg+m9fj6qudX6Ks+Uct3uWBknTCV37uU8cbakd81QmCpmVRG0NOIxQ5 uNQKi+KMBjdkP9ELAPneTQiXG4RWeLhPSORHg+e8+iojKQsMo6Vww7EZd4Vo8nYxXj i9C+ou7rNcmrbkiJh9KKLdHzBGmSWTBXLplv230qwENBOzJZa0EmJhDvcx7MlY6f+x Kxij9OwVQI817aMiTT0xC/Q13B2je9ictqe0EMnSezFUNR9C4h+0VWvJD9vykrSyNe Xx2VRrYHX09AAOcTymVN0OEteduzRVIKXU3HOEjff+X4D+7mpxgl26SJk8w/e/NwSp b5yKqkqbp1D7w== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4VKyZw5zyrz4wyx; Thu, 18 Apr 2024 23:01:28 +1000 (AEST) From: Michael Ellerman To: Arnd Bergmann , Arnd Bergmann Cc: Naresh Kamboju , linux-kernel@vger.kernel.org, linuxppc-dev , "Aneesh Kumar K . V" , Anders Roxell , Kees Cook , Niklas Schnelle , clang-built-linux , Nick Desaulniers , Nathan Chancellor , Jeff Xu , "Naveen N. Rao" , Dan Carpenter , Nicholas Piggin , Christophe Leroy , Bill Wendling , Justin Stitt , Baoquan He , Mike Rapoport Subject: Re: [PATCH] powerpc: drop port I/O helpers for CONFIG_HAS_IOPORT=n In-Reply-To: <59473eb6-1707-4bbf-85a3-ba4835f3ee7f@app.fastmail.com> References: <20240416153331.1617772-1-arnd@kernel.org> <878r1bb2zj.fsf@mail.lhotse> <59473eb6-1707-4bbf-85a3-ba4835f3ee7f@app.fastmail.com> Date: Thu, 18 Apr 2024 23:01:25 +1000 Message-ID: <8734ribza2.fsf@mail.lhotse> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain "Arnd Bergmann" writes: > On Thu, Apr 18, 2024, at 08:26, Michael Ellerman wrote: >> Arnd Bergmann writes: > >> @@ -692,6 +692,7 @@ static inline void name at >> \ >> #define writesw writesw >> #define writesl writesl >> >> +#ifdef CONFIG_HAS_IOPORT >> #define inb inb >> #define inw inw >> #define inl inl >> @@ -704,6 +705,8 @@ static inline void name at >> \ >> #define outsb outsb >> #define outsw outsw >> #define outsl outsl >> +#endif // CONFIG_HAS_IOPORT >> + >> #ifdef __powerpc64__ >> #define readq readq >> #define writeq writeq > > I had included this at first, but then I still ran into > the same warnings because it ends up pulling in the > generic outsb() etc from include/asm-generic/io.h > that relies on setting a non-NULL PCI_IOBASE. Yes you're right. The above fixes the gcc build, but not clang. So I think I'll just cherry pick f0a816fb12da ("/dev/port: don't compile file operations without CONFIG_DEVPORT") into my next and then apply this. But will see if there's any other build failures over night. cheers