* Re: [PATCH v2 6/9] KVM: arm64: Detect and handle hypervisor stack overflows
[not found] <20220222165212.2005066-7-kaleshsingh@google.com>
@ 2022-02-23 9:05 ` kernel test robot
2022-02-23 9:16 ` Marc Zyngier
0 siblings, 1 reply; 10+ messages in thread
From: kernel test robot @ 2022-02-23 9:05 UTC (permalink / raw)
To: Kalesh Singh
Cc: llvm, kbuild-all, will, maz, qperret, tabba, surenb, kernel-team,
Kalesh Singh, Catalin Marinas, James Morse, Alexandru Elisei,
Suzuki K Poulose, Ard Biesheuvel, Mark Rutland, Pasha Tatashin,
Joey Gouly, Peter Collingbourne, Andrew Scull, Paolo Bonzini,
Zenghui Yu, linux-arm-kernel, linux-kernel, kvmarm
Hi Kalesh,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on cfb92440ee71adcc2105b0890bb01ac3cddb8507]
url: https://github.com/0day-ci/linux/commits/Kalesh-Singh/KVM-arm64-Hypervisor-stack-enhancements/20220223-010522
base: cfb92440ee71adcc2105b0890bb01ac3cddb8507
config: arm64-randconfig-r011-20220221 (https://download.01.org/0day-ci/archive/20220223/202202231727.L621fVgD-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/7fe99fd40f7c4b2973218045ca5b9c9160524db1
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kalesh-Singh/KVM-arm64-Hypervisor-stack-enhancements/20220223-010522
git checkout 7fe99fd40f7c4b2973218045ca5b9c9160524db1
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
#define NULL ((void *)0)
^~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/switch.c:200:27: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_FP_ASIMD] = kvm_hyp_handle_fpsimd,
^~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/switch.c:196:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = NULL,
^~~~
include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
#define NULL ((void *)0)
^~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/switch.c:201:27: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_IABT_LOW] = kvm_hyp_handle_iabt_low,
^~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/switch.c:196:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = NULL,
^~~~
include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
#define NULL ((void *)0)
^~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/switch.c:202:27: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_DABT_LOW] = kvm_hyp_handle_dabt_low,
^~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/switch.c:196:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = NULL,
^~~~
include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
#define NULL ((void *)0)
^~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/switch.c:203:22: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_PAC] = kvm_hyp_handle_ptrauth,
^~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/switch.c:196:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = NULL,
^~~~
include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
#define NULL ((void *)0)
^~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/switch.c:208:24: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_SYS64] = kvm_handle_pvm_sys64,
^~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/switch.c:207:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = NULL,
^~~~
include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
#define NULL ((void *)0)
^~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/switch.c:209:22: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_SVE] = kvm_handle_pvm_restricted,
^~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/switch.c:207:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = NULL,
^~~~
include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
#define NULL ((void *)0)
^~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/switch.c:210:27: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_FP_ASIMD] = kvm_handle_pvm_fpsimd,
^~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/switch.c:207:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = NULL,
^~~~
include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
#define NULL ((void *)0)
^~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/switch.c:211:27: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_IABT_LOW] = kvm_hyp_handle_iabt_low,
^~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/switch.c:207:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = NULL,
^~~~
include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
#define NULL ((void *)0)
^~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/switch.c:212:27: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_DABT_LOW] = kvm_hyp_handle_dabt_low,
^~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/switch.c:207:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = NULL,
^~~~
include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
#define NULL ((void *)0)
^~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/switch.c:213:22: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_PAC] = kvm_hyp_handle_ptrauth,
^~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/switch.c:207:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = NULL,
^~~~
include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
#define NULL ((void *)0)
^~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/switch.c:350:17: warning: no previous prototype for function 'hyp_panic' [-Wmissing-prototypes]
void __noreturn hyp_panic(void)
^
arch/arm64/kvm/hyp/nvhe/switch.c:350:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void __noreturn hyp_panic(void)
^
static
>> arch/arm64/kvm/hyp/nvhe/switch.c:372:17: warning: no previous prototype for function 'hyp_panic_bad_stack' [-Wmissing-prototypes]
void __noreturn hyp_panic_bad_stack(void)
^
arch/arm64/kvm/hyp/nvhe/switch.c:372:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void __noreturn hyp_panic_bad_stack(void)
^
static
arch/arm64/kvm/hyp/nvhe/switch.c:377:17: warning: no previous prototype for function 'kvm_unexpected_el2_exception' [-Wmissing-prototypes]
asmlinkage void kvm_unexpected_el2_exception(void)
^
arch/arm64/kvm/hyp/nvhe/switch.c:377:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
asmlinkage void kvm_unexpected_el2_exception(void)
^
static
16 warnings generated.
vim +/hyp_panic_bad_stack +372 arch/arm64/kvm/hyp/nvhe/switch.c
371
> 372 void __noreturn hyp_panic_bad_stack(void)
373 {
374 hyp_panic();
375 }
376
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 6/9] KVM: arm64: Detect and handle hypervisor stack overflows
2022-02-23 9:05 ` [PATCH v2 6/9] KVM: arm64: Detect and handle hypervisor stack overflows kernel test robot
@ 2022-02-23 9:16 ` Marc Zyngier
2022-02-23 12:34 ` [kbuild-all] " Philip Li
0 siblings, 1 reply; 10+ messages in thread
From: Marc Zyngier @ 2022-02-23 9:16 UTC (permalink / raw)
To: Kalesh Singh, kernel test robot
Cc: llvm, kbuild-all, will, qperret, tabba, surenb, kernel-team,
Catalin Marinas, James Morse, Alexandru Elisei, Suzuki K Poulose,
Ard Biesheuvel, Mark Rutland, Pasha Tatashin, Joey Gouly,
Peter Collingbourne, Andrew Scull, Paolo Bonzini, Zenghui Yu,
linux-arm-kernel, linux-kernel, kvmarm
On Wed, 23 Feb 2022 09:05:18 +0000,
kernel test robot <lkp@intel.com> wrote:
>
> Hi Kalesh,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on cfb92440ee71adcc2105b0890bb01ac3cddb8507]
>
> url: https://github.com/0day-ci/linux/commits/Kalesh-Singh/KVM-arm64-Hypervisor-stack-enhancements/20220223-010522
> base: cfb92440ee71adcc2105b0890bb01ac3cddb8507
> config: arm64-randconfig-r011-20220221 (https://download.01.org/0day-ci/archive/20220223/202202231727.L621fVgD-lkp@intel.com/config)
> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install arm64 cross compiling tool for clang build
> # apt-get install binutils-aarch64-linux-gnu
> # https://github.com/0day-ci/linux/commit/7fe99fd40f7c4b2973218045ca5b9c9160524db1
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Kalesh-Singh/KVM-arm64-Hypervisor-stack-enhancements/20220223-010522
> git checkout 7fe99fd40f7c4b2973218045ca5b9c9160524db1
> # save the config file to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
> #define NULL ((void *)0)
> ^~~~~~~~~~~
> arch/arm64/kvm/hyp/nvhe/switch.c:200:27: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
> [ESR_ELx_EC_FP_ASIMD] = kvm_hyp_handle_fpsimd,
> ^~~~~~~~~~~~~~~~~~~~~
> arch/arm64/kvm/hyp/nvhe/switch.c:196:28: note: previous initialization is here
> [0 ... ESR_ELx_EC_MAX] = NULL,
> ^~~~
> include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
> #define NULL ((void *)0)
> ^~~~~~~~~~~
Kalesh, please ignore this nonsense. There may be things to improve,
but this is *NOT* one of them.
These reports are pretty useless, and just lead people to ignore real
bug reports.
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [kbuild-all] Re: [PATCH v2 6/9] KVM: arm64: Detect and handle hypervisor stack overflows
2022-02-23 9:16 ` Marc Zyngier
@ 2022-02-23 12:34 ` Philip Li
2022-02-23 12:54 ` Marc Zyngier
0 siblings, 1 reply; 10+ messages in thread
From: Philip Li @ 2022-02-23 12:34 UTC (permalink / raw)
To: Marc Zyngier
Cc: Kalesh Singh, kernel test robot, llvm, kbuild-all, will, qperret,
tabba, surenb, kernel-team, Catalin Marinas, James Morse,
Alexandru Elisei, Suzuki K Poulose, Ard Biesheuvel, Mark Rutland,
Pasha Tatashin, Joey Gouly, Peter Collingbourne, Andrew Scull,
Paolo Bonzini, Zenghui Yu, linux-arm-kernel, linux-kernel, kvmarm
On Wed, Feb 23, 2022 at 09:16:59AM +0000, Marc Zyngier wrote:
> On Wed, 23 Feb 2022 09:05:18 +0000,
> kernel test robot <lkp@intel.com> wrote:
> >
> > Hi Kalesh,
> >
> > Thank you for the patch! Perhaps something to improve:
> >
> > [auto build test WARNING on cfb92440ee71adcc2105b0890bb01ac3cddb8507]
> >
> > url: https://github.com/0day-ci/linux/commits/Kalesh-Singh/KVM-arm64-Hypervisor-stack-enhancements/20220223-010522
> > base: cfb92440ee71adcc2105b0890bb01ac3cddb8507
> > config: arm64-randconfig-r011-20220221 (https://download.01.org/0day-ci/archive/20220223/202202231727.L621fVgD-lkp@intel.com/config)
> > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # install arm64 cross compiling tool for clang build
> > # apt-get install binutils-aarch64-linux-gnu
> > # https://github.com/0day-ci/linux/commit/7fe99fd40f7c4b2973218045ca5b9c9160524db1
> > git remote add linux-review https://github.com/0day-ci/linux
> > git fetch --no-tags linux-review Kalesh-Singh/KVM-arm64-Hypervisor-stack-enhancements/20220223-010522
> > git checkout 7fe99fd40f7c4b2973218045ca5b9c9160524db1
> > # save the config file to linux build tree
> > mkdir build_dir
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> > include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
> > #define NULL ((void *)0)
> > ^~~~~~~~~~~
> > arch/arm64/kvm/hyp/nvhe/switch.c:200:27: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
> > [ESR_ELx_EC_FP_ASIMD] = kvm_hyp_handle_fpsimd,
> > ^~~~~~~~~~~~~~~~~~~~~
> > arch/arm64/kvm/hyp/nvhe/switch.c:196:28: note: previous initialization is here
> > [0 ... ESR_ELx_EC_MAX] = NULL,
> > ^~~~
> > include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
> > #define NULL ((void *)0)
> > ^~~~~~~~~~~
>
> Kalesh, please ignore this nonsense. There may be things to improve,
> but this is *NOT* one of them.
>
> These reports are pretty useless, and just lead people to ignore real
> bug reports.
Hi Kalesh, sorry there're some irrelevant issues mixed in the report,
kindly ignore them. And the valuable ones are the new ones that
prefixed by >>, as the below one in original report.
>> arch/arm64/kvm/hyp/nvhe/switch.c:372:17: warning: no previous prototype for function 'hyp_panic_bad_stack' [-Wmissing-prototypes]
void __noreturn hyp_panic_bad_stack(void)
^
Thanks
>
> M.
>
> --
> Without deviation from the norm, progress is not possible.
> _______________________________________________
> kbuild-all mailing list -- kbuild-all@lists.01.org
> To unsubscribe send an email to kbuild-all-leave@lists.01.org
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [kbuild-all] Re: [PATCH v2 6/9] KVM: arm64: Detect and handle hypervisor stack overflows
2022-02-23 12:34 ` [kbuild-all] " Philip Li
@ 2022-02-23 12:54 ` Marc Zyngier
2022-02-23 12:56 ` Ard Biesheuvel
0 siblings, 1 reply; 10+ messages in thread
From: Marc Zyngier @ 2022-02-23 12:54 UTC (permalink / raw)
To: Philip Li
Cc: Kalesh Singh, kernel test robot, llvm, kbuild-all, will, qperret,
tabba, surenb, kernel-team, Catalin Marinas, James Morse,
Alexandru Elisei, Suzuki K Poulose, Ard Biesheuvel, Mark Rutland,
Pasha Tatashin, Joey Gouly, Peter Collingbourne, Andrew Scull,
Paolo Bonzini, Zenghui Yu, linux-arm-kernel, linux-kernel, kvmarm
On 2022-02-23 12:34, Philip Li wrote:
> On Wed, Feb 23, 2022 at 09:16:59AM +0000, Marc Zyngier wrote:
>> On Wed, 23 Feb 2022 09:05:18 +0000,
>> kernel test robot <lkp@intel.com> wrote:
>> >
>> > Hi Kalesh,
>> >
>> > Thank you for the patch! Perhaps something to improve:
>> >
>> > [auto build test WARNING on cfb92440ee71adcc2105b0890bb01ac3cddb8507]
>> >
>> > url: https://github.com/0day-ci/linux/commits/Kalesh-Singh/KVM-arm64-Hypervisor-stack-enhancements/20220223-010522
>> > base: cfb92440ee71adcc2105b0890bb01ac3cddb8507
>> > config: arm64-randconfig-r011-20220221 (https://download.01.org/0day-ci/archive/20220223/202202231727.L621fVgD-lkp@intel.com/config)
>> > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
>> > reproduce (this is a W=1 build):
>> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>> > chmod +x ~/bin/make.cross
>> > # install arm64 cross compiling tool for clang build
>> > # apt-get install binutils-aarch64-linux-gnu
>> > # https://github.com/0day-ci/linux/commit/7fe99fd40f7c4b2973218045ca5b9c9160524db1
>> > git remote add linux-review https://github.com/0day-ci/linux
>> > git fetch --no-tags linux-review Kalesh-Singh/KVM-arm64-Hypervisor-stack-enhancements/20220223-010522
>> > git checkout 7fe99fd40f7c4b2973218045ca5b9c9160524db1
>> > # save the config file to linux build tree
>> > mkdir build_dir
>> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/
>> >
>> > If you fix the issue, kindly add following tag as appropriate
>> > Reported-by: kernel test robot <lkp@intel.com>
>> >
>> > All warnings (new ones prefixed by >>):
>> >
>> > include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
>> > #define NULL ((void *)0)
>> > ^~~~~~~~~~~
>> > arch/arm64/kvm/hyp/nvhe/switch.c:200:27: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
>> > [ESR_ELx_EC_FP_ASIMD] = kvm_hyp_handle_fpsimd,
>> > ^~~~~~~~~~~~~~~~~~~~~
>> > arch/arm64/kvm/hyp/nvhe/switch.c:196:28: note: previous initialization is here
>> > [0 ... ESR_ELx_EC_MAX] = NULL,
>> > ^~~~
>> > include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
>> > #define NULL ((void *)0)
>> > ^~~~~~~~~~~
>>
>> Kalesh, please ignore this nonsense. There may be things to improve,
>> but this is *NOT* one of them.
>>
>> These reports are pretty useless, and just lead people to ignore real
>> bug reports.
>
> Hi Kalesh, sorry there're some irrelevant issues mixed in the report,
> kindly ignore them. And the valuable ones are the new ones that
> prefixed by >>, as the below one in original report.
>
>>> arch/arm64/kvm/hyp/nvhe/switch.c:372:17: warning: no previous
>>> prototype for function 'hyp_panic_bad_stack' [-Wmissing-prototypes]
> void __noreturn hyp_panic_bad_stack(void)
> ^
This is only called from assembly code, so a prototype wouldn't bring
much.
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [kbuild-all] Re: [PATCH v2 6/9] KVM: arm64: Detect and handle hypervisor stack overflows
2022-02-23 12:54 ` Marc Zyngier
@ 2022-02-23 12:56 ` Ard Biesheuvel
2022-02-24 10:39 ` Marc Zyngier
0 siblings, 1 reply; 10+ messages in thread
From: Ard Biesheuvel @ 2022-02-23 12:56 UTC (permalink / raw)
To: Marc Zyngier
Cc: Philip Li, Kalesh Singh, kernel test robot, llvm, kbuild-all,
Will Deacon, Quentin Perret, Fuad Tabba, surenb,
Android Kernel Team, Catalin Marinas, James Morse,
Alexandru Elisei, Suzuki K Poulose, Mark Rutland, Pasha Tatashin,
Joey Gouly, Peter Collingbourne, Andrew Scull, Paolo Bonzini,
Zenghui Yu, Linux ARM, Linux Kernel Mailing List, kvmarm
On Wed, 23 Feb 2022 at 13:54, Marc Zyngier <maz@kernel.org> wrote:
>
> On 2022-02-23 12:34, Philip Li wrote:
> > On Wed, Feb 23, 2022 at 09:16:59AM +0000, Marc Zyngier wrote:
> >> On Wed, 23 Feb 2022 09:05:18 +0000,
> >> kernel test robot <lkp@intel.com> wrote:
> >> >
> >> > Hi Kalesh,
> >> >
> >> > Thank you for the patch! Perhaps something to improve:
> >> >
> >> > [auto build test WARNING on cfb92440ee71adcc2105b0890bb01ac3cddb8507]
> >> >
> >> > url: https://github.com/0day-ci/linux/commits/Kalesh-Singh/KVM-arm64-Hypervisor-stack-enhancements/20220223-010522
> >> > base: cfb92440ee71adcc2105b0890bb01ac3cddb8507
> >> > config: arm64-randconfig-r011-20220221 (https://download.01.org/0day-ci/archive/20220223/202202231727.L621fVgD-lkp@intel.com/config)
> >> > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
> >> > reproduce (this is a W=1 build):
> >> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >> > chmod +x ~/bin/make.cross
> >> > # install arm64 cross compiling tool for clang build
> >> > # apt-get install binutils-aarch64-linux-gnu
> >> > # https://github.com/0day-ci/linux/commit/7fe99fd40f7c4b2973218045ca5b9c9160524db1
> >> > git remote add linux-review https://github.com/0day-ci/linux
> >> > git fetch --no-tags linux-review Kalesh-Singh/KVM-arm64-Hypervisor-stack-enhancements/20220223-010522
> >> > git checkout 7fe99fd40f7c4b2973218045ca5b9c9160524db1
> >> > # save the config file to linux build tree
> >> > mkdir build_dir
> >> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/
> >> >
> >> > If you fix the issue, kindly add following tag as appropriate
> >> > Reported-by: kernel test robot <lkp@intel.com>
> >> >
> >> > All warnings (new ones prefixed by >>):
> >> >
> >> > include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
> >> > #define NULL ((void *)0)
> >> > ^~~~~~~~~~~
> >> > arch/arm64/kvm/hyp/nvhe/switch.c:200:27: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
> >> > [ESR_ELx_EC_FP_ASIMD] = kvm_hyp_handle_fpsimd,
> >> > ^~~~~~~~~~~~~~~~~~~~~
> >> > arch/arm64/kvm/hyp/nvhe/switch.c:196:28: note: previous initialization is here
> >> > [0 ... ESR_ELx_EC_MAX] = NULL,
> >> > ^~~~
> >> > include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
> >> > #define NULL ((void *)0)
> >> > ^~~~~~~~~~~
> >>
> >> Kalesh, please ignore this nonsense. There may be things to improve,
> >> but this is *NOT* one of them.
> >>
> >> These reports are pretty useless, and just lead people to ignore real
> >> bug reports.
> >
> > Hi Kalesh, sorry there're some irrelevant issues mixed in the report,
> > kindly ignore them. And the valuable ones are the new ones that
> > prefixed by >>, as the below one in original report.
> >
> >>> arch/arm64/kvm/hyp/nvhe/switch.c:372:17: warning: no previous
> >>> prototype for function 'hyp_panic_bad_stack' [-Wmissing-prototypes]
> > void __noreturn hyp_panic_bad_stack(void)
> > ^
>
> This is only called from assembly code, so a prototype wouldn't bring
> much.
>
Should probably be marked as 'asmlinkage' then. I've suggested many
times already that this bogus diagnostic should either be disabled, or
disregard 'asmlinkage' symbols.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [kbuild-all] Re: [PATCH v2 6/9] KVM: arm64: Detect and handle hypervisor stack overflows
2022-02-23 12:56 ` Ard Biesheuvel
@ 2022-02-24 10:39 ` Marc Zyngier
2022-02-25 2:12 ` Chen, Rong A
0 siblings, 1 reply; 10+ messages in thread
From: Marc Zyngier @ 2022-02-24 10:39 UTC (permalink / raw)
To: Ard Biesheuvel
Cc: Philip Li, Kalesh Singh, kernel test robot, llvm, kbuild-all,
Will Deacon, Quentin Perret, Fuad Tabba, surenb,
Android Kernel Team, Catalin Marinas, James Morse,
Alexandru Elisei, Suzuki K Poulose, Mark Rutland, Pasha Tatashin,
Joey Gouly, Peter Collingbourne, Andrew Scull, Paolo Bonzini,
Zenghui Yu, Linux ARM, Linux Kernel Mailing List, kvmarm
On 2022-02-23 12:56, Ard Biesheuvel wrote:
> On Wed, 23 Feb 2022 at 13:54, Marc Zyngier <maz@kernel.org> wrote:
>>
>> On 2022-02-23 12:34, Philip Li wrote:
>> > On Wed, Feb 23, 2022 at 09:16:59AM +0000, Marc Zyngier wrote:
>> >> On Wed, 23 Feb 2022 09:05:18 +0000,
>> >> kernel test robot <lkp@intel.com> wrote:
>> >> >
>> >> > Hi Kalesh,
>> >> >
>> >> > Thank you for the patch! Perhaps something to improve:
>> >> >
>> >> > [auto build test WARNING on cfb92440ee71adcc2105b0890bb01ac3cddb8507]
>> >> >
>> >> > url: https://github.com/0day-ci/linux/commits/Kalesh-Singh/KVM-arm64-Hypervisor-stack-enhancements/20220223-010522
>> >> > base: cfb92440ee71adcc2105b0890bb01ac3cddb8507
>> >> > config: arm64-randconfig-r011-20220221 (https://download.01.org/0day-ci/archive/20220223/202202231727.L621fVgD-lkp@intel.com/config)
>> >> > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
>> >> > reproduce (this is a W=1 build):
>> >> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>> >> > chmod +x ~/bin/make.cross
>> >> > # install arm64 cross compiling tool for clang build
>> >> > # apt-get install binutils-aarch64-linux-gnu
>> >> > # https://github.com/0day-ci/linux/commit/7fe99fd40f7c4b2973218045ca5b9c9160524db1
>> >> > git remote add linux-review https://github.com/0day-ci/linux
>> >> > git fetch --no-tags linux-review Kalesh-Singh/KVM-arm64-Hypervisor-stack-enhancements/20220223-010522
>> >> > git checkout 7fe99fd40f7c4b2973218045ca5b9c9160524db1
>> >> > # save the config file to linux build tree
>> >> > mkdir build_dir
>> >> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/
>> >> >
>> >> > If you fix the issue, kindly add following tag as appropriate
>> >> > Reported-by: kernel test robot <lkp@intel.com>
>> >> >
>> >> > All warnings (new ones prefixed by >>):
>> >> >
>> >> > include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
>> >> > #define NULL ((void *)0)
>> >> > ^~~~~~~~~~~
>> >> > arch/arm64/kvm/hyp/nvhe/switch.c:200:27: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
>> >> > [ESR_ELx_EC_FP_ASIMD] = kvm_hyp_handle_fpsimd,
>> >> > ^~~~~~~~~~~~~~~~~~~~~
>> >> > arch/arm64/kvm/hyp/nvhe/switch.c:196:28: note: previous initialization is here
>> >> > [0 ... ESR_ELx_EC_MAX] = NULL,
>> >> > ^~~~
>> >> > include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
>> >> > #define NULL ((void *)0)
>> >> > ^~~~~~~~~~~
>> >>
>> >> Kalesh, please ignore this nonsense. There may be things to improve,
>> >> but this is *NOT* one of them.
>> >>
>> >> These reports are pretty useless, and just lead people to ignore real
>> >> bug reports.
>> >
>> > Hi Kalesh, sorry there're some irrelevant issues mixed in the report,
>> > kindly ignore them. And the valuable ones are the new ones that
>> > prefixed by >>, as the below one in original report.
>> >
>> >>> arch/arm64/kvm/hyp/nvhe/switch.c:372:17: warning: no previous
>> >>> prototype for function 'hyp_panic_bad_stack' [-Wmissing-prototypes]
>> > void __noreturn hyp_panic_bad_stack(void)
>> > ^
>>
>> This is only called from assembly code, so a prototype wouldn't bring
>> much.
>>
>
> Should probably be marked as 'asmlinkage' then. I've suggested many
> times already that this bogus diagnostic should either be disabled, or
> disregard 'asmlinkage' symbols.
Yes, asmlinkage is definitely missing.
But it is pretty obvious that the robot people aren't interested in
fixing this particular issue, given how long we have been suggesting
this...
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [kbuild-all] Re: [PATCH v2 6/9] KVM: arm64: Detect and handle hypervisor stack overflows
2022-02-24 10:39 ` Marc Zyngier
@ 2022-02-25 2:12 ` Chen, Rong A
2022-02-25 3:11 ` Kalesh Singh
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Chen, Rong A @ 2022-02-25 2:12 UTC (permalink / raw)
To: Marc Zyngier, Ard Biesheuvel
Cc: Kalesh Singh, kernel test robot, llvm, kbuild-all, Will Deacon,
Quentin Perret, Fuad Tabba, surenb, Android Kernel Team,
Catalin Marinas, James Morse, Alexandru Elisei, Suzuki K Poulose,
Mark Rutland, Pasha Tatashin, Joey Gouly, Peter Collingbourne,
Andrew Scull, Paolo Bonzini, Zenghui Yu, Linux ARM,
Linux Kernel Mailing List, kvmarm
On 2/24/2022 6:39 PM, Marc Zyngier wrote:
> On 2022-02-23 12:56, Ard Biesheuvel wrote:
>> On Wed, 23 Feb 2022 at 13:54, Marc Zyngier <maz@kernel.org> wrote:
>>>
>>> On 2022-02-23 12:34, Philip Li wrote:
>>> > On Wed, Feb 23, 2022 at 09:16:59AM +0000, Marc Zyngier wrote:
>>> >> On Wed, 23 Feb 2022 09:05:18 +0000,
>>> >> kernel test robot <lkp@intel.com> wrote:
>>> >> >
>>> >> > Hi Kalesh,
>>> >> >
>>> >> > Thank you for the patch! Perhaps something to improve:
>>> >> >
>>> >> > [auto build test WARNING on
>>> cfb92440ee71adcc2105b0890bb01ac3cddb8507]
>>> >> >
>>> >> > url:
>>> https://github.com/0day-ci/linux/commits/Kalesh-Singh/KVM-arm64-Hypervisor-stack-enhancements/20220223-010522
>>>
>>> >> > base: cfb92440ee71adcc2105b0890bb01ac3cddb8507
>>> >> > config: arm64-randconfig-r011-20220221
>>> (https://download.01.org/0day-ci/archive/20220223/202202231727.L621fVgD-lkp@intel.com/config)
>>>
>>> >> > compiler: clang version 15.0.0
>>> (https://github.com/llvm/llvm-project
>>> d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
>>> >> > reproduce (this is a W=1 build):
>>> >> > wget
>>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>>> -O ~/bin/make.cross
>>> >> > chmod +x ~/bin/make.cross
>>> >> > # install arm64 cross compiling tool for clang build
>>> >> > # apt-get install binutils-aarch64-linux-gnu
>>> >> > #
>>> https://github.com/0day-ci/linux/commit/7fe99fd40f7c4b2973218045ca5b9c9160524db1
>>>
>>> >> > git remote add linux-review
>>> https://github.com/0day-ci/linux
>>> >> > git fetch --no-tags linux-review
>>> Kalesh-Singh/KVM-arm64-Hypervisor-stack-enhancements/20220223-010522
>>> >> > git checkout 7fe99fd40f7c4b2973218045ca5b9c9160524db1
>>> >> > # save the config file to linux build tree
>>> >> > mkdir build_dir
>>> >> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang
>>> make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/
>>> >> >
>>> >> > If you fix the issue, kindly add following tag as appropriate
>>> >> > Reported-by: kernel test robot <lkp@intel.com>
>>> >> >
>>> >> > All warnings (new ones prefixed by >>):
>>> >> >
>>> >> > include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
>>> >> > #define NULL ((void *)0)
>>> >> > ^~~~~~~~~~~
>>> >> > arch/arm64/kvm/hyp/nvhe/switch.c:200:27: warning: initializer
>>> overrides prior initialization of this subobject
>>> [-Winitializer-overrides]
>>> >> > [ESR_ELx_EC_FP_ASIMD] = kvm_hyp_handle_fpsimd,
>>> >> > ^~~~~~~~~~~~~~~~~~~~~
>>> >> > arch/arm64/kvm/hyp/nvhe/switch.c:196:28: note: previous
>>> initialization is here
>>> >> > [0 ... ESR_ELx_EC_MAX] = NULL,
>>> >> > ^~~~
>>> >> > include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
>>> >> > #define NULL ((void *)0)
>>> >> > ^~~~~~~~~~~
>>> >>
>>> >> Kalesh, please ignore this nonsense. There may be things to improve,
>>> >> but this is *NOT* one of them.
>>> >>
>>> >> These reports are pretty useless, and just lead people to ignore real
>>> >> bug reports.
>>> >
>>> > Hi Kalesh, sorry there're some irrelevant issues mixed in the report,
>>> > kindly ignore them. And the valuable ones are the new ones that
>>> > prefixed by >>, as the below one in original report.
>>> >
>>> >>> arch/arm64/kvm/hyp/nvhe/switch.c:372:17: warning: no previous
>>> >>> prototype for function 'hyp_panic_bad_stack' [-Wmissing-prototypes]
>>> > void __noreturn hyp_panic_bad_stack(void)
>>> > ^
>>>
>>> This is only called from assembly code, so a prototype wouldn't bring
>>> much.
>>>
>>
>> Should probably be marked as 'asmlinkage' then. I've suggested many
>> times already that this bogus diagnostic should either be disabled, or
>> disregard 'asmlinkage' symbols.
>
> Yes, asmlinkage is definitely missing.
>
> But it is pretty obvious that the robot people aren't interested in
> fixing this particular issue, given how long we have been suggesting
> this...
>
> M.
Hi Marc, Ard,
We have ignored the warning related to asmlinkage according to the below
advice:
https://lore.kernel.org/lkml/CAMj1kXHrRYagSVniSetHdG15rkQS+fm4zVOtN=Zda3W0QaEoJA@mail.gmail.com/
do you want the bot ignore such warning if asmlinkage not specified?
Best Regards,
Rong Chen
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [kbuild-all] Re: [PATCH v2 6/9] KVM: arm64: Detect and handle hypervisor stack overflows
2022-02-25 2:12 ` Chen, Rong A
@ 2022-02-25 3:11 ` Kalesh Singh
2022-02-25 15:31 ` Marc Zyngier
2022-02-25 15:38 ` Ard Biesheuvel
2 siblings, 0 replies; 10+ messages in thread
From: Kalesh Singh @ 2022-02-25 3:11 UTC (permalink / raw)
To: Chen, Rong A
Cc: Marc Zyngier, Ard Biesheuvel, kernel test robot, llvm, kbuild-all,
Will Deacon, Quentin Perret, Fuad Tabba, Suren Baghdasaryan,
Android Kernel Team, Catalin Marinas, James Morse,
Alexandru Elisei, Suzuki K Poulose, Mark Rutland, Pasha Tatashin,
Joey Gouly, Peter Collingbourne, Andrew Scull, Paolo Bonzini,
Zenghui Yu, Linux ARM, Linux Kernel Mailing List, kvmarm
On Thu, Feb 24, 2022 at 6:12 PM Chen, Rong A <rong.a.chen@intel.com> wrote:
>
>
>
> On 2/24/2022 6:39 PM, Marc Zyngier wrote:
> > On 2022-02-23 12:56, Ard Biesheuvel wrote:
> >> On Wed, 23 Feb 2022 at 13:54, Marc Zyngier <maz@kernel.org> wrote:
> >>>
> >>> On 2022-02-23 12:34, Philip Li wrote:
> >>> > On Wed, Feb 23, 2022 at 09:16:59AM +0000, Marc Zyngier wrote:
> >>> >> On Wed, 23 Feb 2022 09:05:18 +0000,
> >>> >> kernel test robot <lkp@intel.com> wrote:
> >>> >> >
> >>> >> > Hi Kalesh,
> >>> >> >
> >>> >> > Thank you for the patch! Perhaps something to improve:
> >>> >> >
> >>> >> > [auto build test WARNING on
> >>> cfb92440ee71adcc2105b0890bb01ac3cddb8507]
> >>> >> >
> >>> >> > url:
> >>> https://github.com/0day-ci/linux/commits/Kalesh-Singh/KVM-arm64-Hypervisor-stack-enhancements/20220223-010522
> >>>
> >>> >> > base: cfb92440ee71adcc2105b0890bb01ac3cddb8507
> >>> >> > config: arm64-randconfig-r011-20220221
> >>> (https://download.01.org/0day-ci/archive/20220223/202202231727.L621fVgD-lkp@intel.com/config)
> >>>
> >>> >> > compiler: clang version 15.0.0
> >>> (https://github.com/llvm/llvm-project
> >>> d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
> >>> >> > reproduce (this is a W=1 build):
> >>> >> > wget
> >>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> >>> -O ~/bin/make.cross
> >>> >> > chmod +x ~/bin/make.cross
> >>> >> > # install arm64 cross compiling tool for clang build
> >>> >> > # apt-get install binutils-aarch64-linux-gnu
> >>> >> > #
> >>> https://github.com/0day-ci/linux/commit/7fe99fd40f7c4b2973218045ca5b9c9160524db1
> >>>
> >>> >> > git remote add linux-review
> >>> https://github.com/0day-ci/linux
> >>> >> > git fetch --no-tags linux-review
> >>> Kalesh-Singh/KVM-arm64-Hypervisor-stack-enhancements/20220223-010522
> >>> >> > git checkout 7fe99fd40f7c4b2973218045ca5b9c9160524db1
> >>> >> > # save the config file to linux build tree
> >>> >> > mkdir build_dir
> >>> >> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang
> >>> make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/
> >>> >> >
> >>> >> > If you fix the issue, kindly add following tag as appropriate
> >>> >> > Reported-by: kernel test robot <lkp@intel.com>
> >>> >> >
> >>> >> > All warnings (new ones prefixed by >>):
> >>> >> >
> >>> >> > include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
> >>> >> > #define NULL ((void *)0)
> >>> >> > ^~~~~~~~~~~
> >>> >> > arch/arm64/kvm/hyp/nvhe/switch.c:200:27: warning: initializer
> >>> overrides prior initialization of this subobject
> >>> [-Winitializer-overrides]
> >>> >> > [ESR_ELx_EC_FP_ASIMD] = kvm_hyp_handle_fpsimd,
> >>> >> > ^~~~~~~~~~~~~~~~~~~~~
> >>> >> > arch/arm64/kvm/hyp/nvhe/switch.c:196:28: note: previous
> >>> initialization is here
> >>> >> > [0 ... ESR_ELx_EC_MAX] = NULL,
> >>> >> > ^~~~
> >>> >> > include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
> >>> >> > #define NULL ((void *)0)
> >>> >> > ^~~~~~~~~~~
> >>> >>
> >>> >> Kalesh, please ignore this nonsense. There may be things to improve,
> >>> >> but this is *NOT* one of them.
> >>> >>
> >>> >> These reports are pretty useless, and just lead people to ignore real
> >>> >> bug reports.
> >>> >
> >>> > Hi Kalesh, sorry there're some irrelevant issues mixed in the report,
> >>> > kindly ignore them. And the valuable ones are the new ones that
> >>> > prefixed by >>, as the below one in original report.
> >>> >
> >>> >>> arch/arm64/kvm/hyp/nvhe/switch.c:372:17: warning: no previous
> >>> >>> prototype for function 'hyp_panic_bad_stack' [-Wmissing-prototypes]
> >>> > void __noreturn hyp_panic_bad_stack(void)
> >>> > ^
> >>>
> >>> This is only called from assembly code, so a prototype wouldn't bring
> >>> much.
> >>>
> >>
> >> Should probably be marked as 'asmlinkage' then. I've suggested many
> >> times already that this bogus diagnostic should either be disabled, or
> >> disregard 'asmlinkage' symbols.
> >
> > Yes, asmlinkage is definitely missing.
> >
> > But it is pretty obvious that the robot people aren't interested in
> > fixing this particular issue, given how long we have been suggesting
> > this...
> >
> > M.
>
> Hi Marc, Ard,
>
> We have ignored the warning related to asmlinkage according to the below
> advice:
>
> https://lore.kernel.org/lkml/CAMj1kXHrRYagSVniSetHdG15rkQS+fm4zVOtN=Zda3W0QaEoJA@mail.gmail.com/
>
> do you want the bot ignore such warning if asmlinkage not specified?
Hi Rong,
I have added asmlinkage to the functions without a prototype in later
versions of the patch.
Perhaps the report should be updated to say "functions only called
from assembly code should be annotated with the asmlinkage attribute"
if the error is a missing prototype
Thanks,
Kalesh
>
> Best Regards,
> Rong Chen
>
> --
> To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com.
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [kbuild-all] Re: [PATCH v2 6/9] KVM: arm64: Detect and handle hypervisor stack overflows
2022-02-25 2:12 ` Chen, Rong A
2022-02-25 3:11 ` Kalesh Singh
@ 2022-02-25 15:31 ` Marc Zyngier
2022-02-25 15:38 ` Ard Biesheuvel
2 siblings, 0 replies; 10+ messages in thread
From: Marc Zyngier @ 2022-02-25 15:31 UTC (permalink / raw)
To: Chen, Rong A
Cc: Ard Biesheuvel, Kalesh Singh, kernel test robot, llvm, kbuild-all,
Will Deacon, Quentin Perret, Fuad Tabba, surenb,
Android Kernel Team, Catalin Marinas, James Morse,
Alexandru Elisei, Suzuki K Poulose, Mark Rutland, Pasha Tatashin,
Joey Gouly, Peter Collingbourne, Andrew Scull, Paolo Bonzini,
Zenghui Yu, Linux ARM, Linux Kernel Mailing List, kvmarm
On Fri, 25 Feb 2022 02:12:32 +0000,
"Chen, Rong A" <rong.a.chen@intel.com> wrote:
>
> Hi Marc, Ard,
>
> We have ignored the warning related to asmlinkage according to the
> below advice:
>
> https://lore.kernel.org/lkml/CAMj1kXHrRYagSVniSetHdG15rkQS+fm4zVOtN=Zda3W0QaEoJA@mail.gmail.com/
Ah, I didn't realise it had been updated. Apologies for the shouting!
> do you want the bot ignore such warning if asmlinkage not specified?
No, there is some value in warning about this particular case.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [kbuild-all] Re: [PATCH v2 6/9] KVM: arm64: Detect and handle hypervisor stack overflows
2022-02-25 2:12 ` Chen, Rong A
2022-02-25 3:11 ` Kalesh Singh
2022-02-25 15:31 ` Marc Zyngier
@ 2022-02-25 15:38 ` Ard Biesheuvel
2 siblings, 0 replies; 10+ messages in thread
From: Ard Biesheuvel @ 2022-02-25 15:38 UTC (permalink / raw)
To: Chen, Rong A
Cc: Marc Zyngier, Kalesh Singh, kernel test robot, llvm, kbuild-all,
Will Deacon, Quentin Perret, Fuad Tabba, Suren Baghdasaryan,
Android Kernel Team, Catalin Marinas, James Morse,
Alexandru Elisei, Suzuki K Poulose, Mark Rutland, Pasha Tatashin,
Joey Gouly, Peter Collingbourne, Andrew Scull, Paolo Bonzini,
Zenghui Yu, Linux ARM, Linux Kernel Mailing List, kvmarm
On Fri, 25 Feb 2022 at 03:12, Chen, Rong A <rong.a.chen@intel.com> wrote:
>
>
>
> Hi Marc, Ard,
>
> We have ignored the warning related to asmlinkage according to the below
> advice:
>
> https://lore.kernel.org/lkml/CAMj1kXHrRYagSVniSetHdG15rkQS+fm4zVOtN=Zda3W0QaEoJA@mail.gmail.com/
>
Excellent! Thanks for implementing this - I wasn't aware that you
adopted this suggestion.
> do you want the bot ignore such warning if asmlinkage not specified?
>
Even though I think this warning has little value, I think asmlinkage
is sufficient for us to avoid it for symbols that are exported for use
by assembler code.
So I don't think this additional change is needed.
--
Ard.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-02-25 15:38 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220222165212.2005066-7-kaleshsingh@google.com>
2022-02-23 9:05 ` [PATCH v2 6/9] KVM: arm64: Detect and handle hypervisor stack overflows kernel test robot
2022-02-23 9:16 ` Marc Zyngier
2022-02-23 12:34 ` [kbuild-all] " Philip Li
2022-02-23 12:54 ` Marc Zyngier
2022-02-23 12:56 ` Ard Biesheuvel
2022-02-24 10:39 ` Marc Zyngier
2022-02-25 2:12 ` Chen, Rong A
2022-02-25 3:11 ` Kalesh Singh
2022-02-25 15:31 ` Marc Zyngier
2022-02-25 15:38 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).