Re: [tip:core/entry 2/3] arch/s390/include/asm/entry-common.h:49:18: error: call to undeclared function 'task_stack_page'; ISO C99 and later do not support implicit function declarations

[Thomas Gleixner <tglx@kernel.org>]

On Wed, Jul 08 2026 at 14:56, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core/entry
> head:   34ef6308418f138395a664bf9f5d80ace9825ac6
> commit: 7fc04d7044aaa5ffe2afe78979fe6ddd5da24f10 [2/3] syscall_user_dispatch: Make it configurable in Kconfig
> config: s390-allnoconfig (https://download.01.org/0day-ci/archive/20260708/202607081402.DO1ePla3-lkp@intel.com/config)
> compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 0a2fb2a2269da0e2a3e230beb6cad39ca314db33)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260708/202607081402.DO1ePla3-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202607081402.DO1ePla3-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>    In file included from arch/s390/kernel/traps.c:24:
>    In file included from include/linux/entry-common.h:5:
>>> arch/s390/include/asm/entry-common.h:49:18: error: call to undeclared function 'task_stack_page'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>       49 |         pai_kernel_exit(current_pt_regs());

Bah. I missed to spot the header ordering change putting the
asm/... includes in front. I really hate our include mess.

Let me fix that up.

Thanks,

        tglx
---        
diff --git a/include/linux/entry-common.h b/include/linux/entry-common.h
index 43afee3e1b29..9336516430a1 100644
--- a/include/linux/entry-common.h
+++ b/include/linux/entry-common.h
@@ -2,8 +2,6 @@
 #ifndef __LINUX_ENTRYCOMMON_H
 #define __LINUX_ENTRYCOMMON_H
 
-#include <asm/entry-common.h>
-#include <asm/syscall.h>
 #include <linux/audit.h>
 #include <linux/irq-entry-common.h>
 #include <linux/livepatch.h>
@@ -13,6 +11,9 @@
 #include <linux/sched.h>
 #include <linux/syscall_user_dispatch.h>
 
+#include <asm/entry-common.h>
+#include <asm/syscall.h>
+
 #ifndef _TIF_UPROBE
 # define _TIF_UPROBE			(0)
 #endif
diff --git a/kernel/entry/syscall_user_dispatch.c b/kernel/entry/syscall_user_dispatch.c
index 310c72e6988d..2002c7aae435 100644
--- a/kernel/entry/syscall_user_dispatch.c
+++ b/kernel/entry/syscall_user_dispatch.c
@@ -2,8 +2,6 @@
 /*
  * Copyright (C) 2020 Collabora Ltd.
  */
-
-#include <asm/syscall.h>
 #include <linux/elf.h>
 #include <linux/entry-common.h>
 #include <linux/prctl.h>
@@ -16,6 +14,8 @@
 #include <linux/sysctl.h>
 #include <linux/uaccess.h>
 
+#include <asm/syscall.h>
+
 static bool syscall_user_dispatch_allowed __read_mostly = true;
 
 static void trigger_sigsys(struct pt_regs *regs)