From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEDCD1ADC7E; Tue, 14 Jan 2025 10:03:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736849015; cv=none; b=ub/p2DuoM2+Zbez++BCjjNVz3/C/Eaai8H82R+xbnlf53sZ8pu6m4cwe1sUxoQ3vlhtBcx2sBZU4vCPLYbWw1UztGYFB7hkbcXjYjU62sREAtM/DE+Ep/+Xu/cjstEpbIcZRC8qZDHtdKee7s09YCrZVZob9xx4KOckksMSzdQE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736849015; c=relaxed/simple; bh=XxBl7fqbol2wF8Nze2ZnW9469ZvGsqPLH3XklpIMLVY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=HYCTQZ8hyvCFOoDEP4Mz7SjBLBFsmPOXYJy99Ob92sAoS0YysrBoes6ovDa3L2QWbBeNQaihDqv8d6mWETi6robA8GqK88RWoBBMoL7HU+pM2i8COvxAaClvrUjrR4ijyf6kN8VbjB4Go+tACZLZPEZitdKGocgouJxiDxNIoWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Rs/mdunU; arc=none smtp.client-ip=217.70.183.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Rs/mdunU" Received: by mail.gandi.net (Postfix) with ESMTPSA id A08241BF208; Tue, 14 Jan 2025 10:03:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1736849004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RZP+d0H4m0h7sGo8b5wNABwTCHdXtZyl2DG9g0bftT0=; b=Rs/mdunUKsfz0B3EOWPoFv8ZvGeGvqE6sSFNxtiw+SqUJdkHeFRhbsFkBx6rcBd36R/wVB VJILrx+XzxVNrrwb9uPPRIBM4POEsgsZ/DdhAXUKchNYvAZQsfO8a/Jo/5zuGdGbjIi90m mgEtqd+j+HHkUQ9QQl6pg7AtjBw0Z3tESBlGeR5RH0UPaLwBiW+6pnySRT6hWu+iIQ9uAC rV7q/7sPWY7aUunidaMAZ8GkJStpVq3SWbjlIpKAkOmxqjkFjzBV4qTzi5YKjuNRFO4C9H 6qAfLa52XWbCsfKL71ULMA7T2asERC8mrjkWvY+OqWc2HUJ5DrkP28KLoG7UwQ== From: Miquel Raynal To: Mark Brown Cc: Raju Rangoju , Nathan Chancellor , linux-spi@vger.kernel.org, llvm@lists.linux.dev, patches@lists.linux.dev, kernel test robot Subject: Re: [PATCH] spi: amd: Fix -Wuninitialized in amd_spi_exec_mem_op() In-Reply-To: <173678670956.71125.2320310623665812760.b4-ty@kernel.org> (Mark Brown's message of "Mon, 13 Jan 2025 16:45:09 +0000") References: <20250111-spi-amd-fix-uninitialized-ret-v1-1-c66ab9f6a23d@kernel.org> <173678670956.71125.2320310623665812760.b4-ty@kernel.org> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Tue, 14 Jan 2025 11:03:22 +0100 Message-ID: <87h661u2z9.fsf@bootlin.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hi Mark, On 13/01/2025 at 16:45:09 GMT, Mark Brown wrote: > On Sat, 11 Jan 2025 12:08:38 -0700, Nathan Chancellor wrote: >> After commit e6204f39fe3a ("spi: amd: Drop redundant check"), clang warn= s (or >> errors with CONFIG_WERROR=3Dy): >>=20 >> drivers/spi/spi-amd.c:695:9: error: variable 'ret' is uninitialized wh= en used here [-Werror,-Wuninitialized] >> 695 | return ret; >> | ^~~ >> drivers/spi/spi-amd.c:673:9: note: initialize the variable 'ret' to si= lence this warning >> 673 | int ret; >> | ^ >> | =3D 0 >> 1 error generated. >>=20 >> [...] > > Applied to > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-ne= xt > > Thanks! I'm wondering whether it's relevant to pull the branch you shared as-is. Do you plan on pushing this patch of top of it? Or shall I wait -rc1 for the SPI NAND part? Thanks, Miqu=C3=A8l