public inbox for llvm@lists.linux.dev
 help / color / mirror / Atom feed
From: Gabriel Krisman Bertazi <krisman@suse.de>
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev,  llvm@lists.linux.dev,
	io-uring@vger.kernel.org
Subject: Re: [axboe-block:for-6.10/io_uring 42/42] io_uring/register.c:175:24: warning: arithmetic between different enumeration types ('enum io_uring_register_restriction_op' and 'enum io_uring_register_op')
Date: Fri, 29 Mar 2024 18:04:29 -0400	[thread overview]
Message-ID: <87h6go66fm.fsf@mailhost.krisman.be> (raw)
In-Reply-To: <202403291458.6AjzdI64-lkp@intel.com> (kernel test robot's message of "Fri, 29 Mar 2024 14:23:33 +0800")

kernel test robot <lkp@intel.com> writes:

[+ io_uring list ]

>>> io_uring/register.c:175:24: warning: arithmetic between different
> enumeration types ('enum io_uring_register_restriction_op' and 'enum
> io_uring_register_op') [-Wenum-enum-conversion]
>      175 |         if (!arg || nr_args > IORING_MAX_RESTRICTIONS)
>          |                               ^~~~~~~~~~~~~~~~~~~~~~~
>    io_uring/register.c:31:58: note: expanded from macro 'IORING_MAX_RESTRICTIONS'
>       31 | #define IORING_MAX_RESTRICTIONS (IORING_RESTRICTION_LAST + \
>          |                                  ~~~~~~~~~~~~~~~~~~~~~~~ ^
>       32 |                                  IORING_REGISTER_LAST + IORING_OP_LAST)
>          |                                  ~~~~~~~~~~~~~~~~~~~~
>    14 warnings generated.

hm.

Do we want to fix?  The arithmetic is safe here.  I actually tried
triggering the warning with gcc, but even with -Wenum-conversion in
gcc-12 (which is in -Wextra and we don't use in the kernel build), I
couldn't do it.  only llvm catches this.

can we explicit cast to int to silent it?

-- 
Gabriel Krisman Bertazi

  reply	other threads:[~2024-03-29 22:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-29  6:23 [axboe-block:for-6.10/io_uring 42/42] io_uring/register.c:175:24: warning: arithmetic between different enumeration types ('enum io_uring_register_restriction_op' and 'enum io_uring_register_op') kernel test robot
2024-03-29 22:04 ` Gabriel Krisman Bertazi [this message]
2024-03-29 23:15   ` Jens Axboe
2024-04-01 19:35     ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6go66fm.fsf@mailhost.krisman.be \
    --to=krisman@suse.de \
    --cc=io-uring@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox