From: Takashi Iwai <tiwai@suse.de>
To: Tom Rix <trix@redhat.com>
Cc: perex@perex.cz, tiwai@suse.com, nathan@kernel.org,
ndesaulniers@google.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] ALSA: portman2x4: remove unused portman_read_command,data functions
Date: Sun, 19 Mar 2023 09:11:04 +0100 [thread overview]
Message-ID: <87lejtma93.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230318135229.1685266-1-trix@redhat.com>
On Sat, 18 Mar 2023 14:52:29 +0100,
Tom Rix wrote:
>
> clang with W=1 reports
> sound/drivers/portman2x4.c:185:18: error: unused function
> 'portman_read_command' [-Werror,-Wunused-function]
> static inline u8 portman_read_command(struct portman *pm)
> ^
> sound/drivers/portman2x4.c:195:18: error: unused function
> 'portman_read_data' [-Werror,-Wunused-function]
> static inline u8 portman_read_data(struct portman *pm)
> ^
> These static functions are not used, so remove them.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Applied now, thanks.
Takashi
prev parent reply other threads:[~2023-03-19 8:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 13:52 [PATCH] ALSA: portman2x4: remove unused portman_read_command,data functions Tom Rix
2023-03-19 8:11 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lejtma93.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox